Skip to Content
Odoo Menu
  • Sign in
  • Try it free
  • Apps
    Finance
    • Accounting
    • Invoicing
    • Expenses
    • Spreadsheet (BI)
    • Documents
    • Sign
    Sales
    • CRM
    • Sales
    • POS Shop
    • POS Restaurant
    • Subscriptions
    • Rental
    Websites
    • Website Builder
    • eCommerce
    • Blog
    • Forum
    • Live Chat
    • eLearning
    Supply Chain
    • Inventory
    • Manufacturing
    • PLM
    • Purchase
    • Maintenance
    • Quality
    Human Resources
    • Employees
    • Recruitment
    • Time Off
    • Appraisals
    • Referrals
    • Fleet
    Marketing
    • Social Marketing
    • Email Marketing
    • SMS Marketing
    • Events
    • Marketing Automation
    • Surveys
    Services
    • Project
    • Timesheets
    • Field Service
    • Helpdesk
    • Planning
    • Appointments
    Productivity
    • Discuss
    • Approvals
    • IoT
    • VoIP
    • Knowledge
    • WhatsApp
    Third party apps Odoo Studio Odoo Cloud Platform
  • Industries
    Retail
    • Book Store
    • Clothing Store
    • Furniture Store
    • Grocery Store
    • Hardware Store
    • Toy Store
    Food & Hospitality
    • Bar and Pub
    • Restaurant
    • Fast Food
    • Guest House
    • Beverage Distributor
    • Hotel
    Real Estate
    • Real Estate Agency
    • Architecture Firm
    • Construction
    • Estate Management
    • Gardening
    • Property Owner Association
    Consulting
    • Accounting Firm
    • Odoo Partner
    • Marketing Agency
    • Law firm
    • Talent Acquisition
    • Audit & Certification
    Manufacturing
    • Textile
    • Metal
    • Furnitures
    • Food
    • Brewery
    • Corporate Gifts
    Health & Fitness
    • Sports Club
    • Eyewear Store
    • Fitness Center
    • Wellness Practitioners
    • Pharmacy
    • Hair Salon
    Trades
    • Handyman
    • IT Hardware & Support
    • Solar Energy Systems
    • Shoe Maker
    • Cleaning Services
    • HVAC Services
    Others
    • Nonprofit Organization
    • Environmental Agency
    • Billboard Rental
    • Photography
    • Bike Leasing
    • Software Reseller
    Browse all Industries
  • Community
    Learn
    • Tutorials
    • Documentation
    • Certifications
    • Training
    • Blog
    • Podcast
    Empower Education
    • Education Program
    • Scale Up! Business Game
    • Visit Odoo
    Get the Software
    • Download
    • Compare Editions
    • Releases
    Collaborate
    • Github
    • Forum
    • Events
    • Translations
    • Become a Partner
    • Services for Partners
    • Register your Accounting Firm
    Get Services
    • Find a Partner
    • Find an Accountant
    • Meet an advisor
    • Implementation Services
    • Customer References
    • Support
    • Upgrades
    Github Youtube Twitter Linkedin Instagram Facebook Spotify
    +1 (650) 691-3277
    Get a demo
  • Pricing
  • Help

Odoo is the world's easiest all-in-one management software.
It includes hundreds of business apps:

  • CRM
  • e-Commerce
  • Accounting
  • Inventory
  • PoS
  • Project
  • MRP
All apps
You need to be registered to interact with the community.
All Posts People Badges
Tags (View all)
odoo accounting v14 pos v15
About this forum
You need to be registered to interact with the community.
All Posts People Badges
Tags (View all)
odoo accounting v14 pos v15
About this forum
Help

Is this a correct cron job?

Subscribe

Get notified when there's activity on this post

This question has been flagged
functioncron
1 Reply
10040 Views
Avatar
Carlos Llamacho

I tried to create a programmed action in one module. Declared this in my view.

<record id="ir_cron_personnel_actions" model="ir.cron">
        <field name="name">Run Personnel Actions Job</field>
        <field eval="True" name="active"/>
        <field name="user_id" ref="base.user_root"/>
        <field name="interval_number">1</field>
        <field name="interval_type">days</field>
        <field name="numbercall">-1</field>
        <field eval="'hr.personnel.action'" name="model"/>
        <field eval="'run_personnel_actions'" name="function"/>
        <field eval="'()'" name="args"/>
    </record>

And then declared this on my .py file.

def run_personnel_actions(self, cr, uid, ids, context=None):
        """Runs a determined action on the date set in the field effective_date.

        Returns None"""

        #This variables holds the objects we are going to be using in each action.
        hr_obj = self.pool.get('hr.employee')
        hr_cont_obj = self.pool.get('hr.contract')
        hr_cont_rate_obj = self.pool.get('hr.contract.rate')
        hr_holiday = self.pool.get('hr.holidays')
        hr_pay_obj = self.pool.get('hr.payslip')
        hr_payslip_obj = self.pool.get('hr.payslip.input')

        actions = self.browse(cr, uid, ids, context=None)
        #Loop for traversing all records in the hr.personnel.action table and if the status is for approved and the date is today, run them.
        for action in actions:
            #These variables hold the ids of the contract and payroll associated to the employee.
            hr_cont_id = hr_cont_obj.search(cr, uid, [('employee_id', '=', action.employee_id.id)],
                                   order='id', context=None)
            hr_pay_id = hr_pay_obj.search(cr, uid, [('employee_id', '=', action.employee_id.id)], 
                                 order='id', context=None)
            hr_cont_record = hr_cont_obj.browse(cr, uid, hr_cont_id[-1], context=None)

            if action.states == 'approved' and action.effective_date == datetime.date.today():
                if action.action_requested == '1':
                    hr_payslip_obj.create(cr, uid, {'contract_id':hr_cont_id[-1], 
                                    'amount':action.proposed_bonus, 
                                    'name':"Bonus payment", 
                                    'code':1, 
                                    'payslip_id':hr_pay_id[0]}, context=None)
                    self.write(cr, uid, ids, {'states':'applied'}, context=None)

But so far it doesn't run when is supposed to, and doesn't raisee any error at all.

1
Avatar
Discard
Avatar
AJ Schrafel Paper Corp
Best Answer

try making it like this.

<record id="ir_cron_personnel_actions" model="ir.cron">
        <field name="name">Run Personnel Actions Job</field>
        <field name="active" eval="True"/>
        <field name="interval_number">1</field>
        <field name="interval_type">days</field>
        <field name="numbercall">-1</field>
        <field name="doall" eval="False"/>
        <field name="model">hr.personnel.action</field>
        <field name="function">run_personnel_actions</field>
        <field name="args">()</field>
    </record>

Create a test button to make sure the function works or increase interval so you can see if the fuction works correctly.

1
Avatar
Discard
Carlos Llamacho
Author

Hi, thanks for the answer. I try changing it like you suggested and make a button that called the same function. The button did what's supposed to, but still the action pass and nothing happens. I know the job is running as i can see how it changes the next date to be performed. I am thinking, if i pass the function the args (self, cr, uid, ids, context=None) that ids i supposed to take all the records in my table, right? Maybe that is the issue, what do you think?

Carlos Llamacho
Author

When you pass the <field name="args">()</field> that is supposed to get all records on the object that the function is stored? I think the problem may be that when the function is called the ids doesn't pass all the records ids, and therefore it doesn't get running. That would explain why when the button is called it runs, because it pass the id of the record i am currently in. I am correct?

Enjoying the discussion? Don't just read, join in!

Create an account today to enjoy exclusive features and engage with our awesome community!

Sign up
Related Posts Replies Views Activity
cron with function not working
function cron website
Avatar
Avatar
1
Jul 21
4772
production of not enough materials for a PO
function
Avatar
Avatar
Avatar
2
Sep 25
1104
POS Product Category Community Edition
function
Avatar
Avatar
1
Sep 25
1775
Options for collections management addons for museums or private collection
function
Avatar
0
Jul 25
1168
No funcionan los marcadores de posición dinámicos en las plantillas de correo.
function
Avatar
0
Mar 25
1558
Community
  • Tutorials
  • Documentation
  • Forum
Open Source
  • Download
  • Github
  • Runbot
  • Translations
Services
  • Odoo.sh Hosting
  • Support
  • Upgrade
  • Custom Developments
  • Education
  • Find an Accountant
  • Find a Partner
  • Become a Partner
About us
  • Our company
  • Brand Assets
  • Contact us
  • Jobs
  • Events
  • Podcast
  • Blog
  • Customers
  • Legal • Privacy
  • Security
الْعَرَبيّة Català 简体中文 繁體中文 (台灣) Čeština Dansk Nederlands English Suomi Français Deutsch हिंदी Bahasa Indonesia Italiano 日本語 한국어 (KR) Lietuvių kalba Język polski Português (BR) română русский язык Slovenský jazyk slovenščina Español (América Latina) Español ภาษาไทย Türkçe українська Tiếng Việt

Odoo is a suite of open source business apps that cover all your company needs: CRM, eCommerce, accounting, inventory, point of sale, project management, etc.

Odoo's unique value proposition is to be at the same time very easy to use and fully integrated.

Website made with

Odoo Experience on YouTube

1. Use the live chat to ask your questions.
2. The operator answers within a few minutes.

Live support on Youtube
Watch now