Skip to Content
This question has been flagged
1 Odpoveď
217 Zobrazenia
Avatar
Carlton Passley

Problem Summary

We have successfully installed a custom Jamaican Payroll module (cp_jamaican_payroll) on Odoo 19.0 (Odoo.sh Enterprise), but the payslip calculation fails because the custom rules are not running, despite numerous fixes.

The final issue is a database execution problem where the core system fails to see the necessary links, resulting in a Net Salary = Gross Salary output.

1. Environment and Final Status

ItemStatus / ValueNotes
Odoo Version19.0 (Odoo.sh Enterprise)


Module Namecp_jamaican_payroll


Failing Elementhr.salary.rule computation


Payslip OutputBasic Salary ($200k) = Net Salary ($200k)Rules are not being executed.

2. Technical Symptoms and Code Failures

All code logic for the Jamaican deductions (PAYE, NHT, NIS) has been verified and is correct. The failure is a structural database issue.

A. The Core Error (Prevents Calculation)

When the payslip is computed, the rules fail because the context variable for the contract is not passed correctly:

NameError: name 'contract' is not defined

B. The Structural Problem (Prevents Module Load)

The attempt to fix the NameError by inserting the struct_id into the XML failed repeatedly, proving that the External ID is incorrect or corrupted in the database:

ValueError: External ID not found in the system: hr_payroll.structure_employee

This occurred across multiple attempts, including variations like hr_payroll.basic_structure.

C. The Code Solution Attempted

To fix both issues, we deleted the custom structure definition and instead tried to override the default "Regular Pay" structure using its default ID (hr_payroll.structure_employee) and the rules' XML IDs (jm_salary_rule_nht_employee, etc.).

Final Configuration (Code is Clean):

XML

<record id="jm_salary_rule_nht_employee" model="hr.salary.rule">
    <field name="struct_id" ref="hr_payroll.structure_employee"/>
    <field name="condition_python">result = employee.contract_id and employee.contract_id.wage > 0</field> 
</record>

<record id="hr_payroll_structure_employee" model="hr.payroll.structure">
    <field name="rule_ids" eval="[
        (4, ref('jm_salary_rule_nht_employee')),
        (4, ref('jm_salary_rule_nis_employee')),
        ... (etc.) ...
    ]"/>
</record>

What is the definitive, working XML ID for the base Employee Salary Structure in Odoo 19, or is there a required inheritance missing in the module's Python that prevents the contract object from loading?
Avatar
Zrušiť
Carlton Passley
Autor

Thank you that was very helpful, matter resolve.

Avatar
Cybrosys Techno Solutions Pvt.Ltd
Best Answer

Hi,


Odoo 19 no longer uses the old salary structure XML IDs found in earlier versions, such as hr_payroll.structure_employee or hr_payroll.basic_structure. These IDs simply do not exist in this version, which is why your module fails to load them and your salary rules never attach to a valid structure. As a result, the payslip has no active rules, and the rule context never includes a contract object—leading to errors like “NameError: contract is not defined” and a net salary equal to the gross salary.

In Odoo 19, the correct base structure is hr_payroll.structure_base, and the employee structure type is hr_payroll.structure_type_employee. Your custom Jamaican payroll rules must be linked to this new base structure, and your module should extend it through inheritance. Once the rules are properly attached to the Odoo 19 payroll structure hierarchy, the system will correctly pass the contract object to rule evaluation and execute all deductions (PAYE, NHT, NIS) normally.

The solution involves updating your XML to reference the new structure IDs, attaching your rules to structure_base, and extending that structure to include all Jamaican rules. After that, setting the proper default structure type ensures contracts and payslips use the updated structure correctly, resolving both the loading issue and the rule execution failure.

Hope it helps

Avatar
Zrušiť