Web Controller: When does database transaction commit?

Question

Say I have a custom web controller e.g.
@http.route(....)
def myroute(self, ...):
order = request.env['sale.order'].browse(some_id)
product = request.env['product.product'].ref('mymodule.product1')
product.write({'list_price': -100})
order._cart_update(product_id=product.id, set_qty=1, add_qty=1)
return request.render('mymodule.mytemplate', {...})
I'm concerned that the product update could be overwritten before it's added to the cart, which is theoretically possible if the controller method isn

Ravi Gadhia · Accepted Answer

In odoo transaction atomic at the request(http) level, it binds with HTTP layer
when any request comes odoo create a new  environment [1]  for it.
when request(thread) return the result to a client cursor attached to it has been explicitly committed (unless there is no traceback) ref:  https://github.com/odoo/odoo/blob/12.0/odoo/http.py#L285 [2]
so in your case, `list_price` value change inside _cart_update it will be updated at the end of the request dispatch and very next request get new value

Related Posts	Replies	Views
How to add simple logic inside methods of Odoo 16 website controller? controllers	3 Jun 24	1830
Controller giving 404 Error controllers	0 Apr 24	548
understanding Odoo Frame work Solved framework	2 Mar 24	4297
Controller or middleware that handles all the requests controllers	1 Mar 23	1959
How to handle HTTP and JSON request from the same controller ? json controllers framework http 13.0	1 Oct 21	7820

This question has been flagged

Enjoying the discussion? Don't just read, join in!