Skip to Content
Odoo Menu
  • Sign in
  • Try it free
  • Apps
    Finance
    • Accounting
    • Invoicing
    • Expenses
    • Spreadsheet (BI)
    • Documents
    • Sign
    Sales
    • CRM
    • Sales
    • POS Shop
    • POS Restaurant
    • Subscriptions
    • Rental
    Websites
    • Website Builder
    • eCommerce
    • Blog
    • Forum
    • Live Chat
    • eLearning
    Supply Chain
    • Inventory
    • Manufacturing
    • PLM
    • Purchase
    • Maintenance
    • Quality
    Human Resources
    • Employees
    • Recruitment
    • Time Off
    • Appraisals
    • Referrals
    • Fleet
    Marketing
    • Social Marketing
    • Email Marketing
    • SMS Marketing
    • Events
    • Marketing Automation
    • Surveys
    Services
    • Project
    • Timesheets
    • Field Service
    • Helpdesk
    • Planning
    • Appointments
    Productivity
    • Discuss
    • Approvals
    • IoT
    • VoIP
    • Knowledge
    • WhatsApp
    Third party apps Odoo Studio Odoo Cloud Platform
  • Industries
    Retail
    • Book Store
    • Clothing Store
    • Furniture Store
    • Grocery Store
    • Hardware Store
    • Toy Store
    Food & Hospitality
    • Bar and Pub
    • Restaurant
    • Fast Food
    • Guest House
    • Beverage Distributor
    • Hotel
    Real Estate
    • Real Estate Agency
    • Architecture Firm
    • Construction
    • Estate Management
    • Gardening
    • Property Owner Association
    Consulting
    • Accounting Firm
    • Odoo Partner
    • Marketing Agency
    • Law firm
    • Talent Acquisition
    • Audit & Certification
    Manufacturing
    • Textile
    • Metal
    • Furnitures
    • Food
    • Brewery
    • Corporate Gifts
    Health & Fitness
    • Sports Club
    • Eyewear Store
    • Fitness Center
    • Wellness Practitioners
    • Pharmacy
    • Hair Salon
    Trades
    • Handyman
    • IT Hardware & Support
    • Solar Energy Systems
    • Shoe Maker
    • Cleaning Services
    • HVAC Services
    Others
    • Nonprofit Organization
    • Environmental Agency
    • Billboard Rental
    • Photography
    • Bike Leasing
    • Software Reseller
    Browse all Industries
  • Community
    Learn
    • Tutorials
    • Documentation
    • Certifications
    • Training
    • Blog
    • Podcast
    Empower Education
    • Education Program
    • Scale Up! Business Game
    • Visit Odoo
    Get the Software
    • Download
    • Compare Editions
    • Releases
    Collaborate
    • Github
    • Forum
    • Events
    • Translations
    • Become a Partner
    • Services for Partners
    • Register your Accounting Firm
    Get Services
    • Find a Partner
    • Find an Accountant
    • Meet an advisor
    • Implementation Services
    • Customer References
    • Support
    • Upgrades
    Github Youtube Twitter Linkedin Instagram Facebook Spotify
    +1 (650) 691-3277
    Get a demo
  • Pricing
  • Help

Odoo is the world's easiest all-in-one management software.
It includes hundreds of business apps:

  • CRM
  • e-Commerce
  • Accounting
  • Inventory
  • PoS
  • Project
  • MRP
All apps
You need to be registered to interact with the community.
All Posts People Badges
Tags (View all)
odoo accounting v14 pos v15
About this forum
You need to be registered to interact with the community.
All Posts People Badges
Tags (View all)
odoo accounting v14 pos v15
About this forum
Help

Value returned in onchange function not reflecting in UI

Subscribe

Get notified when there's activity on this post

This question has been flagged
ormonchangeodoo-10
2 Replies
7502 Views
Avatar
sukesh

I have a simple onchange function in which I am writing to a few fields. But the value returned as "vals" isn't getting to the frontend. The values returned in the network tab for Here is the function:

	@api.multi
	@api.onchange('email')
	def onchange_email(self):
		vals = {}
		contactid = ""
		siteid = ""
		respartner = self.env['res.partner'].search([('id','=',self._origin.id)])
		for partner in respartner:
			for site in partner.company_site_lines:
				if site.company_corporate:
					site.email = self.email.upper()
					site.write({"email":self.email.upper()})
			for contact in partner.contact_ids:
				if contact.flag_first_contact:
					contactid = contact.id
					contact.email = self.email.upper()
					contact.site_email = self.email.upper()
					contact.write({'email':self.email.upper(),'site_email':self.email.upper()})
					self.write({'contact_ids':[(1,contact.id,{'email':self.email.upper(),'site_email':self.email.upper()})]})
			partner.email = self.email.upper()
			partner.write({'email':self.email.upper()})
			vals['email'] = partner.email
			vals['active_tabs'] = partner.active_tabs
			ressite = self.env['company.site'].search([('company_site_id','=',partner.id)])
			vals['contact_ids'] = self._origin.contact_ids
                        #Printing vals['contact_ids'] gives the proper one2many field with the correct id: partner.contact(475,)                         #But the output in chrome is: # {"jsonrpc": "2.0", # "id": 427040437, # "result": { # "value": { # "contact_ids": [ # [5] # ], # .
#                .
#                .
#                .     return {'value':vals} # Is there something wrong with the way I am returning Values?

0
Avatar
Discard
sukesh
Author

@Prakash, (Didn't have enough karma to comment.) Yes, that can be done, but that is not what I was looking for. I was looking to return the vals.

Avatar
sukesh
Author Best Answer

The reason this wasn't happening was that I was trying to save inside an onchange. The onchange function, even if you write into the object, doesn't actually completely write into the database. The issue is related to a concept called dirty fields. When you have a dirty field (i.e any field that is affected by the onchange function) before saving, Odoo doesn't support updating x2Many fields. This is why the fields weren't being passed on to the UI. 
A workaround I had for this is by making a javascript file, including the formview object and modifying the way saving works in Odoo. 
This essentially saves and performs a .reload() function which loads all the values. This modified save and .reload() function is placed inside the success function of the (Javascript) Formview onchange method. This solves my purpose, but may not solve everyone's. This issue is still in the wishlist in the official odoo repository. So it may be supported in future versions. But as of now, in odoo 8,9,10 and 11. The updating of x2Many fields in odoo through an onchange function is not supported. The comments (in odoo10) are in the odoo/models.py file on line 5511-5519. Hope this helps someone. 

0
Avatar
Discard
Avatar
Prakash Prajapati (ppr)
Best Answer

Hello Aditya , onchange method/ function are return the domain then reflection in UI.

Like: 

    @api.onchange('product_id')

    def _onchange_product_id(self):

        domain = {}

            domain['uom_id'] = "Domain....."

        return {'domain': domain}

0
Avatar
Discard
Enjoying the discussion? Don't just read, join in!

Create an account today to enjoy exclusive features and engage with our awesome community!

Sign up
Related Posts Replies Views Activity
Add month to date field Solved
date orm onchange
Avatar
Avatar
2
Jun 22
18539
Update one2many record within the same view
orm onchange V13
Avatar
Avatar
1
Jan 22
4081
onchange method doesn't work for new records Solved
orm onchange odoo12
Avatar
Avatar
2
Jan 19
7476
Odoo ORM Create Method Doesn't Save created Records in Treeview?
orm onchange odoo-10-Enteprise
Avatar
0
Aug 17
5521
How to trigger function on object write? Solved
addon v7 orm onchange
Avatar
Avatar
Avatar
Avatar
4
Jun 20
28036
Community
  • Tutorials
  • Documentation
  • Forum
Open Source
  • Download
  • Github
  • Runbot
  • Translations
Services
  • Odoo.sh Hosting
  • Support
  • Upgrade
  • Custom Developments
  • Education
  • Find an Accountant
  • Find a Partner
  • Become a Partner
About us
  • Our company
  • Brand Assets
  • Contact us
  • Jobs
  • Events
  • Podcast
  • Blog
  • Customers
  • Legal • Privacy
  • Security
الْعَرَبيّة Català 简体中文 繁體中文 (台灣) Čeština Dansk Nederlands English Suomi Français Deutsch हिंदी Bahasa Indonesia Italiano 日本語 한국어 (KR) Lietuvių kalba Język polski Português (BR) română русский язык Slovenský jazyk slovenščina Español (América Latina) Español ภาษาไทย Türkçe українська Tiếng Việt

Odoo is a suite of open source business apps that cover all your company needs: CRM, eCommerce, accounting, inventory, point of sale, project management, etc.

Odoo's unique value proposition is to be at the same time very easy to use and fully integrated.

Website made with

Odoo Experience on YouTube

1. Use the live chat to ask your questions.
2. The operator answers within a few minutes.

Live support on Youtube
Watch now