Skip to Content
Odoo Menu
  • Sign in
  • Try it free
  • Apps
    Finance
    • Accounting
    • Invoicing
    • Expenses
    • Spreadsheet (BI)
    • Documents
    • Sign
    Sales
    • CRM
    • Sales
    • POS Shop
    • POS Restaurant
    • Subscriptions
    • Rental
    Websites
    • Website Builder
    • eCommerce
    • Blog
    • Forum
    • Live Chat
    • eLearning
    Supply Chain
    • Inventory
    • Manufacturing
    • PLM
    • Purchase
    • Maintenance
    • Quality
    Human Resources
    • Employees
    • Recruitment
    • Time Off
    • Appraisals
    • Referrals
    • Fleet
    Marketing
    • Social Marketing
    • Email Marketing
    • SMS Marketing
    • Events
    • Marketing Automation
    • Surveys
    Services
    • Project
    • Timesheets
    • Field Service
    • Helpdesk
    • Planning
    • Appointments
    Productivity
    • Discuss
    • Artificial Intelligence
    • IoT
    • VoIP
    • Knowledge
    • WhatsApp
    Third party apps Odoo Studio Odoo Cloud Platform
  • Industries
    Retail
    • Book Store
    • Clothing Store
    • Furniture Store
    • Grocery Store
    • Hardware Store
    • Toy Store
    Food & Hospitality
    • Bar and Pub
    • Restaurant
    • Fast Food
    • Guest House
    • Beverage Distributor
    • Hotel
    Real Estate
    • Real Estate Agency
    • Architecture Firm
    • Construction
    • Property Management
    • Gardening
    • Property Owner Association
    Consulting
    • Accounting Firm
    • Odoo Partner
    • Marketing Agency
    • Law firm
    • Talent Acquisition
    • Audit & Certification
    Manufacturing
    • Textile
    • Metal
    • Furnitures
    • Food
    • Brewery
    • Corporate Gifts
    Health & Fitness
    • Sports Club
    • Eyewear Store
    • Fitness Center
    • Wellness Practitioners
    • Pharmacy
    • Hair Salon
    Trades
    • Handyman
    • IT Hardware & Support
    • Solar Energy Systems
    • Shoe Maker
    • Cleaning Services
    • HVAC Services
    Others
    • Nonprofit Organization
    • Environmental Agency
    • Billboard Rental
    • Photography
    • Bike Leasing
    • Software Reseller
    Browse all Industries
  • Community
    Learn
    • Tutorials
    • Documentation
    • Certifications
    • Training
    • Blog
    • Podcast
    Empower Education
    • Education Program
    • Scale Up! Business Game
    • Visit Odoo
    Get the Software
    • Download
    • Compare Editions
    • Releases
    Collaborate
    • Github
    • Forum
    • Events
    • Translations
    • Become a Partner
    • Services for Partners
    • Register your Accounting Firm
    Get Services
    • Find a Partner
    • Find an Accountant
    • Meet an advisor
    • Implementation Services
    • Customer References
    • Support
    • Upgrades
    Github Youtube Twitter Linkedin Instagram Facebook Spotify
    +1 (650) 691-3277
    Get a demo
  • Pricing
  • Help
You need to be registered to interact with the community.
All Posts People Badges
Tags (View all)
odoo accounting v14 pos v15
About this forum
You need to be registered to interact with the community.
All Posts People Badges
Tags (View all)
odoo accounting v14 pos v15
About this forum
Help

Should constraint methods be redefinable?

Subscribe

Get notified when there's activity on this post

This question has been flagged
inheritanceconstraintredefine
1 Reply
7507 Views
Avatar
Pablo

In order to add an option to allow the importation of VAT numbers without validating them I'm trying to redefine the method check_vat. It is added to res_partner in the module base_vat (base_vat.py:114). This method is used to implement the constraint logic defined for the constraint on base_vat.py:150

_constraints = [(check_vat, _construct_constraint_msg, ["vat"])]

To redefine this method I inherit res_partner as shown below:

class ags_res_partner(osv.osv):
    _inherit = 'res.partner'

def check_vat(self, cr, uid, ids, context=None):
    res = super(ags_res_partner, self).check_vat(cr, uid, ids, context=context)
    #if parametro_comprobar_CIFS return res
    print "redefined check_vat"
    return True        

def simple_vat_check(self, cr, uid, country_code, vat_number, context=None):
    print "redefined simple_vat_check"
    return True

ags_res_partner()

The result is that the redefined version of simple_vat_check (a method called from inside check_vat) gets invoked but not check_vat. Debugging this code I find that the inheritance is working. In fact, I can see my class in self.__class__.__mro__ when inside the check_vat implementation of base_vat. The problem comes from the way that the constraint methods get called (orm.py:1527), skipping the OpenERP managed inheritance system. Once inside check_vat, simple_vat_check gets invoked properly taking into account that inheritance system.

Since check_vat is defined as a public method, I understand it should be redefinable. Am I wrong? Did I commit any mistake or the fact that the inheritance gets skipped is just a bug?

Thanks in advance

1
Avatar
Discard
Avatar
Jeudy Nicolas
Best Answer

hello,

Unfortunatly I think you have to redefine all _constraints. Your code should look like this:

class ags_res_partner(osv.osv):
    _inherit = 'res.partner'

    def check_vat(self, cr, uid, ids, context=None):
        res = super(ags_res_partner, self).check_vat(cr, uid, ids, context=context)
        #if parametro_comprobar_CIFS return res
        print "redefined check_vat"
    return True

    def simple_vat_check(self, cr, uid, country_code, vat_number, context=None):
        print "redefined simple_vat_check"
        return True

    _constraints = [(check_vat, _construct_constraint_msg, ["vat"])]

Your module should depend on base module in you case and load after base (you can add an higher sequence number in __openerp__.py , but not in your case,base module is loaded before all other mods.

1
Avatar
Discard
Enjoying the discussion? Don't just read, join in!

Create an account today to enjoy exclusive features and engage with our awesome community!

Sign up
Related Posts Replies Views Activity
Can't re-define field when doing inherits Solved
inheritance redefine
Avatar
Avatar
6
Sep 25
6368
Can't inherit base.view_partner_form of res.partner
inheritance
Avatar
Avatar
Avatar
Avatar
Avatar
4
Feb 25
5639
Include in inherit from JS class
inheritance
Avatar
Avatar
1
Aug 24
3835
How to Override a method in parent class in JS Solved
inheritance
Avatar
Avatar
2
Nov 24
5473
How to add a simple field to partner?
inheritance
Avatar
Avatar
Avatar
Avatar
3
Oct 23
16687
Community
  • Tutorials
  • Documentation
  • Forum
Open Source
  • Download
  • Github
  • Runbot
  • Translations
Services
  • Odoo.sh Hosting
  • Support
  • Upgrade
  • Custom Developments
  • Education
  • Find an Accountant
  • Find a Partner
  • Become a Partner
About us
  • Our company
  • Brand Assets
  • Contact us
  • Jobs
  • Events
  • Podcast
  • Blog
  • Customers
  • Legal • Privacy
  • Security
الْعَرَبيّة Català 简体中文 繁體中文 (台灣) Čeština Dansk Nederlands English Suomi Français Deutsch हिंदी Bahasa Indonesia Italiano 日本語 한국어 (KR) Lietuvių kalba Język polski Português (BR) română русский язык Slovenský jazyk Slovenščina Español (América Latina) Español Svenska ภาษาไทย Türkçe українська Tiếng Việt

Odoo is a suite of open source business apps that cover all your company needs: CRM, eCommerce, accounting, inventory, point of sale, project management, etc.

Odoo's unique value proposition is to be at the same time very easy to use and fully integrated.

Website made with

Odoo Experience on YouTube

1. Use the live chat to ask your questions.
2. The operator answers within a few minutes.

Live support on Youtube
Watch now