Skip to Content
Odoo Menu
  • Sign in
  • Try it free
  • Apps
    Finance
    • Accounting
    • Invoicing
    • Expenses
    • Spreadsheet (BI)
    • Documents
    • Sign
    Sales
    • CRM
    • Sales
    • POS Shop
    • POS Restaurant
    • Subscriptions
    • Rental
    Websites
    • Website Builder
    • eCommerce
    • Blog
    • Forum
    • Live Chat
    • eLearning
    Supply Chain
    • Inventory
    • Manufacturing
    • PLM
    • Purchase
    • Maintenance
    • Quality
    Human Resources
    • Employees
    • Recruitment
    • Time Off
    • Appraisals
    • Referrals
    • Fleet
    Marketing
    • Social Marketing
    • Email Marketing
    • SMS Marketing
    • Events
    • Marketing Automation
    • Surveys
    Services
    • Project
    • Timesheets
    • Field Service
    • Helpdesk
    • Planning
    • Appointments
    Productivity
    • Discuss
    • Approvals
    • IoT
    • VoIP
    • Knowledge
    • WhatsApp
    Third party apps Odoo Studio Odoo Cloud Platform
  • Industries
    Retail
    • Book Store
    • Clothing Store
    • Furniture Store
    • Grocery Store
    • Hardware Store
    • Toy Store
    Food & Hospitality
    • Bar and Pub
    • Restaurant
    • Fast Food
    • Guest House
    • Beverage Distributor
    • Hotel
    Real Estate
    • Real Estate Agency
    • Architecture Firm
    • Construction
    • Estate Management
    • Gardening
    • Property Owner Association
    Consulting
    • Accounting Firm
    • Odoo Partner
    • Marketing Agency
    • Law firm
    • Talent Acquisition
    • Audit & Certification
    Manufacturing
    • Textile
    • Metal
    • Furnitures
    • Food
    • Brewery
    • Corporate Gifts
    Health & Fitness
    • Sports Club
    • Eyewear Store
    • Fitness Center
    • Wellness Practitioners
    • Pharmacy
    • Hair Salon
    Trades
    • Handyman
    • IT Hardware & Support
    • Solar Energy Systems
    • Shoe Maker
    • Cleaning Services
    • HVAC Services
    Others
    • Nonprofit Organization
    • Environmental Agency
    • Billboard Rental
    • Photography
    • Bike Leasing
    • Software Reseller
    Browse all Industries
  • Community
    Learn
    • Tutorials
    • Documentation
    • Certifications
    • Training
    • Blog
    • Podcast
    Empower Education
    • Education Program
    • Scale Up! Business Game
    • Visit Odoo
    Get the Software
    • Download
    • Compare Editions
    • Releases
    Collaborate
    • Github
    • Forum
    • Events
    • Translations
    • Become a Partner
    • Services for Partners
    • Register your Accounting Firm
    Get Services
    • Find a Partner
    • Find an Accountant
    • Meet an advisor
    • Implementation Services
    • Customer References
    • Support
    • Upgrades
    Github Youtube Twitter Linkedin Instagram Facebook Spotify
    +1 (650) 691-3277
    Get a demo
  • Pricing
  • Help

Odoo is the world's easiest all-in-one management software.
It includes hundreds of business apps:

  • CRM
  • e-Commerce
  • Accounting
  • Inventory
  • PoS
  • Project
  • MRP
All apps
You need to be registered to interact with the community.
All Posts People Badges
Tags (View all)
odoo accounting v14 pos v15
About this forum
You need to be registered to interact with the community.
All Posts People Badges
Tags (View all)
odoo accounting v14 pos v15
About this forum
Help

Patch JS function that doesn't belong to a class

Subscribe

Get notified when there's activity on this post

This question has been flagged
javascriptjspatch
1 Reply
6203 Views
Avatar
Devin

Hi All,

I'm a complete JS n00b and I'm really struggling to figure this out. I'm trying to change the default colors used in graphs. There's a 'getColors' functions in web/views/graph/colors.js that simply returns an array of colors that are used for this and it seems best to me to just override this function with my own array of colors but I can't for the life of me figure out how to patch it because this function does not belong to a class. 

The original code (that I want to patch) looks like this (notice that none of this is inside a class):

/** @odoo-module **/
const COLORS_BRIGHT = [
"#1f77b4",
// rest removed for brevity
];

const COLORS_DARK = [
"#00ffff",
// rest removed for brevity
];

// this is the function I want to replace with my own
export function getColors(colorScheme) {
return colorScheme === "dark" ? COLORS_DARK : COLORS_BRIGHT;
}

// a few more functions that I don't care about

I've created my own colors.js like this

/** @odoo-module **/    
import { patch } from '@web/core/utils/patch';
import { getColors } from '@web/views/graph/colors';

const MY_COLORS_BRIGHT = [
"#1f77b4",
// rest removed for brevity
];

const MY_COLORS_DARK = [
"#00ffff",
// rest removed for brevity
];

patch(getColors, 'my_module.colors', {
getColors(colorScheme) {
return colorScheme === "dark" ? MY_COLORS_DARK : MY_COLORS_BRIGHT;
}
}

Obviously this doesn't work - it basically adds a new getColors function inside the old getColors function instead of replacing it. Normally I think I would patch the Class with getColors function and that would work. How can I go about replacing this function without it having a parent to patch? 

0
Avatar
Discard
Avatar
Devin
Author Best Answer

I've solved my own problem. The key here is importing the entire colors.js file with 'import * as colors' and then patching 'colors' with the new function. I'm not sure why, but when doing it this way I was unable to patch the getColors function directly (the original one would still be called). But patching getColor (which is what all other modules actually call) and using my own getMyColors function it works.

/** @odoo-module **/
import { patch } from '@web/core/utils/patch';
import * as colors from '@web/views/graph/colors';

const MY_COLORS_BRIGHT = [
"#1f77b4",
// rest removed for brevity
];

const MY_COLORS_DARK = [
"#00ffff",
// rest removed for brevity
]; function getMyColors(colorScheme) { return colorScheme === "dark" ? MY_COLORS_DARK : MY_COLORS_BRIGHT; } patch(colors, 'my_module.colors', { getColor(index, colorScheme) { const colors = getMyColors(colorScheme); return colors[index % colors.length]; } });
2
Avatar
Discard
Andre de Kock

Thanks! This really helped

Enjoying the discussion? Don't just read, join in!

Create an account today to enjoy exclusive features and engage with our awesome community!

Sign up
Related Posts Replies Views Activity
how to read field values using js Solved
javascript js
Avatar
Avatar
1
May 25
9070
How to extend an object using the patch function?
javascript patch odoo17
Avatar
Avatar
Avatar
2
Jul 24
4627
Trouble Importing JavaScript Between Custom Odoo Modules
javascript inheritance js
Avatar
0
May 24
3318
Odoo 14: Reload Point Of Sale Solved
javascript js point_of_sale
Avatar
Avatar
1
Apr 24
2784
TypeError: Cannot read property 'type' of undefined
javascript python js
Avatar
0
Aug 21
9836
Community
  • Tutorials
  • Documentation
  • Forum
Open Source
  • Download
  • Github
  • Runbot
  • Translations
Services
  • Odoo.sh Hosting
  • Support
  • Upgrade
  • Custom Developments
  • Education
  • Find an Accountant
  • Find a Partner
  • Become a Partner
About us
  • Our company
  • Brand Assets
  • Contact us
  • Jobs
  • Events
  • Podcast
  • Blog
  • Customers
  • Legal • Privacy
  • Security
الْعَرَبيّة Català 简体中文 繁體中文 (台灣) Čeština Dansk Nederlands English Suomi Français Deutsch हिंदी Bahasa Indonesia Italiano 日本語 한국어 (KR) Lietuvių kalba Język polski Português (BR) română русский язык Slovenský jazyk slovenščina Español (América Latina) Español ภาษาไทย Türkçe українська Tiếng Việt

Odoo is a suite of open source business apps that cover all your company needs: CRM, eCommerce, accounting, inventory, point of sale, project management, etc.

Odoo's unique value proposition is to be at the same time very easy to use and fully integrated.

Website made with

Odoo Experience on YouTube

1. Use the live chat to ask your questions.
2. The operator answers within a few minutes.

Live support on Youtube
Watch now