Skip to Content
Odoo Menu
  • Sign in
  • Try it free
  • Apps
    Finance
    • Accounting
    • Invoicing
    • Expenses
    • Spreadsheet (BI)
    • Documents
    • Sign
    Sales
    • CRM
    • Sales
    • POS Shop
    • POS Restaurant
    • Subscriptions
    • Rental
    Websites
    • Website Builder
    • eCommerce
    • Blog
    • Forum
    • Live Chat
    • eLearning
    Supply Chain
    • Inventory
    • Manufacturing
    • PLM
    • Purchase
    • Maintenance
    • Quality
    Human Resources
    • Employees
    • Recruitment
    • Time Off
    • Appraisals
    • Referrals
    • Fleet
    Marketing
    • Social Marketing
    • Email Marketing
    • SMS Marketing
    • Events
    • Marketing Automation
    • Surveys
    Services
    • Project
    • Timesheets
    • Field Service
    • Helpdesk
    • Planning
    • Appointments
    Productivity
    • Discuss
    • Approvals
    • IoT
    • VoIP
    • Knowledge
    • WhatsApp
    Third party apps Odoo Studio Odoo Cloud Platform
  • Industries
    Retail
    • Book Store
    • Clothing Store
    • Furniture Store
    • Grocery Store
    • Hardware Store
    • Toy Store
    Food & Hospitality
    • Bar and Pub
    • Restaurant
    • Fast Food
    • Guest House
    • Beverage Distributor
    • Hotel
    Real Estate
    • Real Estate Agency
    • Architecture Firm
    • Construction
    • Estate Management
    • Gardening
    • Property Owner Association
    Consulting
    • Accounting Firm
    • Odoo Partner
    • Marketing Agency
    • Law firm
    • Talent Acquisition
    • Audit & Certification
    Manufacturing
    • Textile
    • Metal
    • Furnitures
    • Food
    • Brewery
    • Corporate Gifts
    Health & Fitness
    • Sports Club
    • Eyewear Store
    • Fitness Center
    • Wellness Practitioners
    • Pharmacy
    • Hair Salon
    Trades
    • Handyman
    • IT Hardware & Support
    • Solar Energy Systems
    • Shoe Maker
    • Cleaning Services
    • HVAC Services
    Others
    • Nonprofit Organization
    • Environmental Agency
    • Billboard Rental
    • Photography
    • Bike Leasing
    • Software Reseller
    Browse all Industries
  • Community
    Learn
    • Tutorials
    • Documentation
    • Certifications
    • Training
    • Blog
    • Podcast
    Empower Education
    • Education Program
    • Scale Up! Business Game
    • Visit Odoo
    Get the Software
    • Download
    • Compare Editions
    • Releases
    Collaborate
    • Github
    • Forum
    • Events
    • Translations
    • Become a Partner
    • Services for Partners
    • Register your Accounting Firm
    Get Services
    • Find a Partner
    • Find an Accountant
    • Meet an advisor
    • Implementation Services
    • Customer References
    • Support
    • Upgrades
    Github Youtube Twitter Linkedin Instagram Facebook Spotify
    +1 (650) 691-3277
    Get a demo
  • Pricing
  • Help

Odoo is the world's easiest all-in-one management software.
It includes hundreds of business apps:

  • CRM
  • e-Commerce
  • Accounting
  • Inventory
  • PoS
  • Project
  • MRP
All apps
You need to be registered to interact with the community.
All Posts People Badges
Tags (View all)
odoo accounting v14 pos v15
About this forum
You need to be registered to interact with the community.
All Posts People Badges
Tags (View all)
odoo accounting v14 pos v15
About this forum
Help

One2many Field Issue: Child Records Not Automatically Updating When Parent Field Changes

Subscribe

Get notified when there's activity on this post

This question has been flagged
one2manyv17
3 Replies
1919 Views
Avatar
Thach Nguyen

Hello,


I have an issue with one2many field, please review this example code:


Model:

class ParentModel(models.Model):

    _name = 'parent.model'

    parent_field = fields.Char(compute='_compute_parent_field')

​ children_ids = fields.One2many('child.model', 'parent_id', string='Children')


    @api.depends('children_ids.child_field')

    def _compute_parent_field(self):

        for record in self:

            # Custom logic to compute parent_field based on child_field

            record.parent_field = 'Computed Value' if record.children_ids else 'Default Value'


class ChildModel(models.Model):

    _name = 'child.model'

    parent_id = fields.Many2one('parent.model', string='Parent')

    related_parent_field = fields.Char(related='parent_id.parent_field')


    child_field = fields.Char()



View:

<?xml version="1.0" encoding="utf-8"?>
<odoo>
    <data>
        <record id="parent_model_form" model="ir.ui.view">
            <field name="name">parent_model_form</field>
            <field name="model">parent.model</field>
            <field name="arch" type="xml">
                <form>
                    <sheet>
                        <group>
                            <field name="parent_field"/>
                        </group>
                    <notebook>
                        <page string="Children">
                            <field name="children_ids">
                                <tree>
                                    <field name="child_field"/>
                                    <field name="related_parent_field"/>
                                </tree>
                            </field>
                        </page>
                    </notebook>
                    </sheet>
                </form>
            </field>
        </record>
    </data>
</odoo>


The child_field change value is properly computed, parent_field is updated and displayed in the parent.

The related_parent_field is also updated and displayed for the current child record.


The problem is the other child records are not updated.

When I edit other child records, I see the old value of related_parent_field.


I have to save the parent record to see the changes in other child records.


Hope you can help me with this issue.

Thanks in advance.





Here's a more concrete example that clearly demonstrates the issue:


```python

# Models

class ProductCategory(models.Model):

    _name = 'product.category'

    _description = 'Product Category'

   

    name = fields.Char(string='Category Name', required=True)

    total_products = fields.Integer(string='Total Products', compute='_compute_total_products')

    product_ids = fields.One2many('product.product', 'category_id', string='Products')

   

    @api.depends('product_ids.active')

    def _compute_total_products(self):

        for category in self:

            category.total_products = len(category.product_ids.filtered(lambda p: p.active))



class Product(models.Model):

    _name = 'product.product'

    _description = 'Product'

   

    name = fields.Char(string='Product Name', required=True)

    active = fields.Boolean(string='Active', default=True)

    category_id = fields.Many2one('product.category', string='Category')

    category_total = fields.Integer(related='category_id.total_products', string='Products in Category')

```


```xml

<!-- Product Category Form View -->

<record id="product_category_form_view" model="ir.ui.view">

    <field name="name">product.category.form</field>

    <field name="model">product.category</field>

    <field name="arch" type="xml">

        <form>

            <sheet>

                <group>

                    <field name="name"/>

                    <field name="total_products"/>

                </group>

                <notebook>

                    <page string="Products">

                        <field name="product_ids">

                            <tree>

                                <field name="name"/>

                                <field name="active"/>

                                <field name="category_total"/>

                            </tree>

                        </field>

                    </page>

                </notebook>

            </sheet>

        </form>

    </field>

</record>

```


## Steps to Reproduce the Issue:


1. Create a new Product Category "Electronics"

2. Add three products to this category: "Laptop", "Phone", "Tablet"

3. Notice that `total_products` shows 3 and all products show `category_total = 3`

4. Edit the first product "Laptop" and uncheck the "Active" box

5. Notice that:

   - The `total_products` on the category updates correctly to 2

   - The `category_total` on the "Laptop" product updates correctly to 2

   - But the `category_total` on "Phone" and "Tablet" still shows 3 (incorrect)

6. Only after saving the form, the `category_total` value on all products updates correctly


This example clearly shows how field changes in one record (deactivating a product) correctly trigger computed fields in the parent (category.total_products), but the related fields in sibling records don't refresh automatically without saving.



0
Avatar
Discard
Avatar
Thach Nguyen
Author Best Answer

I've added a clearer example to the original post to clarify the issue


I got it working now.


Thank you for your help.


Here are the changes that made it work:


Category model:

@api.depends('product_ids.active')

    def _compute_total_products(self):

        for category in self:

            category.total_products = len(category.product_ids.filtered(lambda p: p.active))

for product in category.product_ids:

​ ​ product.category_total = category.total_products  # Update each product's category_total field


Product Model:


category_total = fields.Integer(store=False, string='Products in Category')


View:


<field name="product_ids" context="{'default_category_total': total_products}">



0
Avatar
Discard
Avatar
Darshan Kanejiya
Best Answer

Hello Thach,

To ensure child records automatically update when the parent field changes, you can use the @api.depends decorator in the child model. This ensures that changes in the parent model trigger recomputations for the related child records.

Alternatively, you can manually trigger the recomputation using @api.onchange in the parent model, or update the child records using a method call within the parent model.

Both approaches are valid, but using @api.depends in the child model is a cleaner solution if the changes are based on specific computed fields.

0
Avatar
Discard
Thach Nguyen
Author

Hello Darshan, thanks for your replay.

Thach Nguyen
Author

I tried your advice, but I'm still getting the same result.
I've added a clearer example to the original post to clarify the issue. Could you look again?

Avatar
Econ Odoo
Best Answer

Since the parent_field is not stored anyway, maybe it's better to remove the @api.depends. It's calculated everytime it is retrieved whether or not the children are changed.
Another approach is to override the save of the child models to trigger the calcuation of the parent (if you store the calculated value).

0
Avatar
Discard
Thach Nguyen
Author

Thanks,
I tried your advices. It still required saving the parent for the changes to apply to all children.
I've added a clearer example to the OP. Could you look again?

Enjoying the discussion? Don't just read, join in!

Create an account today to enjoy exclusive features and engage with our awesome community!

Sign up
Related Posts Replies Views Activity
Equivalent Attributes in 17 for invisible
one2many v17
Avatar
Avatar
Avatar
2
Mar 24
6336
Ya es posible hacer Upgrade de v17 a v17.1 ?
v17
Avatar
Avatar
1
Oct 25
1512
How to add a new Many2one field in res.config.settings? Solved
v17
Avatar
Avatar
Avatar
Avatar
4
Oct 25
4136
Add field to ALL models in Odoo
v17
Avatar
Avatar
Avatar
2
Sep 25
2700
How to disable Email notification - You have been assigned to Solved
v17
Avatar
Avatar
Avatar
Avatar
4
Sep 25
8245
Community
  • Tutorials
  • Documentation
  • Forum
Open Source
  • Download
  • Github
  • Runbot
  • Translations
Services
  • Odoo.sh Hosting
  • Support
  • Upgrade
  • Custom Developments
  • Education
  • Find an Accountant
  • Find a Partner
  • Become a Partner
About us
  • Our company
  • Brand Assets
  • Contact us
  • Jobs
  • Events
  • Podcast
  • Blog
  • Customers
  • Legal • Privacy
  • Security
الْعَرَبيّة Català 简体中文 繁體中文 (台灣) Čeština Dansk Nederlands English Suomi Français Deutsch हिंदी Bahasa Indonesia Italiano 日本語 한국어 (KR) Lietuvių kalba Język polski Português (BR) română русский язык Slovenský jazyk slovenščina Español (América Latina) Español ภาษาไทย Türkçe українська Tiếng Việt

Odoo is a suite of open source business apps that cover all your company needs: CRM, eCommerce, accounting, inventory, point of sale, project management, etc.

Odoo's unique value proposition is to be at the same time very easy to use and fully integrated.

Website made with

Odoo Experience on YouTube

1. Use the live chat to ask your questions.
2. The operator answers within a few minutes.

Live support on Youtube
Watch now