Skip to Content
Odoo Menu
  • Sign in
  • Try it free
  • Apps
    Finance
    • Accounting
    • Invoicing
    • Expenses
    • Spreadsheet (BI)
    • Documents
    • Sign
    Sales
    • CRM
    • Sales
    • POS Shop
    • POS Restaurant
    • Subscriptions
    • Rental
    Websites
    • Website Builder
    • eCommerce
    • Blog
    • Forum
    • Live Chat
    • eLearning
    Supply Chain
    • Inventory
    • Manufacturing
    • PLM
    • Purchase
    • Maintenance
    • Quality
    Human Resources
    • Employees
    • Recruitment
    • Time Off
    • Appraisals
    • Referrals
    • Fleet
    Marketing
    • Social Marketing
    • Email Marketing
    • SMS Marketing
    • Events
    • Marketing Automation
    • Surveys
    Services
    • Project
    • Timesheets
    • Field Service
    • Helpdesk
    • Planning
    • Appointments
    Productivity
    • Discuss
    • Approvals
    • IoT
    • VoIP
    • Knowledge
    • WhatsApp
    Third party apps Odoo Studio Odoo Cloud Platform
  • Industries
    Retail
    • Book Store
    • Clothing Store
    • Furniture Store
    • Grocery Store
    • Hardware Store
    • Toy Store
    Food & Hospitality
    • Bar and Pub
    • Restaurant
    • Fast Food
    • Guest House
    • Beverage Distributor
    • Hotel
    Real Estate
    • Real Estate Agency
    • Architecture Firm
    • Construction
    • Estate Management
    • Gardening
    • Property Owner Association
    Consulting
    • Accounting Firm
    • Odoo Partner
    • Marketing Agency
    • Law firm
    • Talent Acquisition
    • Audit & Certification
    Manufacturing
    • Textile
    • Metal
    • Furnitures
    • Food
    • Brewery
    • Corporate Gifts
    Health & Fitness
    • Sports Club
    • Eyewear Store
    • Fitness Center
    • Wellness Practitioners
    • Pharmacy
    • Hair Salon
    Trades
    • Handyman
    • IT Hardware & Support
    • Solar Energy Systems
    • Shoe Maker
    • Cleaning Services
    • HVAC Services
    Others
    • Nonprofit Organization
    • Environmental Agency
    • Billboard Rental
    • Photography
    • Bike Leasing
    • Software Reseller
    Browse all Industries
  • Community
    Learn
    • Tutorials
    • Documentation
    • Certifications
    • Training
    • Blog
    • Podcast
    Empower Education
    • Education Program
    • Scale Up! Business Game
    • Visit Odoo
    Get the Software
    • Download
    • Compare Editions
    • Releases
    Collaborate
    • Github
    • Forum
    • Events
    • Translations
    • Become a Partner
    • Services for Partners
    • Register your Accounting Firm
    Get Services
    • Find a Partner
    • Find an Accountant
    • Meet an advisor
    • Implementation Services
    • Customer References
    • Support
    • Upgrades
    Github Youtube Twitter Linkedin Instagram Facebook Spotify
    +1 (650) 691-3277
    Get a demo
  • Pricing
  • Help

Odoo is the world's easiest all-in-one management software.
It includes hundreds of business apps:

  • CRM
  • e-Commerce
  • Accounting
  • Inventory
  • PoS
  • Project
  • MRP
All apps
You need to be registered to interact with the community.
All Posts People Badges
Tags (View all)
odoo accounting v14 pos v15
About this forum
You need to be registered to interact with the community.
All Posts People Badges
Tags (View all)
odoo accounting v14 pos v15
About this forum
Help

in odoo 17 i want to inherit pos_discount apply_discount function, i tried more an more

Subscribe

Get notified when there's activity on this post

This question has been flagged
javascriptinheritjsodooowl
1 Reply
4095 Views
Avatar
Ragab Deaf

this is the original code :

/** @odoo-module **/

import { _t } from "@web/core/l10n/translation";
import { ProductScreen } from "@point_of_sale/app/screens/product_screen/product_screen";
import { useService } from "@web/core/utils/hooks";
import { NumberPopup } from "@point_of_sale/app/utils/input_popups/number_popup";
import { ErrorPopup } from "@point_of_sale/app/errors/popups/error_popup";
import { Component } from "@odoo/owl";
import { usePos } from "@point_of_sale/app/store/pos_hook";

export class DiscountButton extends Component {
static template = "pos_discount.DiscountButton";

setup() {
this.pos = usePos();
this.popup = useService("popup");
}
async click() {
var self = this;
const { confirmed, payload } = await this.popup.add(NumberPopup, {
title: _t("Discount Percentage"),
startingValue: this.pos.config.discount_pc,
isInputSelected: true,
});
if (confirmed) {
const val = Math.max(0, Math.min(100, parseFloat(payload)));
await self.apply_discount(val);
}
}

async apply_discount(pc) {
// here i want to add som validation
}
}

ProductScreen.addControlButton({
component: DiscountButton,
condition: function () {
const { module_pos_discount, discount_product_id } = this.pos.config;
return module_pos_discount && discount_product_id;
},
});



and this is my code 

/** @odoo-module **/

const _t = require("@web/core/l10n/translation")._t;
const ProductScreen = require("@point_of_sale/app/screens/product_screen/product_screen").ProductScreen;
const NumberPopup = require("@point_of_sale/app/utils/input_popups/number_popup").NumberPopup;
const ErrorPopup = require("@point_of_sale/app/errors/popups/error_popup").ErrorPopup;
const Component = require("@odoo/owl").Component;
const usePos = require("@point_of_sale/app/store/pos_hook").usePos;
const DiscountButton = require("@pos_discount/overrides/components/discount_button/discount_button").DiscountButton;

export class CustomDiscountButton extends DiscountButton {
async apply_discount(pc) {

console.log('some validation');

await super.apply_discount(pc);


}

async click() {
var self = this;
const { confirmed, payload } = await this.popup.add(NumberPopup, {
title: _t("Discount Percentage"),
startingValue: this.pos.config.discount_pc,
isInputSelected: true,
});
if (confirmed) {
const val = Math.max(0, Math.min(100, parseFloat(payload)));
await self.apply_discount(val);
}
}
}

ProductScreen.addControlButton({
component: CustomDiscountButton,
condition: function () {
const { module_pos_discount, discount_product_id } = this.pos.config;
return module_pos_discount && discount_product_id;
},
});

 

0
Avatar
Discard
Ragab Deaf
Author

/** @odoo-module */

import { DiscountButton } from "@pos_discount/overrides/components/discount_button/discount_button";
import { ErrorPopup } from "@point_of_sale/app/errors/popups/error_popup";
import { patch } from "@web/core/utils/patch";
import { _t } from "@web/core/l10n/translation";

patch(DiscountButton.prototype, {

async apply_discount(pc) {
console.log("test")
await super.apply_discount(arguments);
},
});

should this code work ?

Avatar
Cybrosys Techno Solutions Pvt.Ltd
Best Answer

Hi,

Try this:

/** @odoo-module **/


import { DiscountButton } from "@pos_discount/overrides/components/discount_button/discount_button";

import { patch } from "@web/core/utils/patch";


patch(DiscountButton.prototype, {

    setup() {

        super.setup(...arguments);

    },

       async apply_discount(pc) {

                       await super.apply_discount(pc);

       }

});


Hope it helps

1
Avatar
Discard
Syed Hamza

That works. But I was trying to import it like this and it was throwing errors "unmet dependencies". Why it is not working like this?
```
/** @odoo-module **/

import { registry } from "@web/core/registry";
import { DiscountButton } from "pos_discount/overrides/components/discount_button/discount_button"; // Correct path

// Create a new class that extends the original DiscountButton
export class CustomDiscountButton extends OriginalDiscountButton {
// Override the click method
async click() {
console.log("Custom click function invoked!");

const { confirmed, payload } = await this.popup.add(NumberPopup, {
title: _t("Discount Amount"),
startingValue: 0,
isInputSelected: true,
});
if (confirmed) {
const val = Math.max(0, parseFloat(payload));
await this.apply_discount(val);
}
}
}

// Register your custom button to replace the original one
registry.category("control_buttons").add("DiscountButton", CustomDiscountButton);

```

Enjoying the discussion? Don't just read, join in!

Create an account today to enjoy exclusive features and engage with our awesome community!

Sign up
Related Posts Replies Views Activity
OWL : TypeError: this is undefined - ODOO 16 CE Solved
javascript odoo owl
Avatar
Avatar
1
Sep 23
6046
Javascript "arguments" Where are they being generated? where do they come from?
javascript js odoo
Avatar
0
Jul 17
3674
How to extend or inherit a javascript object (instance.web.DateTimeWidget) from a custom module.
javascript js odoo
Avatar
0
Mar 15
7566
odoo 17 js pos_discount extend apply_discount function
javascript js odoo v17
Avatar
Avatar
1
Aug 25
2967
Odoo 16 - The following error occurred in onWillStart: "Cannot read properties of undefined (reading 'display_name')"
javascript js owl odoo16
Avatar
0
Apr 25
2319
Community
  • Tutorials
  • Documentation
  • Forum
Open Source
  • Download
  • Github
  • Runbot
  • Translations
Services
  • Odoo.sh Hosting
  • Support
  • Upgrade
  • Custom Developments
  • Education
  • Find an Accountant
  • Find a Partner
  • Become a Partner
About us
  • Our company
  • Brand Assets
  • Contact us
  • Jobs
  • Events
  • Podcast
  • Blog
  • Customers
  • Legal • Privacy
  • Security
الْعَرَبيّة Català 简体中文 繁體中文 (台灣) Čeština Dansk Nederlands English Suomi Français Deutsch हिंदी Bahasa Indonesia Italiano 日本語 한국어 (KR) Lietuvių kalba Język polski Português (BR) română русский язык Slovenský jazyk slovenščina Español (América Latina) Español ภาษาไทย Türkçe українська Tiếng Việt

Odoo is a suite of open source business apps that cover all your company needs: CRM, eCommerce, accounting, inventory, point of sale, project management, etc.

Odoo's unique value proposition is to be at the same time very easy to use and fully integrated.

Website made with

Odoo Experience on YouTube

1. Use the live chat to ask your questions.
2. The operator answers within a few minutes.

Live support on Youtube
Watch now