Skip to Content
This question has been flagged
pythonxmlodoo
2 Replies
6168 Views
Avatar
Cristina.J

Hi,

In model "mail.message" , I want to set the value 'Employee Only' by default True , if the Type is a comment.

So , I inherited the method create from "mail.message" I added the condition in the function , but I still having errors , what's wrong? Any help please?

class MessageExtend(models.Model):
    _inherit = "mail.message"
     
    def create(self, values_list):
        tracking_values_list = []
        for values in values_list:

               if 'message_type' in ['comment']:
                self.is_internal = True

            if 'email_from' not in values:  # needed to compute reply_to
                author_id, email_from = self.env['mail.thread']._message_compute_author(values.get('author_id'),
                                                                                        email_from=None,
                                                                                        raise_exception=False)
                values['email_from'] = email_from


   .....

Thanks.

Avatar
Discard
Avatar
Jack Dane
Best Answer

Hello Christina, 

I would suggest using this code, I have tested and works well for me:

class MailClass(models.Model):
    _inherit = "mail.message"
    @api.model_create_multi
    def create(self, vals):
        records = super(MailClass, self).create(vals)
        for record in records:
            # if the message type of the mail.message is a comment, mark as internal
            if record.message_type == "comment":
                record.is_internal = True
        return records
              When overriding a function it is best practice to call the base function using super instead of copy and pasting the code, this will help when migrating Odoo versions. Meaning if the base function changes it should be an issue as you are still supplying code with the correct parameters it needs. 

              I hope this solves your issue,

              Thanks, 
              Avatar
              Discard
              Avatar
              Niyas Raphy (Walnut IT)
              Best Answer

              Hi,

              Update the function like this and see:

                if 'message_type' in ['comment']:
                              values_list['is_internal'] = True


              Thanks

              Avatar
              Discard
              Jack Dane

              Hello Niyas,

              Would it be:

              if 'message_type' in values_list['comment'] ? This is a good idea to change before supplying into the function.

              Thanks,

              Jack Dane

              Sorry more like

              "if values_list['message_type'] == "comment"'

              Related Posts Replies Views Activity
              How to get duplicated contact . Odoo 16
              python xml odoo
              Avatar
              		0
              Sep 23
              		41
              How to get record's id on "on-change of wizard's field"? Solved
              python xml odoo
              Avatar
              Avatar
              Avatar
              Avatar
              Avatar
              		4
              Mar 23
              		15287
              Change PDF file name in odoo v12
              python xml odoo
              Avatar
              Avatar
              Avatar
              		2
              Jul 22
              		2450
              How to replace the zero value of field in xlsx report. Odoo 14.
              python xml odoo
              Avatar
              		0
              May 22
              		1135
              Record does not exist or has been deleted. Odoo 14 Solved
              python xml odoo
              Avatar
              Avatar
              		1
              Nov 21
              		17203