Skip to Content
Odoo Menu
  • Sign in
  • Try it free
  • Apps
    Finance
    • Accounting
    • Invoicing
    • Expenses
    • Spreadsheet (BI)
    • Documents
    • Sign
    Sales
    • CRM
    • Sales
    • POS Shop
    • POS Restaurant
    • Subscriptions
    • Rental
    Websites
    • Website Builder
    • eCommerce
    • Blog
    • Forum
    • Live Chat
    • eLearning
    Supply Chain
    • Inventory
    • Manufacturing
    • PLM
    • Purchase
    • Maintenance
    • Quality
    Human Resources
    • Employees
    • Recruitment
    • Time Off
    • Appraisals
    • Referrals
    • Fleet
    Marketing
    • Social Marketing
    • Email Marketing
    • SMS Marketing
    • Events
    • Marketing Automation
    • Surveys
    Services
    • Project
    • Timesheets
    • Field Service
    • Helpdesk
    • Planning
    • Appointments
    Productivity
    • Discuss
    • Approvals
    • IoT
    • VoIP
    • Knowledge
    • WhatsApp
    Third party apps Odoo Studio Odoo Cloud Platform
  • Industries
    Retail
    • Book Store
    • Clothing Store
    • Furniture Store
    • Grocery Store
    • Hardware Store
    • Toy Store
    Food & Hospitality
    • Bar and Pub
    • Restaurant
    • Fast Food
    • Guest House
    • Beverage Distributor
    • Hotel
    Real Estate
    • Real Estate Agency
    • Architecture Firm
    • Construction
    • Estate Management
    • Gardening
    • Property Owner Association
    Consulting
    • Accounting Firm
    • Odoo Partner
    • Marketing Agency
    • Law firm
    • Talent Acquisition
    • Audit & Certification
    Manufacturing
    • Textile
    • Metal
    • Furnitures
    • Food
    • Brewery
    • Corporate Gifts
    Health & Fitness
    • Sports Club
    • Eyewear Store
    • Fitness Center
    • Wellness Practitioners
    • Pharmacy
    • Hair Salon
    Trades
    • Handyman
    • IT Hardware & Support
    • Solar Energy Systems
    • Shoe Maker
    • Cleaning Services
    • HVAC Services
    Others
    • Nonprofit Organization
    • Environmental Agency
    • Billboard Rental
    • Photography
    • Bike Leasing
    • Software Reseller
    Browse all Industries
  • Community
    Learn
    • Tutorials
    • Documentation
    • Certifications
    • Training
    • Blog
    • Podcast
    Empower Education
    • Education Program
    • Scale Up! Business Game
    • Visit Odoo
    Get the Software
    • Download
    • Compare Editions
    • Releases
    Collaborate
    • Github
    • Forum
    • Events
    • Translations
    • Become a Partner
    • Services for Partners
    • Register your Accounting Firm
    Get Services
    • Find a Partner
    • Find an Accountant
    • Meet an advisor
    • Implementation Services
    • Customer References
    • Support
    • Upgrades
    Github Youtube Twitter Linkedin Instagram Facebook Spotify
    +1 (650) 691-3277
    Get a demo
  • Pricing
  • Help

Odoo is the world's easiest all-in-one management software.
It includes hundreds of business apps:

  • CRM
  • e-Commerce
  • Accounting
  • Inventory
  • PoS
  • Project
  • MRP
All apps
You need to be registered to interact with the community.
All Posts People Badges
Tags (View all)
odoo accounting v14 pos v15
About this forum
You need to be registered to interact with the community.
All Posts People Badges
Tags (View all)
odoo accounting v14 pos v15
About this forum
Help

Help review canceling purchase code

Subscribe

Get notified when there's activity on this post

This question has been flagged
codereview
2 Replies
5664 Views
Avatar
Ben Bernard

https://github.com/odoo/odoo/blob/b55cd571f522ae4ebf94ae4ac4924e6de50c13a0/addons/purchase/purchase.py#L684

  • should it be move.state, instead of pick.state?
  • and what about the case when user return some/all products?
0
Avatar
Discard
Avatar
Ludo - 21South
Best Answer

Typically, from the functional point of view, you can receive either all, none or some of the goods you ordered. There is also the option for the supplier to provide half of the goods in one go and the other half on backorder. So ultimately it is pretty hard to determine what has or has not been delivered yet and how you should handle the PO afterwards.

If you want to cancel the PO and base the decision on wheter or not goods have been delivered, you will have to decide if you should be able to cancel if a part of the order has already been delivered. If this is the case, use the related order moves. If you want only the entire to cancel, you should base that decision on the picking. Remember, 1 picking order can still hold 1 or more move lines related to a purchase order.

 

Note: This reasoning will only work if standard Odoo functionality is used. If you somehow modified the PO process, this might no longer be valid.

0
Avatar
Discard
Ben Bernard
Author

My issue is that in default code (and configuration) there is no way to cancel PO if some stock picking (incoming shipment) already done. I think it should be still can be cancelled as long as the incoming shipment is returned and process the delivery order (until 'done'). I update the code with that logic, but I'm still not sure the effect functionally.

Ludo - 21South

Partially agree with you there. The thing is prob. what we mean by the term "cancel". In my opinion it means something like "never happened". In that case and your situation, the PO did happen, which is proven by the items sent to you. If you return the items, still the original PO has taken place and I would personally therefore never cancel it. Unfortunately I can't think of an suitable alternative solution to this problem.

Avatar
Ben Bernard
Author Best Answer

If anyone have the same issue, I update the code and you can check it from the following gist.

https://gist.github.com/bbn-bernard/87a0f46af030e3d459e1

That code will allow you to cancel PO if it already have some shipment 'done' and returned all the shipment ('done').

That code cover the following use cases:

  • PO already have some delivery 'done', but suddendly the supplier have no stock of the remaining product in PO lines
  • user mistakenly add wrong product in PO lines, but some delivery already 'done'

 

0
Avatar
Discard
Enjoying the discussion? Don't just read, join in!

Create an account today to enjoy exclusive features and engage with our awesome community!

Sign up
Related Posts Replies Views Activity
Help me with this code.
code review
Avatar
Avatar
Avatar
2
Jul 24
2199
.update() method not updating values
code
Avatar
0
Sep 23
2614
Why is the hr.attendance date column called "name"?
code
Avatar
0
Aug 16
4962
How to refresh the form view in coding in openerp 7?
code
Avatar
0
Mar 15
5429
line code.
code
Avatar
0
Jul 24
3437
Community
  • Tutorials
  • Documentation
  • Forum
Open Source
  • Download
  • Github
  • Runbot
  • Translations
Services
  • Odoo.sh Hosting
  • Support
  • Upgrade
  • Custom Developments
  • Education
  • Find an Accountant
  • Find a Partner
  • Become a Partner
About us
  • Our company
  • Brand Assets
  • Contact us
  • Jobs
  • Events
  • Podcast
  • Blog
  • Customers
  • Legal • Privacy
  • Security
الْعَرَبيّة Català 简体中文 繁體中文 (台灣) Čeština Dansk Nederlands English Suomi Français Deutsch हिंदी Bahasa Indonesia Italiano 日本語 한국어 (KR) Lietuvių kalba Język polski Português (BR) română русский язык Slovenský jazyk slovenščina Español (América Latina) Español ภาษาไทย Türkçe українська Tiếng Việt

Odoo is a suite of open source business apps that cover all your company needs: CRM, eCommerce, accounting, inventory, point of sale, project management, etc.

Odoo's unique value proposition is to be at the same time very easy to use and fully integrated.

Website made with

Odoo Experience on YouTube

1. Use the live chat to ask your questions.
2. The operator answers within a few minutes.

Live support on Youtube
Watch now