Skip to Content
Odoo Menu
  • Sign in
  • Try it free
  • Apps
    Finance
    • Accounting
    • Invoicing
    • Expenses
    • Spreadsheet (BI)
    • Documents
    • Sign
    Sales
    • CRM
    • Sales
    • POS Shop
    • POS Restaurant
    • Subscriptions
    • Rental
    Websites
    • Website Builder
    • eCommerce
    • Blog
    • Forum
    • Live Chat
    • eLearning
    Supply Chain
    • Inventory
    • Manufacturing
    • PLM
    • Purchase
    • Maintenance
    • Quality
    Human Resources
    • Employees
    • Recruitment
    • Time Off
    • Appraisals
    • Referrals
    • Fleet
    Marketing
    • Social Marketing
    • Email Marketing
    • SMS Marketing
    • Events
    • Marketing Automation
    • Surveys
    Services
    • Project
    • Timesheets
    • Field Service
    • Helpdesk
    • Planning
    • Appointments
    Productivity
    • Discuss
    • Approvals
    • IoT
    • VoIP
    • Knowledge
    • WhatsApp
    Third party apps Odoo Studio Odoo Cloud Platform
  • Industries
    Retail
    • Book Store
    • Clothing Store
    • Furniture Store
    • Grocery Store
    • Hardware Store
    • Toy Store
    Food & Hospitality
    • Bar and Pub
    • Restaurant
    • Fast Food
    • Guest House
    • Beverage Distributor
    • Hotel
    Real Estate
    • Real Estate Agency
    • Architecture Firm
    • Construction
    • Estate Management
    • Gardening
    • Property Owner Association
    Consulting
    • Accounting Firm
    • Odoo Partner
    • Marketing Agency
    • Law firm
    • Talent Acquisition
    • Audit & Certification
    Manufacturing
    • Textile
    • Metal
    • Furnitures
    • Food
    • Brewery
    • Corporate Gifts
    Health & Fitness
    • Sports Club
    • Eyewear Store
    • Fitness Center
    • Wellness Practitioners
    • Pharmacy
    • Hair Salon
    Trades
    • Handyman
    • IT Hardware & Support
    • Solar Energy Systems
    • Shoe Maker
    • Cleaning Services
    • HVAC Services
    Others
    • Nonprofit Organization
    • Environmental Agency
    • Billboard Rental
    • Photography
    • Bike Leasing
    • Software Reseller
    Browse all Industries
  • Community
    Learn
    • Tutorials
    • Documentation
    • Certifications
    • Training
    • Blog
    • Podcast
    Empower Education
    • Education Program
    • Scale Up! Business Game
    • Visit Odoo
    Get the Software
    • Download
    • Compare Editions
    • Releases
    Collaborate
    • Github
    • Forum
    • Events
    • Translations
    • Become a Partner
    • Services for Partners
    • Register your Accounting Firm
    Get Services
    • Find a Partner
    • Find an Accountant
    • Meet an advisor
    • Implementation Services
    • Customer References
    • Support
    • Upgrades
    Github Youtube Twitter Linkedin Instagram Facebook Spotify
    +1 (650) 691-3277
    Get a demo
  • Pricing
  • Help

Odoo is the world's easiest all-in-one management software.
It includes hundreds of business apps:

  • CRM
  • e-Commerce
  • Accounting
  • Inventory
  • PoS
  • Project
  • MRP
All apps
You need to be registered to interact with the community.
All Posts People Badges
Tags (View all)
odoo accounting v14 pos v15
About this forum
You need to be registered to interact with the community.
All Posts People Badges
Tags (View all)
odoo accounting v14 pos v15
About this forum
Help

Error with rpc call

Subscribe

Get notified when there's activity on this post

This question has been flagged
javascriptdevelopmentfunctiondebug
2 Replies
1850 Views
Avatar
Ramón Reyna García

I have this error with a rpc call to a controller, im editing the kiosk app but when i call the endpoint /manual_selection i have error: 


ODOO 18


TypeError: HrAttendanceExtended.manual_selection() missing 3 required positional arguments: 'token', 'employee_id', and 'pin_code'


This is my component:

import { rpc } from "@web/core/network/rpc";

setup() {

        this.rpc = rpc

        this.barcode = useService("barcode");

        this.notification = useService("notification");

    }

async onManualSelection(employeeId, enteredPin) {


        const result = await this.rpc("/hr_attendance/manual_selection", {

            token: this.props.token,

            employee_id: employeeId,

            pin_code: enteredPin

        });


        console.log(result)


        if (result?.attendance) {

            this.employeeData = result;

            this.switchDisplay('greet');

        } else if (enteredPin) {

            this.displayNotification(_t("Wrong Pin"));

        }

    }


This is my function in controller


@http.route('/hr_attendance/manual_selection', type="json", auth="public", csrf=False)

    def manual_selection(self, token, employee_id, pin_code, work_location=False):

        print("--------------------------------")

        print("manual_selection", token, employee_id, pin_code)

        company = self._get_company(token)

        if company:

            employee = request.env['hr.employee'].sudo().browse(employee_id)

            if employee.company_id == company and (

                    (not company.attendance_kiosk_use_pin) or (employee.pin == pin_code)):

                employee.sudo().with_context(work_location=work_location)._attendance_action_change(self._get_geoip_response('kiosk'))

                employee_data = self._get_employee_info_response(employee)

                employee_data['work_location'] = work_location

                return employee_data

        return {}


How can i give the parameters to the function? and what i need to return?

0
Avatar
Discard
Christoph Farnleitner

console.log(this.props.token, employeeId, enteredPin);
and see if these actually are set

Avatar
Cybrosys Techno Solutions Pvt.Ltd
Best Answer

Hi,


The issue was that JSON RPC passes parameters as keyword arguments, but your controller was expecting positional arguments. Using **kwargs fixes this.


Js:

const result = await this.rpc("/hr_attendance/manual_selection", {

    token: this.props.token,

    employee_id: employeeId,

    pin_code: enteredPin,

    work_location: false

});


Controller:

@http.route('/hr_attendance/manual_selection', type="json", auth="public", csrf=False)

def manual_selection(self, **kwargs):

    token = kwargs.get('token')

    employee_id = kwargs.get('employee_id')

    pin_code = kwargs.get('pin_code')

    work_location = kwargs.get('work_location', False)

    # rest of your existing code remains the same


Hope it helps

1
Avatar
Discard
Avatar
D Enterprise
Best Answer

Hii,

The issue you're encountering is because the rpc call you're making sends the parameters as a dictionary inside params, but your controller method is expecting positional arguments, not a dictionary.

Update your controller method to extract parameters from request.params

@http.route('/hr_attendance/manual_selection', type="json", auth="public", csrf=False) def manual_selection(self, **kwargs): token = kwargs.get('token') employee_id = kwargs.get('employee_id') pin_code = kwargs.get('pin_code') work_location = kwargs.get('work_location', False) print("--------------------------------") print("manual_selection", token, employee_id, pin_code) company = self._get_company(token) if company: employee = request.env['hr.employee'].sudo().browse(employee_id) if employee.company_id == company and ( (not company.attendance_kiosk_use_pin) or (employee.pin == pin_code) ): employee.sudo().with_context(work_location=work_location)._attendance_action_change( self._get_geoip_response('kiosk') ) employee_data = self._get_employee_info_response(employee) employee_data['work_location'] = work_location return employee_data return {}

I hope it is usefull

0
Avatar
Discard
Enjoying the discussion? Don't just read, join in!

Create an account today to enjoy exclusive features and engage with our awesome community!

Sign up
Related Posts Replies Views Activity
How to hide the title or the close (X) button from a dialogService dialog?
javascript development debug
Avatar
Avatar
2
Sep 25
945
Updating acc_holder_name via external function
javascript development configuration accounting function debug
Avatar
0
Sep 25
738
Cron job completes Instantly on production without throwing errors – works correctly on dev Solved
development configuration function debug
Avatar
Avatar
2
Sep 25
1196
OWL Component Not Rendering in Custom Layout (Odoo 18) — Likely XML Template Issue
javascript development project debug
Avatar
Avatar
1
Jul 25
3560
Testing of computed field in Odoo 18 extension dev
development debug
Avatar
1
Nov 25
422
Community
  • Tutorials
  • Documentation
  • Forum
Open Source
  • Download
  • Github
  • Runbot
  • Translations
Services
  • Odoo.sh Hosting
  • Support
  • Upgrade
  • Custom Developments
  • Education
  • Find an Accountant
  • Find a Partner
  • Become a Partner
About us
  • Our company
  • Brand Assets
  • Contact us
  • Jobs
  • Events
  • Podcast
  • Blog
  • Customers
  • Legal • Privacy
  • Security
الْعَرَبيّة Català 简体中文 繁體中文 (台灣) Čeština Dansk Nederlands English Suomi Français Deutsch हिंदी Bahasa Indonesia Italiano 日本語 한국어 (KR) Lietuvių kalba Język polski Português (BR) română русский язык Slovenský jazyk slovenščina Español (América Latina) Español ภาษาไทย Türkçe українська Tiếng Việt

Odoo is a suite of open source business apps that cover all your company needs: CRM, eCommerce, accounting, inventory, point of sale, project management, etc.

Odoo's unique value proposition is to be at the same time very easy to use and fully integrated.

Website made with

Odoo Experience on YouTube

1. Use the live chat to ask your questions.
2. The operator answers within a few minutes.

Live support on Youtube
Watch now