Skip to Content
Odoo Menu
  • Sign in
  • Try it free
  • Apps
    Finance
    • Accounting
    • Invoicing
    • Expenses
    • Spreadsheet (BI)
    • Documents
    • Sign
    Sales
    • CRM
    • Sales
    • POS Shop
    • POS Restaurant
    • Subscriptions
    • Rental
    Websites
    • Website Builder
    • eCommerce
    • Blog
    • Forum
    • Live Chat
    • eLearning
    Supply Chain
    • Inventory
    • Manufacturing
    • PLM
    • Purchase
    • Maintenance
    • Quality
    Human Resources
    • Employees
    • Recruitment
    • Time Off
    • Appraisals
    • Referrals
    • Fleet
    Marketing
    • Social Marketing
    • Email Marketing
    • SMS Marketing
    • Events
    • Marketing Automation
    • Surveys
    Services
    • Project
    • Timesheets
    • Field Service
    • Helpdesk
    • Planning
    • Appointments
    Productivity
    • Discuss
    • Approvals
    • IoT
    • VoIP
    • Knowledge
    • WhatsApp
    Third party apps Odoo Studio Odoo Cloud Platform
  • Industries
    Retail
    • Book Store
    • Clothing Store
    • Furniture Store
    • Grocery Store
    • Hardware Store
    • Toy Store
    Food & Hospitality
    • Bar and Pub
    • Restaurant
    • Fast Food
    • Guest House
    • Beverage Distributor
    • Hotel
    Real Estate
    • Real Estate Agency
    • Architecture Firm
    • Construction
    • Estate Management
    • Gardening
    • Property Owner Association
    Consulting
    • Accounting Firm
    • Odoo Partner
    • Marketing Agency
    • Law firm
    • Talent Acquisition
    • Audit & Certification
    Manufacturing
    • Textile
    • Metal
    • Furnitures
    • Food
    • Brewery
    • Corporate Gifts
    Health & Fitness
    • Sports Club
    • Eyewear Store
    • Fitness Center
    • Wellness Practitioners
    • Pharmacy
    • Hair Salon
    Trades
    • Handyman
    • IT Hardware & Support
    • Solar Energy Systems
    • Shoe Maker
    • Cleaning Services
    • HVAC Services
    Others
    • Nonprofit Organization
    • Environmental Agency
    • Billboard Rental
    • Photography
    • Bike Leasing
    • Software Reseller
    Browse all Industries
  • Community
    Learn
    • Tutorials
    • Documentation
    • Certifications
    • Training
    • Blog
    • Podcast
    Empower Education
    • Education Program
    • Scale Up! Business Game
    • Visit Odoo
    Get the Software
    • Download
    • Compare Editions
    • Releases
    Collaborate
    • Github
    • Forum
    • Events
    • Translations
    • Become a Partner
    • Services for Partners
    • Register your Accounting Firm
    Get Services
    • Find a Partner
    • Find an Accountant
    • Meet an advisor
    • Implementation Services
    • Customer References
    • Support
    • Upgrades
    Github Youtube Twitter Linkedin Instagram Facebook Spotify
    +1 (650) 691-3277
    Get a demo
  • Pricing
  • Help

Odoo is the world's easiest all-in-one management software.
It includes hundreds of business apps:

  • CRM
  • e-Commerce
  • Accounting
  • Inventory
  • PoS
  • Project
  • MRP
All apps
You need to be registered to interact with the community.
All Posts People Badges
Tags (View all)
odoo accounting v14 pos v15
About this forum
You need to be registered to interact with the community.
All Posts People Badges
Tags (View all)
odoo accounting v14 pos v15
About this forum
Help

Correct way to inherit class & functionalities in custom module?

Subscribe

Get notified when there's activity on this post

This question has been flagged
2 Replies
7177 Views
Avatar
Yenthe Van Ginneken (Mainframe Monkey)

Hi guys

The default behaviour from A -> Z for creating quotations is perfect and I want a second method for 'Internal' quotations which does 99% the same. By default there is no customer filled in when you create a new quotation under sales. I now want a second menu item 'Internal quotations' which does the same as quotations but by default the customer 'Internal customer' should be filled in.

I've made a custom module 'aa_maatwerk' which makes the new menu item through XML:

<menuitem id="menu_item_offertes" name="Internal quotations" parent="base.menu_sales"
                  action="sale.action_quotations_intern" sequence="5"/>

As you can see this action links to sale.action_quotations_intern which is in the file sale_view.xml in the module sale. I've basicly copied the record action_quotations and then created a new one with the name action_quotations_intern like this:

<record id="action_quotations_intern" model="ir.actions.act_window">
            <field name="name">Offertes - Intern</field>
            <field name="type">ir.actions.act_window</field>
            <field name="res_model">sale.order</field>
            <field name="view_type">form</field>
            <field name="view_id" ref="view_quotation_tree"/>
            <field name="view_mode">tree,form,calendar,graph</field>
            <field name="context">{'search_default_my_sale_orders_filter': 0,'type':'internal'}</field>
            <field name="domain">[('partner_id.name','=','Intern'),('state','in',('draft','sent','cancel'))]</field>
            <field name="search_view_id" ref="view_sales_order_filter"/>
            <field name="help" type="html">
              <p class="oe_view_nocontent_create">
                Click to create a quotation, the first step of a new sale.
              </p><p>
                Odoo will help you handle efficiently the complete sale flow:
                from the quotation to the sales order, the
                delivery, the invoicing and the payment collection.
              </p><p>
                The social feature helps you organize discussions on each sales
                order, and allow your customers to keep track of the evolution
                of the sales order.
              </p>
            </field>
        </record>

I now have two problems:
1) I would like to have everything in my custom module, to keep it seperated
2) When the user clicks on the menu item 'Internal quotations' the customer dropdown should be filled in by default with the customer 'Internal customer'.

Could anybody tell me how I can get all of this in one module, how to inherit this correctly and then fill in the customer name?
I have also inherited the sale class in sale_order.py in my custom module (aa_maatwerk) like this:

# -*- coding: utf-8 -*-
from openerp import http
from openerp imports models, fields,api

class SaleOrder(http.Controller):
    _inherit = 'sale.order'
    type = fields.Selection(selection=type_sel, string='Type')

    #I assume that this should override the 'old' class/method somehow?
    def create(self, cr, uid, values, context=None):
       type = context.get('type',False)  # check for type in context
       if type == 'internal':
           values['partner_id'] = self.pool.get('res.partner').search(cr, uid, 'Internal customer')[0]  # assuming find WILL return one ID!
           values['type'] = 'internal'   # create with type internal...
           return super(sale_order, self).create(cr, uid, values, context=None)

And I've also added the data and dependencies in my __openerp__py file:

# any module necessary for this one to work correctly
    'depends': ['base','sale','procurement','purchase'],

    # always loaded
    'data': [
        # 'security/ir.model.access.csv',
        'templates.xml',
    ],

But this doesn't seem to do anything and my customer is not filled in by default either.

With kind regards
Yenthe

0
Avatar
Discard
Yenthe Van Ginneken (Mainframe Monkey)
Author

Still no solution on this so I'll kindly 'bump' this.

Avatar
Zbik
Best Answer

Try this:

values['partner_id'] = self.pool.get('res.partner').search(cr, uid,[('name','=','Internal customer')])[0]  

UPDATE:

try like this:

class SaleOrder(models.Model):
    _inherit = 'sale.order'
    
    @api.model
    def create(self,values):
        type = False
        if 'type' in self._context:
              type = self._context['type']
        if type == 'internal':
           partners = self.env['res.partner'].search([('name','=','Internal customer')])
           if partners:
               values['partner_id'] = partners[0].id
               values['type'] = 'internal'  
        return super(sale_order, self).create(values)

 

 

1
Avatar
Discard
Yenthe Van Ginneken (Mainframe Monkey)
Author

Thanks for the answer Zbik! Sadly nothing changes.. Is there an easy way to find out where the problem is? Perhaps I inherited something wrong or something isn't linked to the correct record.

Zbik

Name == 'Internal customer'? try ('name','ilike','Internal customer')

Yenthe Van Ginneken (Mainframe Monkey)
Author

No success either. I have a customer named exactly 'Internal customer' too so I think something else is wrong/not triggered..

Zbik

answer updated

Yenthe Van Ginneken (Mainframe Monkey)
Author

Thanks zbik but this doesn't work either! "default_partner_id": 1 seems to work as deep suggest but this does not fetch me the correct record so thats not yet a solution either. Do you think my class is never triggered or something since this doesn't work either?

Deepa Venkatesh

@Yenthe, what Zbik is saying that your search syntax is incorrect, and Indeed it is.. So do have a look at it....

Zbik

You enable debug and insert line _logger.info("FOO %s %s", 'VALUES', values) before return, and _logger.info("FOO %s %s", 'CONTEXT', self._context) at start. You change search([('id','=',ID)]) - replace name by ID.

Yenthe Van Ginneken (Mainframe Monkey)
Author

I've added line_logger but nothing shows up. Even when I remove the return etc nothing changes and I get no errors. Looks like the method/class isn't even called?

Zbik

you have "depends" : ['sale'] in __openerp__.py?

Yenthe Van Ginneken (Mainframe Monkey)
Author

Yes I did! I've also added the code in my question which shows the data and depends.

Zbik

odoo is owner your .py files? debug log must be!!! PS. In your code return is only after if - redundant spaces or tab

Yenthe Van Ginneken (Mainframe Monkey)
Author

Yep user rights are fine for the Odoo user. The module also installs and the new menu items do show up, so it seems to have something to do with the sale_order.py file I assume. There is nothing in the logfiles.

Zbik

In my code - typo, model.Model instedad of models.Model. You verify all indentation and before class you instert _logger.info("FOO %s %s", 'START', 'STARTED')

Yenthe Van Ginneken (Mainframe Monkey)
Author

Hey zbik everything looks fine and I always indent with 4 spaces for every level. Picture: http://i.imgur.com/ksHhJEo.png File: http://pastebin.com/3H7BjV83 I don't see anything wrong?

Zbik

my typo on picture - correct it

Zbik

must be class SaleOrder(models.Model):

Yenthe Van Ginneken (Mainframe Monkey)
Author

Corrected and still nothing in the log, no errors, no name filled in :s

Zbik

addons path? you have more addons?

Zbik

__init__.py include your class?

Yenthe Van Ginneken (Mainframe Monkey)
Author

The __init__.py was the problem. Alright the file is loading correct now! Sadly your method is not filling in the customer though. What exactly should I import to use the logger? Could you add a little example please? I'll have to debug this I guess.

Yenthe Van Ginneken (Mainframe Monkey)
Author

Picture of my code: http://i.imgur.com/WhQDRpb.png nothing is getting printed in my Ubuntu screen and neither in my logfile..

Zbik

You add before class .... import logging _logger = logging.getLogger(__name__)

Zbik

I find another mistake, should be .....[0].id

Zbik

But this is construction is right only if search result exists

Zbik

answer updated

Yenthe Van Ginneken (Mainframe Monkey)
Author

I've updated my code to yours but this doesn't do anything either.. :s The logging doesn't print anything either. http://i.imgur.com/TzpjTN4.png Any other ideas zbik? I'm really stuck on this one..

Zbik

Move _logger = logging.getLogger(__name__) _logger.info("FOO %s %s", 'START', 'STARTED') before class. If *.py work must then be something in the log.

Yenthe Van Ginneken (Mainframe Monkey)
Author

The logger never seems to go off and nothing is placed in the logfile, neither on the terminal. I've also removed 'sale_order.py' from the data in __openerp__.py because that shouldn't be done if I am correct.. So what now? :s

Zbik

Send me all the files. I'll check on my system. darek@krokus.com.pl

Yenthe Van Ginneken (Mainframe Monkey)
Author

Sent! Thanks Zbik!

Zbik

Module sent!

Avatar
Deepa Venkatesh
Best Answer

Everything seems to be fine.. however action which have wrote is not overriden properly...

It should be like this

<record id="sale.action_quotations_intern" ..../>

whenever you are trying to overide or inherit, always the convention is of "MODULE_NAME.XML_ID", so in your code, you missed it on action definition...

EDITED:

Sorry I forgot to tell you... In the action, pass default value for partner in the context... like this "default_partner_id": 1 (if the partner ID is straight forward)..

Otherwise in the PY class, define a default_get method, in that using context, you can identify from which menu it is been called, so if it is called from your custom menu, then set the desired partner ID

 

EDITED AGAIN:

Try this code:

 

 def default_get(self, cr, uid, fields, context=None):

      res = super(sale_order, self).default_get(cr, uid, fields, context=context)
      type = context.get('type',False)  # check for type in context
      if type == 'internal':
          partner_ids = self.pool.get('res.partner').search(cr, uid, DOMAIN)
          res['partner_id'] = partner_ids and partner_ids[0] or False  # Will be assigning only one value
      return res

2
Avatar
Discard
Yenthe Van Ginneken (Mainframe Monkey)
Author

Thanks for the answer deep. I've changed action_quotations_intern to sale.action_quotations_intern in the file sale_view.xml (in the module sale) but nothing has changed. The customer still isn't filled in etc..

Deepa Venkatesh

Plz find my edited answer

Deepa Venkatesh

Do the particular code block of assigning partner in the default_get method...

Yenthe Van Ginneken (Mainframe Monkey)
Author

Seems that your update is a big step in the good way. I've added the 'default_partner_id':1 and this fills in 'Your Company'. How could I now modify this to search for the customer 'Internal customer' and fill this one it? (Note: upvoted this already since it did help me already, thanks)

Deepa Venkatesh

Thanks :) I just gave you an example w.r.t to XML in default, ID 1 represents Company Partner...

Deepa Venkatesh

So in your case, you go with default_method in Py class ...

Yenthe Van Ginneken (Mainframe Monkey)
Author

So how could I change this to load the customer 'Internal customer' dynamically and not by ID / hardcoded?

Deepa Venkatesh

And dont forget to pass the type as "internal" from XML context...

Yenthe Van Ginneken (Mainframe Monkey)
Author

Whatever I do those methods never seem to be called. When I do not return anything or program something that doesn't work there are no errors showing up in my Odoo. So there might be something else wrong?

Enjoying the discussion? Don't just read, join in!

Create an account today to enjoy exclusive features and engage with our awesome community!

Sign up
Community
  • Tutorials
  • Documentation
  • Forum
Open Source
  • Download
  • Github
  • Runbot
  • Translations
Services
  • Odoo.sh Hosting
  • Support
  • Upgrade
  • Custom Developments
  • Education
  • Find an Accountant
  • Find a Partner
  • Become a Partner
About us
  • Our company
  • Brand Assets
  • Contact us
  • Jobs
  • Events
  • Podcast
  • Blog
  • Customers
  • Legal • Privacy
  • Security
الْعَرَبيّة Català 简体中文 繁體中文 (台灣) Čeština Dansk Nederlands English Suomi Français Deutsch हिंदी Bahasa Indonesia Italiano 日本語 한국어 (KR) Lietuvių kalba Język polski Português (BR) română русский язык Slovenský jazyk slovenščina Español (América Latina) Español ภาษาไทย Türkçe українська Tiếng Việt

Odoo is a suite of open source business apps that cover all your company needs: CRM, eCommerce, accounting, inventory, point of sale, project management, etc.

Odoo's unique value proposition is to be at the same time very easy to use and fully integrated.

Website made with

Odoo Experience on YouTube

1. Use the live chat to ask your questions.
2. The operator answers within a few minutes.

Live support on Youtube
Watch now