Skip to Content
Odoo Menu
  • Sign in
  • Try it free
  • Apps
    Finance
    • Accounting
    • Invoicing
    • Expenses
    • Spreadsheet (BI)
    • Documents
    • Sign
    Sales
    • CRM
    • Sales
    • POS Shop
    • POS Restaurant
    • Subscriptions
    • Rental
    Websites
    • Website Builder
    • eCommerce
    • Blog
    • Forum
    • Live Chat
    • eLearning
    Supply Chain
    • Inventory
    • Manufacturing
    • PLM
    • Purchase
    • Maintenance
    • Quality
    Human Resources
    • Employees
    • Recruitment
    • Time Off
    • Appraisals
    • Referrals
    • Fleet
    Marketing
    • Social Marketing
    • Email Marketing
    • SMS Marketing
    • Events
    • Marketing Automation
    • Surveys
    Services
    • Project
    • Timesheets
    • Field Service
    • Helpdesk
    • Planning
    • Appointments
    Productivity
    • Discuss
    • Approvals
    • IoT
    • VoIP
    • Knowledge
    • WhatsApp
    Third party apps Odoo Studio Odoo Cloud Platform
  • Industries
    Retail
    • Book Store
    • Clothing Store
    • Furniture Store
    • Grocery Store
    • Hardware Store
    • Toy Store
    Food & Hospitality
    • Bar and Pub
    • Restaurant
    • Fast Food
    • Guest House
    • Beverage Distributor
    • Hotel
    Real Estate
    • Real Estate Agency
    • Architecture Firm
    • Construction
    • Estate Management
    • Gardening
    • Property Owner Association
    Consulting
    • Accounting Firm
    • Odoo Partner
    • Marketing Agency
    • Law firm
    • Talent Acquisition
    • Audit & Certification
    Manufacturing
    • Textile
    • Metal
    • Furnitures
    • Food
    • Brewery
    • Corporate Gifts
    Health & Fitness
    • Sports Club
    • Eyewear Store
    • Fitness Center
    • Wellness Practitioners
    • Pharmacy
    • Hair Salon
    Trades
    • Handyman
    • IT Hardware & Support
    • Solar Energy Systems
    • Shoe Maker
    • Cleaning Services
    • HVAC Services
    Others
    • Nonprofit Organization
    • Environmental Agency
    • Billboard Rental
    • Photography
    • Bike Leasing
    • Software Reseller
    Browse all Industries
  • Community
    Learn
    • Tutorials
    • Documentation
    • Certifications
    • Training
    • Blog
    • Podcast
    Empower Education
    • Education Program
    • Scale Up! Business Game
    • Visit Odoo
    Get the Software
    • Download
    • Compare Editions
    • Releases
    Collaborate
    • Github
    • Forum
    • Events
    • Translations
    • Become a Partner
    • Services for Partners
    • Register your Accounting Firm
    Get Services
    • Find a Partner
    • Find an Accountant
    • Meet an advisor
    • Implementation Services
    • Customer References
    • Support
    • Upgrades
    Github Youtube Twitter Linkedin Instagram Facebook Spotify
    +1 (650) 691-3277
    Get a demo
  • Pricing
  • Help

Odoo is the world's easiest all-in-one management software.
It includes hundreds of business apps:

  • CRM
  • e-Commerce
  • Accounting
  • Inventory
  • PoS
  • Project
  • MRP
All apps
You need to be registered to interact with the community.
All Posts People Badges
Tags (View all)
odoo accounting v14 pos v15
About this forum
You need to be registered to interact with the community.
All Posts People Badges
Tags (View all)
odoo accounting v14 pos v15
About this forum
Help

M2m attachment field issue in Odoo 16 CE: creator can access, but others cannot

Subscribe

Get notified when there's activity on this post

This question has been flagged
many2manym2mattachmentsAccessErrorodoo16features
4 Replies
5821 Views
Avatar
Nisanth N

Hi there,

I'm having an issue with m2m attachment in Odoo 16 CE. I've created a custom module that includes an m2m attachment field. The creator of the record can access the document, while other users cannot and receive an error message that says "Sorry, you are not allowed to access this document." If I save the record first and attach it, no issues are found. However, there are no record rules or access rules defined. I tested this in multiple environments including fresh odoo16 instant. When I searched for a solution to this issue, I found a similar bug with mail_template and fixed it with a _fix_attachment_ownership function in the creation of the record. (addons/mail/models/mail_template.py)

Does anyone else have this issue with m2m attachment in other models, or did I do something wrong?

Any help is highly appreciated.


my class is :

class EmployeeApproval(models.Model):
_name = 'employee.approval.info'
_rec_name = 'employee_id'
_inherit = ['mail.thread']
_description = 'Employee Approval Info'


employee_id = fields.Many2one(comodel_name='hr.employee', string="Employee", ondelete='cascade',help='Select corresponding Employee')
attachment_id = fields.Many2many('ir.attachment', 'approval_attachment_rel', 'approval_ref',
'attach_ref1',
string="Attachment(pdf)",
help='Attach any documents if required.')


0
Avatar
Discard
Avatar
Alberto Mastini
Best Answer

Hello,

can you please give more informations about the error? Maybe you can copy and paste it.

1
Avatar
Discard
Nisanth N
Author

Actually, it's falling to the raise error.

When debugging odoo\addons\base\models\ir_attachment.py Line:456

if not self.env.is_system() and (res_field or (not res_id and create_uid != self.env.uid)):
raise AccessError(_("Sorry, you are not allowed to access this document."))

In my case, if I create the record and then attach the document, the res_id is 0. However, if I save the record first and then attach the document, the res_id becomes the record ID

Alberto Mastini

Maybe you can trying to override the create of your record and forcely set the res_id to be the same as the Record Id. Let me know if can work for you!

Nisanth N
Author

I was able to find a solution by adapting the method from mail_template.py line 137, which includes the following code:

def _fix_attachment_ownership(self):
for record in self:
record.attachment_ids.write({'res_model': record._name, 'res_id': record.id})
return self

@api.model_create_multi
def create(self, vals_list):
return super().create(vals_list). _fix_attachment_ownership()

Thanks, Alberto.

Alberto Mastini

No problem, happy to be helpful!

Have a good one

Avatar
Eslam Saber
Best Answer

i have the exact same issue with a third party app but i don't know where should i add this lines and the developer don't respond currently

0
Avatar
Discard
Avatar
Ghulam Murtaza
Best Answer

I am facing the same issue when I create a record with an attachment file (ir.attachment) and save it. this record does not open from another account error shows 

Sorry, you are not allowed to access this document.

anyone can help how I can resolve this issue in odoo 16?

Support will be highly appreciated 

Thanks 

0
Avatar
Discard
Avatar
Andro Chvertkini
Best Answer

By default, attachment is not "public" therefore only the creator can access it. You can manually set public = True when you create your attachments or think about a better security solution.

https://github.com/odoo/odoo/blob/16.0/odoo/addons/base/models/ir_attachment.py#L404

0
Avatar
Discard
Nisanth N
Author

As I mentioned earlier, if I attach the documents after saving the record, then the record becomes accessible to others. I think, initially, res_id is not being saved at the moment the record is created.

Enjoying the discussion? Don't just read, join in!

Create an account today to enjoy exclusive features and engage with our awesome community!

Sign up
Related Posts Replies Views Activity
Singleton error for Odoo 16 in action Solved
many2many singleton odoo16features
Avatar
Avatar
Avatar
2
Mar 24
2455
Can supports be attached in inventory adjustments in Odoo 16? Solved
attachments odoo16features InventoryAdjustment
Avatar
Avatar
2
Mar 24
2066
Assistance Needed for Bulk Attachment Import in Odoo Helpdesk
attachments Helpdesk odoo16features
Avatar
Avatar
1
Nov 23
2378
[SOLVED] How to make visible selected values in many2one or many2many fields on Settings page in Odoo 16 Solved
many2one many2many odoo16features
Avatar
Avatar
Avatar
3
Dec 23
7358
How to filter records based on a parent field's id Solved
many2many filter_domain odoo16features
Avatar
Avatar
2
Mar 23
3819
Community
  • Tutorials
  • Documentation
  • Forum
Open Source
  • Download
  • Github
  • Runbot
  • Translations
Services
  • Odoo.sh Hosting
  • Support
  • Upgrade
  • Custom Developments
  • Education
  • Find an Accountant
  • Find a Partner
  • Become a Partner
About us
  • Our company
  • Brand Assets
  • Contact us
  • Jobs
  • Events
  • Podcast
  • Blog
  • Customers
  • Legal • Privacy
  • Security
الْعَرَبيّة Català 简体中文 繁體中文 (台灣) Čeština Dansk Nederlands English Suomi Français Deutsch हिंदी Bahasa Indonesia Italiano 日本語 한국어 (KR) Lietuvių kalba Język polski Português (BR) română русский язык Slovenský jazyk slovenščina Español (América Latina) Español ภาษาไทย Türkçe українська Tiếng Việt

Odoo is a suite of open source business apps that cover all your company needs: CRM, eCommerce, accounting, inventory, point of sale, project management, etc.

Odoo's unique value proposition is to be at the same time very easy to use and fully integrated.

Website made with

Odoo Experience on YouTube

1. Use the live chat to ask your questions.
2. The operator answers within a few minutes.

Live support on Youtube
Watch now