Skip to Content
This question has been flagged
python3odoo11.0PIL
2 Replies
6049 Views
Avatar
Ermin Trevisan

I try to migrate the module https://www.odoo.com/apps/modules/10.0/product_default_image/ to Odoo 11.0.

Based on this post (https://www.odoo.com/forum/help-1/question/how-can-i-add-default-image-to-wizard-104874) I have changed the code as follows:

product_image = fields.Binary(
        string='Global Product Image',
        default=lambda s: s._default_product_image(),
        help='Use as the global image for all product default images. '
             'Limited to 1024x1024.',
    )

    @api.model
    def _default_product_image(self):
        image_path = get_module_resource(
            'product_default_image', 'static/src/img', 'glob_prod_img.png'
        )
        with open(image_path, 'rb') as handler:
            image_data = handler.read()
        return tools.image_resize_image_big(image_data)

But now I get the following error:

Error:
Odoo Server Error

Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/odoo/http.py", line 653, in _handle_exception
    return super(JsonRequest, self)._handle_exception(exception)
  File "/usr/lib/python3/dist-packages/odoo/http.py", line 312, in _handle_exception
    raise pycompat.reraise(type(exception), exception, sys.exc_info()[2])
  File "/usr/lib/python3/dist-packages/odoo/tools/pycompat.py", line 87, in reraise
    raise value
  File "/usr/lib/python3/dist-packages/odoo/http.py", line 695, in dispatch
    result = self._call_function(**self.params)
  File "/usr/lib/python3/dist-packages/odoo/http.py", line 344, in _call_function
    return checked_call(self.db, *args, **kwargs)
  File "/usr/lib/python3/dist-packages/odoo/service/model.py", line 97, in wrapper
    return f(dbname, *args, **kwargs)
  File "/usr/lib/python3/dist-packages/odoo/http.py", line 337, in checked_call
    result = self.endpoint(*a, **kw)
  File "/usr/lib/python3/dist-packages/odoo/http.py", line 939, in __call__
    return self.method(*args, **kw)
  File "/usr/lib/python3/dist-packages/odoo/http.py", line 517, in response_wrap
    response = f(*args, **kw)
  File "/usr/lib/python3/dist-packages/odoo/addons/web/controllers/main.py", line 938, in call_button
    action = self._call_kw(model, method, args, {})
  File "/usr/lib/python3/dist-packages/odoo/addons/web/controllers/main.py", line 926, in _call_kw
    return call_kw(request.env[model], method, args, kwargs)
  File "/usr/lib/python3/dist-packages/odoo/api.py", line 689, in call_kw
    return call_kw_multi(method, model, args, kwargs)
  File "/usr/lib/python3/dist-packages/odoo/api.py", line 680, in call_kw_multi
    result = method(recs, *args, **kwargs)
  File "<decorator-gen-42>", line 2, in button_immediate_install
  File "/usr/lib/python3/dist-packages/odoo/addons/base/module/module.py", line 72, in check_and_log
    return method(self, *args, **kwargs)
  File "/usr/lib/python3/dist-packages/odoo/addons/base/module/module.py", line 450, in button_immediate_install
    return self._button_immediate_function(type(self).button_install)
  File "/usr/lib/python3/dist-packages/odoo/addons/base/module/module.py", line 552, in _button_immediate_function
    modules.registry.Registry.new(self._cr.dbname, update_module=True)
  File "/usr/lib/python3/dist-packages/odoo/modules/registry.py", line 85, in new
    odoo.modules.load_modules(registry._db, force_demo, status, update_module)
  File "/usr/lib/python3/dist-packages/odoo/modules/loading.py", line 380, in load_modules
    loaded_modules, update_module, models_to_check)
  File "/usr/lib/python3/dist-packages/odoo/modules/loading.py", line 274, in load_marked_modules
    perform_checks=perform_checks, models_to_check=models_to_check
  File "/usr/lib/python3/dist-packages/odoo/modules/loading.py", line 153, in load_module_graph
    registry.init_models(cr, model_names, {'module': package.name})
  File "/usr/lib/python3/dist-packages/odoo/modules/registry.py", line 306, in init_models
    model._auto_init()
  File "/usr/lib/python3/dist-packages/odoo/models.py", line 2220, in _auto_init
    new = field.update_db(self, columns)
  File "/usr/lib/python3/dist-packages/odoo/fields.py", line 849, in update_db
    self.update_db_notnull(model, column)
  File "/usr/lib/python3/dist-packages/odoo/fields.py", line 889, in update_db_notnull
    model._init_column(self.name)
  File "/usr/lib/python3/dist-packages/odoo/models.py", line 2137, in _init_column
    value = field.default(self)
  File "/usr/lib/python3/dist-packages/odoo/addons/product_default_image/models/res_company.py", line 46, in <lambda>
    default=lambda s: s._default_product_image(),
  File "/usr/lib/python3/dist-packages/odoo/addons/product_default_image/models/res_company.py", line 58, in _default_product_image
    return tools.image_resize_image_big(image_data)
  File "/usr/lib/python3/dist-packages/odoo/tools/image.py", line 143, in image_resize_image_big
    return image_resize_image(base64_source, size, encoding, filetype, avoid_if_small)
  File "/usr/lib/python3/dist-packages/odoo/tools/image.py", line 57, in image_resize_image
    image = Image.open(image_stream)
  File "/usr/lib/python3/dist-packages/PIL/Image.py", line 2590, in open
    % (filename if filename else fp))
OSError: cannot identify image file <_io.BytesIO object at 0x7f0425bf8a98>

Any idea on how to solve this?


Avatar
Discard
Avatar
Yenthe Van Ginneken (Mainframe Monkey)
Best Answer

Hi Ermin,

I believe it is failing at your end because you don't read the base64 encoded content of the file. This example works for me and I have it running on a few of my instances:

def _get_default_image(self):
    with open(modules.get_module_resource('product_default_image', 
    'static/src/img', 
    'glob_prod_img.png'), 
    'rb') as f:
        return base64.b64encode(f.read())

custom_image = fields.Binary(string='Image', default=_get_default_image)

Regards,
Yenthe

Avatar
Discard
Avatar
Ermin Trevisan
Author Best Answer

Hi Yenthe,

Thank you very much for your answer.

This is the new code I have based on your answer:

product_image = fields.Binary(
        string='Global Product Image', 
        default=_get_default_image,
        help='Use as the global image for all product default images. '
             'Limited to 1024x1024.',
    )

    @api.model
    def _get_default_image(self):
        with open(modules.get_module_resource('product_default_image', 
        'static/src/img', 
        'glob_prod_img.png'), 
        'rb') as f:
            return base64.b64encode(f.read())

But the error message now is:

2019-07-21 14:52:45,485 5663 ERROR ? werkzeug: Error on request:
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/werkzeug/serving.py", line 270, in run_wsgi
    execute(self.server.app)
  File "/usr/lib/python3/dist-packages/werkzeug/serving.py", line 258, in execute
    application_iter = app(environ, start_response)
  File "/usr/lib/python3/dist-packages/odoo/service/server.py", line 319, in app
    return self.app(e, s)
  File "/usr/lib/python3/dist-packages/odoo/service/wsgi_server.py", line 164, in application
    return werkzeug.contrib.fixers.ProxyFix(application_unproxied)(environ, start_response)
  File "/usr/lib/python3/dist-packages/werkzeug/contrib/fixers.py", line 152, in __call__
    return self.app(environ, start_response)
  File "/usr/lib/python3/dist-packages/odoo/service/wsgi_server.py", line 154, in application_unproxied
    result = handler(environ, start_response)
  File "/usr/lib/python3/dist-packages/odoo/http.py", line 1320, in __call__
    self.load_addons()
  File "/usr/lib/python3/dist-packages/odoo/http.py", line 1352, in load_addons
    m = __import__('odoo.addons.' + module)
  File "<frozen importlib._bootstrap>", line 971, in _find_and_load

  File "<frozen importlib._bootstrap>", line 955, in _find_and_load_unlocked

  File "<frozen importlib._bootstrap>", line 656, in _load_unlocked

  File "<frozen importlib._bootstrap>", line 626, in _load_backward_compatible

  File "/usr/lib/python3/dist-packages/odoo/modules/module.py", line 82, in load_module
    exec(open(modfile, 'rb').read(), new_mod.__dict__)
  File "<string>", line 5, in <module>

  File "/usr/lib/python3/dist-packages/odoo/addons/product_default_image/models/__init__.py", line 8, in <module>
    from . import res_company
  File "/usr/lib/python3/dist-packages/odoo/addons/product_default_image/models/res_company.py", line 16, in <module>
    class ResCompany(models.Model):
  File "/usr/lib/python3/dist-packages/odoo/addons/product_default_image/models/res_company.py", line 45, in ResCompany
    string='Global Product Image', default=_get_default_image,
NameError: name '_get_default_image' is not defined

How can I fix that?

Avatar
Discard
Yenthe Van Ginneken (Mainframe Monkey)

Put the function above the field definition and it'll work. Default methods have to be above the field definition in order to work :) I've modified my answer too as it might confuse others.

Ermin Trevisan
Author

I was thinking about that :-)

Thank you very much !

Yenthe Van Ginneken (Mainframe Monkey)

You're welcome! Best of luck Ermin :)

Related Posts Replies Views Activity
make my function work forever
python3 odoo11.0
Avatar
Avatar
1
Jan 20
3741
add python function to specific action
python3 odoo11.0
Avatar
0
Jan 20
4045
valid logged in user
python3 odoo11.0
Avatar
Avatar
1
Dec 19
4820
Add dynamic domain to allocation leave type
onchange python3 odoo11.0
Avatar
Avatar
1
May 24
3777
Hide fields in Filters And Group By Solved
python3 odoo11.0 Jquery
Avatar
Avatar
Avatar
3
Jun 23
17125