Skip to Content
Odoo Menu
  • Sign in
  • Try it free
  • Apps
    Finance
    • Accounting
    • Invoicing
    • Expenses
    • Spreadsheet (BI)
    • Documents
    • Sign
    Sales
    • CRM
    • Sales
    • POS Shop
    • POS Restaurant
    • Subscriptions
    • Rental
    Websites
    • Website Builder
    • eCommerce
    • Blog
    • Forum
    • Live Chat
    • eLearning
    Supply Chain
    • Inventory
    • Manufacturing
    • PLM
    • Purchase
    • Maintenance
    • Quality
    Human Resources
    • Employees
    • Recruitment
    • Time Off
    • Appraisals
    • Referrals
    • Fleet
    Marketing
    • Social Marketing
    • Email Marketing
    • SMS Marketing
    • Events
    • Marketing Automation
    • Surveys
    Services
    • Project
    • Timesheets
    • Field Service
    • Helpdesk
    • Planning
    • Appointments
    Productivity
    • Discuss
    • Artificial Intelligence
    • IoT
    • VoIP
    • Knowledge
    • WhatsApp
    Third party apps Odoo Studio Odoo Cloud Platform
  • Industries
    Retail
    • Book Store
    • Clothing Store
    • Furniture Store
    • Grocery Store
    • Hardware Store
    • Toy Store
    Food & Hospitality
    • Bar and Pub
    • Restaurant
    • Fast Food
    • Guest House
    • Beverage Distributor
    • Hotel
    Real Estate
    • Real Estate Agency
    • Architecture Firm
    • Construction
    • Property Management
    • Gardening
    • Property Owner Association
    Consulting
    • Accounting Firm
    • Odoo Partner
    • Marketing Agency
    • Law firm
    • Talent Acquisition
    • Audit & Certification
    Manufacturing
    • Textile
    • Metal
    • Furnitures
    • Food
    • Brewery
    • Corporate Gifts
    Health & Fitness
    • Sports Club
    • Eyewear Store
    • Fitness Center
    • Wellness Practitioners
    • Pharmacy
    • Hair Salon
    Trades
    • Handyman
    • IT Hardware & Support
    • Solar Energy Systems
    • Shoe Maker
    • Cleaning Services
    • HVAC Services
    Others
    • Nonprofit Organization
    • Environmental Agency
    • Billboard Rental
    • Photography
    • Bike Leasing
    • Software Reseller
    Browse all Industries
  • Community
    Learn
    • Tutorials
    • Documentation
    • Certifications
    • Training
    • Blog
    • Podcast
    Empower Education
    • Education Program
    • Scale Up! Business Game
    • Visit Odoo
    Get the Software
    • Download
    • Compare Editions
    • Releases
    Collaborate
    • Github
    • Forum
    • Events
    • Translations
    • Become a Partner
    • Services for Partners
    • Register your Accounting Firm
    Get Services
    • Find a Partner
    • Find an Accountant
    • Meet an advisor
    • Implementation Services
    • Customer References
    • Support
    • Upgrades
    Github Youtube Twitter Linkedin Instagram Facebook Spotify
    +1 (650) 691-3277
    Get a demo
  • Pricing
  • Help
You need to be registered to interact with the community.
All Posts People Badges
Tags (View all)
odoo accounting v14 pos v15
About this forum
You need to be registered to interact with the community.
All Posts People Badges
Tags (View all)
odoo accounting v14 pos v15
About this forum
Help

How do you refer in XML a new field added to sales.order.line in the same module?

Subscribe

Get notified when there's activity on this post

This question has been flagged
xmlsale.order.linesale.order.formsale.orderodooV8
1 Reply
9060 Views
Avatar
E.M.

I am creating a module which defines a new field named "sale_margin_percent" to sales.order.lines, and then a xml file which adds the field to forms and tries to add an "on_change" attribute to the new generated field.

sales_order_percent.py (note that sale_margin_percent field is defined)

# -*- coding: utf-8 -*-
from openerp import models, fields, api
class sale_order_line(models.Model):

_inherit = "sale.order.line"

sale_margin_percent = fields.Float('Margen de Ventas (%)', (4, 2))

def update_sale_margin(self, cr, uid, ids, price_unit, purchase_price, discount):
print 'DUMMY'

    def update_sale_price(self, cr, uid, ids, sale_margin_percent, purchase_price, discount):
       print 'DUMMY'


XML:

First sale_margin_order is added, and then an "on_change" attribute is tried to be added without success

<?xml version="1.0" encoding="utf-8"?>
<openerp>
<data>

<record model="ir.ui.view" id="sale_margin_percent_2">
<field name="name">sale.margin.percent.view.form</field>
<field name="model">sale.order</field>
<field name="inherit_id" ref="sale.view_order_form"/>
<field name="arch" type="xml">
<xpath expr="//field[@name='order_line']/form//field[@name='price_unit']" position="after">
<field name="sale_margin_percent" groups="base.group_user"/>
</xpath>
</field>
</record>

<record model="ir.ui.view" id="sale_margin_percent_3">
<field name="name">sale.order.line.tree.margin.view.form</field>
<field name="model">sale.order</field>
<field name="inherit_id" ref="sale.view_order_form"/>
<field name="arch" type="xml">
<xpath expr="//field[@name='order_line']/tree//field[@name='price_unit']" position="after">
<field name="sale_margin_percent" groups="base.group_user"/>
</xpath>
</field>
</record>


<record model="ir.ui.view" id="sale_margin_percent_u3">
<field name="name">sale.margin.percent.view.form</field>
<field name="model">sale.order</field>
<field name="inherit_id" ref="sale.view_order_form"/>
<field name="arch" type="xml">
<xpath expr="//field[@name='order_line']/tree//field[@name='sale_margin_percent']" position="attributes">
<attribute name="on_change">update_sale_price(sale_margin_percent, purchase_price, discount)</attribute>
</xpath>
</field>
</record>

</data>
</openerp>


ERROR:

ParseError: "ValidateError
Field(s) `arch` failed against a constraint: Invalid view definition

Error details:
Element '<xpath expr="//field[@name='order_line']/tree//field[@name='sale_margin_percent']">' cannot be located in parent view

Error context:
View `sale.margin.percent.view.form`
[view_id: 733, xml_id: n/a, model: sale.order, parent_id: 577]" while parsing /usr/lib/python2.7/dist-packages/openerp/addons/custom/sale_margin_percent/sale_margin_percent.xml:38, near
<record model="ir.ui.view" id="sale_margin_percent_u3">
<field name="name">sale.margin.percent.view.form</field>
<field name="model">sale.order</field>
<field name="inherit_id" ref="sale.view_order_form"/>
<field name="arch" type="xml">
<xpath expr="//field[@name='order_line']/tree//field[@name='sale_margin_percent']" position="attributes">
<attribute name="on_change">update_sale_price(sale_margin_percent, purchase_price, discount)</attribute>
</xpath>
</field>
</record>

0
Avatar
Discard
Avatar
Zbik
Best Answer

1. Do you know the module sale_margin?

2. Try this:

<record model="ir.ui.view" id="sale_margin_percent_u3">
<field name="name">sale.margin.percent.view.form</field>
<field name="model">sale.order</field>
<field name="inherit_id" ref="sale_margin_percent_3"/>
<field name="arch" type="xml">
<xpath expr="//field[@name='order_line']/tree//field[@name='sale_margin_percent']" position="attributes">
<attribute name="on_change">update_sale_price(sale_margin_percent, purchase_price, discount)</attribute>
</xpath>
</field>
</record>



1
Avatar
Discard
E.M.
Author

Thanks a lot, now I understand this much better and I even got two ways of doing it. Regarding first question: I do know module sale_margin; but sale_margin does not provide sale margin per line, just sale margin for the whole sale order. Additionally, it provides absolute margin, where most of sales chaps use sale margin in %, which is what they are used to all around the planet. Thanks a lot for your answers, they really help.

Enjoying the discussion? Don't just read, join in!

Create an account today to enjoy exclusive features and engage with our awesome community!

Sign up
Related Posts Replies Views Activity
Add a new field to sale.order.lines and display it in the form Solved
python sale.order.line sale.order.form sale.order odooV8
Avatar
Avatar
Avatar
2
Aug 16
13672
[SOLVED] How to add an on_change attribute to 'purchase_price' in a sales order form Solved
xml sale.order.line sale.order.form odooV8 purchases_price
Avatar
Avatar
2
Jul 15
7782
Modificación Lista de Productos en una Orden de Venta Solved
sale.order.line sale.order.form sale.order
Avatar
Avatar
2
Apr 25
2577
How to create a new model inherit from sale.order.line ? Solved
sale.order.line sale.order odooV8
Avatar
Avatar
Avatar
3
Apr 17
10885
How to enter a batch of order lines in Sales Order?
sale.order.line sale.order.form sale.order
Avatar
0
Mar 15
7085
Community
  • Tutorials
  • Documentation
  • Forum
Open Source
  • Download
  • Github
  • Runbot
  • Translations
Services
  • Odoo.sh Hosting
  • Support
  • Upgrade
  • Custom Developments
  • Education
  • Find an Accountant
  • Find a Partner
  • Become a Partner
About us
  • Our company
  • Brand Assets
  • Contact us
  • Jobs
  • Events
  • Podcast
  • Blog
  • Customers
  • Legal • Privacy
  • Security
الْعَرَبيّة Català 简体中文 繁體中文 (台灣) Čeština Dansk Nederlands English Suomi Français Deutsch हिंदी Bahasa Indonesia Italiano 日本語 한국어 (KR) Lietuvių kalba Język polski Português (BR) română русский язык Slovenský jazyk Slovenščina Español (América Latina) Español Svenska ภาษาไทย Türkçe українська Tiếng Việt

Odoo is a suite of open source business apps that cover all your company needs: CRM, eCommerce, accounting, inventory, point of sale, project management, etc.

Odoo's unique value proposition is to be at the same time very easy to use and fully integrated.

Website made with

Odoo Experience on YouTube

1. Use the live chat to ask your questions.
2. The operator answers within a few minutes.

Live support on Youtube
Watch now