Skip to Content
Odoo Menu
  • Sign in
  • Try it free
  • Apps
    Finance
    • Accounting
    • Invoicing
    • Expenses
    • Spreadsheet (BI)
    • Documents
    • Sign
    Sales
    • CRM
    • Sales
    • POS Shop
    • POS Restaurant
    • Subscriptions
    • Rental
    Websites
    • Website Builder
    • eCommerce
    • Blog
    • Forum
    • Live Chat
    • eLearning
    Supply Chain
    • Inventory
    • Manufacturing
    • PLM
    • Purchase
    • Maintenance
    • Quality
    Human Resources
    • Employees
    • Recruitment
    • Time Off
    • Appraisals
    • Referrals
    • Fleet
    Marketing
    • Social Marketing
    • Email Marketing
    • SMS Marketing
    • Events
    • Marketing Automation
    • Surveys
    Services
    • Project
    • Timesheets
    • Field Service
    • Helpdesk
    • Planning
    • Appointments
    Productivity
    • Discuss
    • Approvals
    • IoT
    • VoIP
    • Knowledge
    • WhatsApp
    Third party apps Odoo Studio Odoo Cloud Platform
  • Industries
    Retail
    • Book Store
    • Clothing Store
    • Furniture Store
    • Grocery Store
    • Hardware Store
    • Toy Store
    Food & Hospitality
    • Bar and Pub
    • Restaurant
    • Fast Food
    • Guest House
    • Beverage Distributor
    • Hotel
    Real Estate
    • Real Estate Agency
    • Architecture Firm
    • Construction
    • Estate Management
    • Gardening
    • Property Owner Association
    Consulting
    • Accounting Firm
    • Odoo Partner
    • Marketing Agency
    • Law firm
    • Talent Acquisition
    • Audit & Certification
    Manufacturing
    • Textile
    • Metal
    • Furnitures
    • Food
    • Brewery
    • Corporate Gifts
    Health & Fitness
    • Sports Club
    • Eyewear Store
    • Fitness Center
    • Wellness Practitioners
    • Pharmacy
    • Hair Salon
    Trades
    • Handyman
    • IT Hardware & Support
    • Solar Energy Systems
    • Shoe Maker
    • Cleaning Services
    • HVAC Services
    Others
    • Nonprofit Organization
    • Environmental Agency
    • Billboard Rental
    • Photography
    • Bike Leasing
    • Software Reseller
    Browse all Industries
  • Community
    Learn
    • Tutorials
    • Documentation
    • Certifications
    • Training
    • Blog
    • Podcast
    Empower Education
    • Education Program
    • Scale Up! Business Game
    • Visit Odoo
    Get the Software
    • Download
    • Compare Editions
    • Releases
    Collaborate
    • Github
    • Forum
    • Events
    • Translations
    • Become a Partner
    • Services for Partners
    • Register your Accounting Firm
    Get Services
    • Find a Partner
    • Find an Accountant
    • Meet an advisor
    • Implementation Services
    • Customer References
    • Support
    • Upgrades
    Github Youtube Twitter Linkedin Instagram Facebook Spotify
    +1 (650) 691-3277
    Get a demo
  • Pricing
  • Help

Odoo is the world's easiest all-in-one management software.
It includes hundreds of business apps:

  • CRM
  • e-Commerce
  • Accounting
  • Inventory
  • PoS
  • Project
  • MRP
All apps
You need to be registered to interact with the community.
All Posts People Badges
Tags (View all)
odoo accounting v14 pos v15
About this forum
You need to be registered to interact with the community.
All Posts People Badges
Tags (View all)
odoo accounting v14 pos v15
About this forum
Help

Design a field value verification (not odoo.api.constrains validation)

Subscribe

Get notified when there's activity on this post

This question has been flagged
fieldsmodels
3 Replies
12764 Views
Avatar
notteccon

Odoo 12 CE

​​​Class Dia​​gram: 

       ,-------------------.    
| question_request |
|-------------------|
| +Char Name |
| +Char LastName |
| +Integer Age |
| +Text Description |
|-------------------|
`-------------------'

Code

    from odoo import models, fields, api

class Request(models.Model):
_name = 'test.request'
_description = "Request"

name = fields.Char(string="Name", required=True)
last_name = fields.Char(string="Last Name", required=True)
age = fields.Integer(string="Age", required=True)
description = fields.Text()

Goal:

Feature for field's value manual validations by users.

Ex: Customer send a request with fiel's values as follow:​

    Name:     "Peterrrrrrrrrr"
LastName: "Smith"
Age:      150

It's not a feature about value validation ( odoo.api.constrains(*args) ), but about manual values verification by an user ("Peterrrrrr" is a valid value for the 'name' field, but an user need to confirm or verify that).

The first idea was to use an extra field for verification and another extra field for the comment

    Name:     State=Invalid, Comment="Typo error"
LastName: State=Valid
Age: State:Invalid, Comment="Confirm real age"

The first idea was to use an extra field for validation and another extra field for the comment

    from odoo import models, fields, api

class Request(models.Model):
_name = 'test.request'
_description = "Request"

name = fields.Char(string="Name", required=True)
last_name = fields.Char(string="Last Name", required=True)
age = fields.Integer(string="Age", required=True)
description = fields.Text()

# fields for validation
name_valid = fields.Selection([
('valid', 'Valid'),
('invalid', 'Invalid'),
('unvalidated', 'Unvalidated')
], default="unvalidated")
name_valid_comment = fields.Text()

​

But this is not a good aproach because the need of implmenting the 'field_value_validation' for each field and each model wich need the validation feature
So i thing to store the 'field_value_validation' in the 'FieldsValidation' related model as follows:

    from odoo import models, fields, api

class Request(models.Model):
_name = 'test.request'
_description = "Request"

name = fields.Char(string="Name", required=True)
last_name = fields.Char(string="Last Name", required=True)
age = fields.Integer(string="Age", required=True)
description = fields.Text()
fueld_validation_ids = ???

class FieldsValidation(models.Model):
_name = 'test.fields_validation'
_description = "Validation"

class_name = fields.Char(strng="Class")
record_id = ???
field_name = fields.Char(string="Field")
status = fields .Selection([
('valid', 'Valid'),
('invalid', 'Invalid'),
('unvalidated', 'Unvalidated')
], default="unvalidated")

​

Just right here i got stuck, so i thought to ask to the community.
Thanks in advance

0
Avatar
Discard
Avatar
notteccon
Author Best Answer

Hi Hilar AK, thanks for your answer.

I'm not asking about validation ( odoo.api.constrains(*args) ), but about manual values verification by an user ("Peterrrr" is a valid value for the name field, but an user need to confirm or verify that). Maybe i don't explain it well. I'll update the question to clarify.

0
Avatar
Discard
Avatar
Cayprol
Best Answer

I think Hilar's answer is the correct way to implement field validation.  

On top of that, in the newapi (v9 or newer), when raising exceptions, 'Warning' is deprecated, UserError and ValidationError are preferred in odoo api.  

UserError is more of a front-end way to avoid user input undesired value.   
ValidationError is designed for function or access right that type of thing.  

Also, I personally would make the constraint method private as well.

0
Avatar
Discard
Avatar
Hilar Andikkadavath
Best Answer

Just add some constraints for the fields. You can use SQL Constraints or write in python also using the decorator 

@api.constraints. 

eg:


@api.constrains('field_name')
def field_name_constratints(self):
if condition:
raise Warning(message)


0
Avatar
Discard
Enjoying the discussion? Don't just read, join in!

Create an account today to enjoy exclusive features and engage with our awesome community!

Sign up
Related Posts Replies Views Activity
View a field from one model in another model Solved
fields models
Avatar
Avatar
1
Nov 25
6128
How to find the field type? Solved
fields models
Avatar
Avatar
1
Jun 25
5930
Add base field (default_code) to a model (stock.quant)
fields models
Avatar
0
Nov 16
5284
Calculate fields from two different models
fields models
Avatar
Avatar
1
Aug 15
5577
How to transfer typed value to a field in a many2one field. Solved
fields models v18
Avatar
Avatar
1
Oct 25
1891
Community
  • Tutorials
  • Documentation
  • Forum
Open Source
  • Download
  • Github
  • Runbot
  • Translations
Services
  • Odoo.sh Hosting
  • Support
  • Upgrade
  • Custom Developments
  • Education
  • Find an Accountant
  • Find a Partner
  • Become a Partner
About us
  • Our company
  • Brand Assets
  • Contact us
  • Jobs
  • Events
  • Podcast
  • Blog
  • Customers
  • Legal • Privacy
  • Security
الْعَرَبيّة Català 简体中文 繁體中文 (台灣) Čeština Dansk Nederlands English Suomi Français Deutsch हिंदी Bahasa Indonesia Italiano 日本語 한국어 (KR) Lietuvių kalba Język polski Português (BR) română русский язык Slovenský jazyk slovenščina Español (América Latina) Español ภาษาไทย Türkçe українська Tiếng Việt

Odoo is a suite of open source business apps that cover all your company needs: CRM, eCommerce, accounting, inventory, point of sale, project management, etc.

Odoo's unique value proposition is to be at the same time very easy to use and fully integrated.

Website made with

Odoo Experience on YouTube

1. Use the live chat to ask your questions.
2. The operator answers within a few minutes.

Live support on Youtube
Watch now