Hi,

I have programmed the following module to automatically assign an EAN13 code to every new product (see code below).

The module works fine, both when you manually add products and when you import ONE product from CSV.

However, when trying to import a set of products (even a small number like 10) you get the following message:

Unknown error during import: <class 'openerp.exceptions.ValidationError'>: ('ValidateError', u'Field(s) `ean13` failed against a constraint: EAN13 code not valid. Use "Internal reference" field instead') in row number 5
Resolve other errors first

Row number varies from execution to execution. So it seems that the same code is being tried to be used twice (maybe CSV loads rows in paralel leading to a race condition or to the sequence to assign the same value).

What is wrong with the customized EAN13 method below? How should it be programmed to support CSV import too? Is there any way to make that code/transaction atomic?

EAN13 validation code:

# -*- coding: utf-8 -*-
from openerp import models, fields, api
 
# DESCRIPTION:
# Class EanAuto generates automatically EAN codes for new created products
# This ensures that every new product has its own unique EAN code
# Sequence is defined in XML file, and it is originally intended to use internal EAN13 codes
# although it can be used for any other codes.
# NOTES:
# It redefines create method adding additional required steps to retrieve a new EAN code
# to the product.
# If product is already provided with an EAN code it will be respected.
# If EAN code is used it will look for the next free value, so no duplicates are generated
# during creation through this routine.
# EAN duplicates are not checked elsewhere, at least not by this module.

class EanAuto ( models.Model ):
        _inherit = 'product.template'

        @api.model
        def create(self, vals):

                # Tests if EAN13 has been provided, if so do nothing, otherwise look for free EAN13 code
                if not vals.get('ean13'):
                        while True:
                                # Gets next value for custom EAN13 working out checksum digit
                                seq_id = self.env['ir.sequence'].search([('code','=','ean.code')])
                                ean_seq = seq_id._next()
                                ean_check_digit = 10 - (( sum(map(int, ean_seq[0::2])) + 3*sum(map(int, ean_seq[1::2])) ) % 10 )
                                ean_code = str(ean_seq) + str(ean_check_digit)

                                # Checks that there is no such EAN in use
                                prod_count = self.env['product.product'].search_count([('ean13','=',ean_code)])
                                if prod_count == 0:
                                        # EAN is not in use, so proceed
                                        vals.update({'ean13': ean_code})
                                        break

                # Creates the product using standard create method
                new_product_template = super(EanAuto, self).create(vals)

                # TEST TEST try to retrieve product_id of the new generated product
                #new_product_template.update({'ean13': new_product_template.product_id})

                return new_product_template

Sequence is defined as follows:

# cat sequence.xml
<?xml version="1.0" encoding="utf-8"?>
<openerp>
        <data noupdate="1">
                <record id="ean_code_sequence" model="ir.sequence.type">
                        <field name="name">EAN Code Sequence</field>
                        <field name="code">ean.code</field>
                </record>
                <record id="automatic_ean" model="ir.sequence">
                        <field name="name">Automatic EAN13</field>
                        <field name="code">ean.code</field>
                        <field name="prefix">291</field>
                        <field name="padding">9</field>
                </record>
        </data>
</openerp>