Odoo is the world's easiest all-in-one management software.
It includes hundreds of business apps:

CRM
e-Commerce
Boekhouding
Voorraad
PoS
Project
MRP

All apps

Alle posts Personen Badges

Labels (Bekijk alle)

odoo accounting v14 pos v15

Over dit forum

Help

Why hasn't Pull Request #236365 been merged yet?

development contribution

1 Beantwoorden

233 Weergaven

Mahmoud Essam

I'm signing the individual CLA for my contributions, and I've made my first PR.

It's opened Pull Request #236365 on November 18, 2025, titled "CLA: sign CLA.

I'm curious why it hasn't been merged after about a week. Is it pending review, does it require additional changes, or is there something specific holding it up (e.g., CLA-related issues or alignment with Odoo's contribution guidelines)?

Any feedback from maintainers, contributors, or community members would be greatly appreciated. Here's the direct link for reference: https://github.com/odoo/odoo/pull/236365

Thank you in advance for your help!

Mahmoud Essam

Auteur

Hi, Ray Carnes

First of all, thank you for your time to help me.

I did read the Odoo doc before my first PR.

After I did a successful installation of Odoo on my machine, here is what I did until I pushed my first PR:

1- git checkout master

2- git fetch upstream --depth=1 # I used --depth=1 flag because the Odoo repo is indeed massive (over 8GB full history)

3- git pull upstream master # Update to latest

4- git switch -c sign-cla

5- Edit the CLA file and add my file

- odoo/doc/cla/individual/mahmoudessam820.md

6- Commit and push:

- git add doc/cla/individual/mahmoudessam820.md

- git commit -m "[CLA] sign CLA for Mahmoud Essam"

- git push origin sign-cla

7- Open new PR

- Title: "CLA: sign CLA"

- Description: "Signing the individual CLA for my contributions."

- Allow maintainer edits > Create pull request.

I closed the first PR as you told me and opened a new one, but the same thing happened again, unfortunately

Link: https://github.com/odoo/odoo/pull/237451

What is wrong with these steps?

Ray Carnes (ray)

The target of your PR is 19.0 - you should target instead MASTER - the same branch you checked out.

Ray Carnes (ray)

I was able to change it for you, it looks MUCH better now.

Mahmoud Essam

Auteur

Thank you for taking the time to help me.

I will target the master branch for all my future PRs.

Targeting the 19.0 branch in my previous PR was my mistake, and that’s what caused the commit to include a large volume of changes. To make sure to avoid this in future contributions.

Ray Carnes (ray)

I don't think you are doing what you think you are doing - it does not need such a high volume of changes to sign the CLA.

Close this, start over, reviewing carefully the documentation at https://github.com/odoo/odoo/blob/19.0/doc/cla/sign-cla.md

Geniet je van het gesprek? Blijf niet alleen lezen, doe ook mee!

Maak vandaag nog een account aan om te profiteren van exclusieve functies en deel uit te maken van onze geweldige community!

Aanmelden

Gerelateerde posts	Antwoorden	Weergaven
¿Cuál es el número de teléfono de Copa Airlines en Colombia? (!!C-o-p-a!!) development contribution	0 nov. 25	35
(Spirit Teléfono Colombia)¿Cómo hablo con alguien en Spirit? action development contribution accounting	0 nov. 25	9
[@Guía-Telefónica-”del”] ¿Cómo hablar con una persona viva en Delta? development configuration contribution debug	0 nov. 25	10
{{$%$@AviancaColombiaTeléfono@} ¿Cómo se llama Avianca Colombia? development configuration contribution filter	0 nov. 25	28
Feature Request: Native “Dialog Filters” in Search Panel development	0 nov. 25	114

Deze vraag is gerapporteerd

Geniet je van het gesprek? Blijf niet alleen lezen, doe ook mee!