İçereği Atla
Bu soru işaretlendi
developmentcontribution
1 Cevapla
265 Görünümler
Avatar
Mahmoud Essam
I'm signing the individual CLA for my contributions, and I've made my first PR.

It's opened Pull Request #236365 on November 18, 2025, titled "CLA: sign CLA.

I'm curious why it hasn't been merged after about a week. Is it pending review, does it require additional changes, or is there something specific holding it up (e.g., CLA-related issues or alignment with Odoo's contribution guidelines)?

Any feedback from maintainers, contributors, or community members would be greatly appreciated. Here's the direct link for reference: https://github.com/odoo/odoo/pull/236365

Thank you in advance for your help!

Avatar
Vazgeç
Mahmoud Essam
Üretici
Hi, Ray Carnes

First of all, thank you for your time to help me.

I did read the Odoo doc before my first PR.

After I did a successful installation of Odoo on my machine, here is what I did until  I pushed my first PR:

1- git checkout master

2- git fetch upstream --depth=1 # I used --depth=1  flag because the Odoo repo is indeed massive (over 8GB full history)

3- git pull upstream master  # Update to latest

4- git switch -c sign-cla

5- Edit the CLA file and add my file

- odoo/doc/cla/individual/mahmoudessam820.md

6- Commit and push:

- git add doc/cla/individual/mahmoudessam820.md
- git commit -m "[CLA] sign CLA for Mahmoud Essam"
- git push origin sign-cla

7- Open new PR

- Title: "CLA: sign CLA"
- Description: "Signing the individual CLA for my contributions."
- Allow maintainer edits > Create pull request.

I closed the first PR as you told me and opened a new one, but the same thing happened again, unfortunately

Link: https://github.com/odoo/odoo/pull/237451

What is wrong with these steps?

Ray Carnes (ray)

The target of your PR is 19.0 - you should target instead MASTER - the same branch you checked out.

Ray Carnes (ray)

I was able to change it for you, it looks MUCH better now.

Mahmoud Essam
Üretici
Thank you for taking the time to help me.
I will target the master branch for all my future PRs.

Targeting the 19.0 branch in my previous PR was my mistake, and that’s what caused the commit to include a large volume of changes. To make sure to avoid this in future contributions.

Avatar
Ray Carnes (ray)
En İyi Yanıt

I don't think you are doing what you think you are doing - it does not need such a high volume of changes to sign the CLA.

Close this, start over, reviewing carefully the documentation at https://github.com/odoo/odoo/blob/19.0/doc/cla/sign-cla.md

Avatar
Vazgeç
İlgili Gönderiler Cevaplar Görünümler Aktivite
¿Cuál es el número de teléfono de Copa Airlines en Colombia? (!!C-o-p-a!!)
development contribution
Avatar
0
Kas 25
35
[LATAM]¿Cómo se llama Latam en Colombia?
development contribution debug
Avatar
0
Ara 25
4
((LATAM Airlines Colombia))¿Cómo llamar a Latam Colombia desde celular?
action development contribution chrome
Avatar
0
Ara 25
26
How do I change the name of the module, or rather the name assigned to the module, after I created it in Odoo Studio?
development
Avatar
Avatar
1
Ara 25
423
[@##Avianca~@@]¿Cómo se llama Avianca en Colombia?
development configuration contribution debug
Avatar
0
Ara 25
8