Hello, I'm encountering an unexpected psycopg2 error, psycopg2.errors.InvalidSavepointSpecification, as a result of using with env.cr.savepoint():
It's unclear if this is a bug, or if I'm somehow misusing this feature.
To describe my situation, I'm overriding the /shop/address route (part of the ecommerce checkout flow) controller to change a lot of behaviour to suit our client, in particular the sale is completed (no payment required) as soon as the address form is filled out correctly.
The control flow is simple, however:
1. The user fills out the form and submits it
2A: Either the form is successful in which case some Odoo records may be updated, created, etc. and the user is redirected,
2B: Or something went wrong and the user is sent back to the same page but with an error displayed.
(NOTE: "Something went wrong" should cover many cases, from custom-written validation failing to standard Odoo validation failing to Odoo database acting up and invalidating your transaction...)
As such I've written the following construction in python
try:
with request.cr.savepoint():
self._handle_form_data(form_data)
except ValidationError as e:
return self._render_validation_error(e)
except Exception as e:
return self._render_exception(e)
The idea of the try/except is that I don't want the user to ever see a 500 Server Error page, and in fact a lot of the exceptions I'm expecting can be nicely formatted and displayed to the user.
The idea of the savepoint is so that everything that happens in _handle_form_data is unrolled as soon as even a single thing goes wrong. I don't want "half a sale" to happen.
This appears to work just fine, but suddenly I've been inconsistently gettingpsycopg2.errors.InvalidSavepointSpecificationerrors appearing when the cr.savepoint() context is being exited (without any exceptions, mind you!), but for some reason the DB savepoint no longer exists.
Could this be caused by cr.commit() being called somewhere deep inside _handle_form_data? Am I using the savepoint wrong? Should I be creating a new cursor instead of using a savepoint?
I'm not realistically expecting an answer, but maybe an Odoo engineer sees this and can tell me what's going on here, or someone else finds this from googling the error and finds this page.
