Odoo is the world's easiest all-in-one management software.
It includes hundreds of business apps:

CRM
e-Commerce
Kirjanpito
Varastointi
PoS
Projekti
MRP

All apps

Kaikki kirjoitukset Ihmiset Merkit

Tunnisteet (Näytä kaikki)

odoo accounting v14 pos v15

Tietoa tästä foorumista

Apua

How to hide "discount" columns on saleorders/invoices if there are none?

invoice discount qweb sale.order

2 Vastaukset

9543 Näkymät

Malte Jörgens

I found this old thread discussing the same question:

https://www.odoo.com/forum/help-1/question/hide-discounts-on-order-lines-on-quotations-invoices-16510

However, the solution suggested is outdated and doesn't apply to the new QWeb-based reporting engine. I just wondered, if there is a better/easier solution by now to automatically determine, whether the "discount" column should be displayed or not. Also, it would be nice to hide the discount in an invoice line, if there is none given or it is negative.

Zbik

Paras vastaus

Modifications in Qweb report:

..... 
 <t t-set="is_discount" t-value="0"/> 
 <t t-foreach="o.invoice_line" t-as="l">
 <t t-if="l.discount"><t t-set="is_discount" t-value="1"/></t>
 </t> 
 <t t-if="is_discount">
   <th class="text-right" groups="sale.group_discount_per_so_line">Discount (%)</th>
 </t>

.....

<t t-if="is_discount">
 <td class="text-right" groups="sale.group_discount_per_so_line"><span t-field="l.discount"/></td>
</t>

Malte Jörgens

Tekijä

Sorry for the wait, I didn't have time until now to test the propsed solution.

With the answer of zbik pointing me in the direction, but the proposed solution not working, i had to modify it in two places to get it working:

<t t-set="is_discount" t-value="False"/>
<!-- This is important, otherwise is_discount will only be visible inside the foreach-loop and be undefined thereafter -->

<t t-foreach="o.order_line" t-as="l">
 <t t-if="l.discount"><t t-set="is_discount" t-value="True"/></t>
</t>

<!-- Table headers -->
<t t-if="is_discount">
  <th class="text-right">Discount</th>
</t>

<!-- Actual table row -->
<t t-if="is_discount"> <!-- Instead of l.discount, otherwise there is a cell missing and following columns will be shifted -->
 <td class="text-right" groups="sale.group_discount_per_so_line"><t t-if="l.discount"><span t-field="l.discount"/>&#160;%</t></td>
</t>

Which works very well altogether now.

PS: Sorry for posting this as answer, my karma doesn't allow me to comment yet :(

Zbik

Yes you are right,

Nautitko keskustelusta? Älä vain lue, vaan osallistu!

Luo tili jo tänään nauttiaksesi yksinoikeusominaisuuksista ja osallistuaksesi mahtavaan yhteisöömme!

Rekisteröidy

Aiheeseen liittyviä artikkeleita	Vastaukset	Näkymät
Override default QWEB template - not part of it but all content Ratkaistu invoice qweb templates quotation sale.order	2 jouluk. 24	8848
Cash Discount on Customer and Supplier Invoices Ratkaistu invoice discount	1 tammik. 23	9069
Create invoice from sales order using xml-rpc (python) invoice sale.order	1 lokak. 22	4829
How can I put the total price, without discount, in a sale order report? discount sale.order	1 helmik. 22	5261
How to add one more product after create invoice ? Ratkaistu invoice product qweb sale.order odooV9	3 heinäk. 19	6368

Tämä kysymys on merkitty

Nautitko keskustelusta? Älä vain lue, vaan osallistu!