Odoo is the world's easiest all-in-one management software.
It includes hundreds of business apps:

CRM
e-Commerce
Contabilitate
Inventar
PoS
Proiect
MRP

All apps

All Posts Oameni Insigne

Etichete (View all)

odoo accounting v14 pos v15

Despre acest forum

Suport

How to hide "discount" columns on saleorders/invoices if there are none?

invoice discount qweb sale.order

2 Răspunsuri

9604 Vizualizări

Malte Jörgens

I found this old thread discussing the same question:

https://www.odoo.com/forum/help-1/question/hide-discounts-on-order-lines-on-quotations-invoices-16510

However, the solution suggested is outdated and doesn't apply to the new QWeb-based reporting engine. I just wondered, if there is a better/easier solution by now to automatically determine, whether the "discount" column should be displayed or not. Also, it would be nice to hide the discount in an invoice line, if there is none given or it is negative.

Zbik

Cel mai bun răspuns

Modifications in Qweb report:

..... 
 <t t-set="is_discount" t-value="0"/> 
 <t t-foreach="o.invoice_line" t-as="l">
 <t t-if="l.discount"><t t-set="is_discount" t-value="1"/></t>
 </t> 
 <t t-if="is_discount">
   <th class="text-right" groups="sale.group_discount_per_so_line">Discount (%)</th>
 </t>

.....

<t t-if="is_discount">
 <td class="text-right" groups="sale.group_discount_per_so_line"><span t-field="l.discount"/></td>
</t>

Malte Jörgens

Autor

Sorry for the wait, I didn't have time until now to test the propsed solution.

With the answer of zbik pointing me in the direction, but the proposed solution not working, i had to modify it in two places to get it working:

<t t-set="is_discount" t-value="False"/>
<!-- This is important, otherwise is_discount will only be visible inside the foreach-loop and be undefined thereafter -->

<t t-foreach="o.order_line" t-as="l">
 <t t-if="l.discount"><t t-set="is_discount" t-value="True"/></t>
</t>

<!-- Table headers -->
<t t-if="is_discount">
  <th class="text-right">Discount</th>
</t>

<!-- Actual table row -->
<t t-if="is_discount"> <!-- Instead of l.discount, otherwise there is a cell missing and following columns will be shifted -->
 <td class="text-right" groups="sale.group_discount_per_so_line"><t t-if="l.discount"><span t-field="l.discount"/>&#160;%</t></td>
</t>

Which works very well altogether now.

PS: Sorry for posting this as answer, my karma doesn't allow me to comment yet :(

Zbik

Yes you are right,

Enjoying the discussion? Don't just read, join in!

Create an account today to enjoy exclusive features and engage with our awesome community!

Înscrie-te

Related Posts	Răspunsuri	Vizualizări
Override default QWEB template - not part of it but all content Rezolvat invoice qweb templates quotation sale.order	2 dec. 24	8888
Cash Discount on Customer and Supplier Invoices Rezolvat invoice discount	1 ian. 23	9102
Create invoice from sales order using xml-rpc (python) invoice sale.order	1 oct. 22	4853
How can I put the total price, without discount, in a sale order report? discount sale.order	1 feb. 22	5284
How to add one more product after create invoice ? Rezolvat invoice product qweb sale.order odooV9	3 iul. 19	6385

Această întrebare a fost marcată

Enjoying the discussion? Don't just read, join in!