Skip to Content
Odoo Menú
  • Registra entrada
  • Prova-ho gratis
  • Aplicacions
    Finances
    • Comptabilitat
    • Facturació
    • Despeses
    • Full de càlcul (IA)
    • Documents
    • Signatura
    Vendes
    • CRM
    • Vendes
    • Punt de venda per a botigues
    • Punt de venda per a restaurants
    • Subscripcions
    • Lloguer
    Imatges de llocs web
    • Creació de llocs web
    • Comerç electrònic
    • Blog
    • Fòrum
    • Xat en directe
    • Aprenentatge en línia
    Cadena de subministrament
    • Inventari
    • Fabricació
    • PLM
    • Compres
    • Manteniment
    • Qualitat
    Recursos humans
    • Empleats
    • Reclutament
    • Absències
    • Avaluacions
    • Recomanacions
    • Flota
    Màrqueting
    • Màrqueting Social
    • Màrqueting per correu electrònic
    • Màrqueting per SMS
    • Esdeveniments
    • Automatització del màrqueting
    • Enquestes
    Serveis
    • Projectes
    • Fulls d'hores
    • Servei de camp
    • Suport
    • Planificació
    • Cites
    Productivitat
    • Converses
    • Validacions
    • IoT
    • VoIP
    • Coneixements
    • WhatsApp
    Aplicacions de tercers Odoo Studio Plataforma d'Odoo al núvol
  • Sectors
    Comerç al detall
    • Llibreria
    • Botiga de roba
    • Botiga de mobles
    • Botiga d'ultramarins
    • Ferreteria
    • Botiga de joguines
    Food & Hospitality
    • Bar i pub
    • Restaurant
    • Menjar ràpid
    • Guest House
    • Distribuïdor de begudes
    • Hotel
    Immobiliari
    • Agència immobiliària
    • Estudi d'arquitectura
    • Construcció
    • Gestió immobiliària
    • Jardineria
    • Associació de propietaris de béns immobles
    Consultoria
    • Empresa comptable
    • Partner d'Odoo
    • Agència de màrqueting
    • Bufet d'advocats
    • Captació de talent
    • Auditoria i certificació
    Fabricació
    • Textile
    • Metal
    • Mobles
    • Menjar
    • Brewery
    • Regals corporatius
    Salut i fitness
    • Club d'esport
    • Òptica
    • Centre de fitness
    • Especialistes en benestar
    • Farmàcia
    • Perruqueria
    Trades
    • Servei de manteniment
    • Hardware i suport informàtic
    • Sistemes d'energia solar
    • Shoe Maker
    • Serveis de neteja
    • Instal·lacions HVAC
    Altres
    • Nonprofit Organization
    • Agència del medi ambient
    • Lloguer de panells publicitaris
    • Fotografia
    • Lloguer de bicicletes
    • Distribuïdors de programari
    Browse all Industries
  • Comunitat
    Aprèn
    • Tutorials
    • Documentació
    • Certificacions
    • Formació
    • Blog
    • Pòdcast
    Potenciar l'educació
    • Programa educatiu
    • Scale-Up! El joc empresarial
    • Visita Odoo
    Obtindre el programari
    • Descarregar
    • Comparar edicions
    • Novetats de les versions
    Col·laborar
    • GitHub
    • Fòrum
    • Esdeveniments
    • Traduccions
    • Converteix-te en partner
    • Services for Partners
    • Registra la teva empresa comptable
    Obtindre els serveis
    • Troba un partner
    • Troba un comptable
    • Contacta amb un expert
    • Serveis d'implementació
    • Referències del client
    • Suport
    • Actualitzacions
    Github Youtube Twitter Linkedin Instagram Facebook Spotify
    +1 (650) 691-3277
    Programar una demo
  • Preus
  • Ajuda

Odoo is the world's easiest all-in-one management software.
It includes hundreds of business apps:

  • CRM
  • e-Commerce
  • Comptabilitat
  • Inventari
  • PoS
  • Projectes
  • MRP
All apps
You need to be registered to interact with the community.
All Posts People Badges
Etiquetes (View all)
odoo accounting v14 pos v15
About this forum
You need to be registered to interact with the community.
All Posts People Badges
Etiquetes (View all)
odoo accounting v14 pos v15
About this forum
Ajuda

Odoo 17 - How to correct total inconsistency?

Subscriure's

Get notified when there's activity on this post

This question has been flagged
subtotaltotalincorrectodoo17
1 Respondre
4011 Vistes
Avatar
Aws Dayoub

I have changed the way of computing price_subtotal in sale order line

price_subtotal = number of members * price unit


I tried to override the method that compute the following:

amount_total, amount_untaxed, amount_to_invoice and amount_untaxed_to_invoice But no change


Here is my code:

class SaleOrderLine(models.Model):    _inherit = 'sale.order.line'

    num_members = fields.Integer(string="Number of Members", default=1)    price_subtotal = fields.Monetary(        string="Subtotal",        compute='_compute_amount',        store=True, precompute=True)      @api.depends('num_members', 'price_unit')    def _compute_amount(self):        for line in self:                  line.price_subtotal = line.num_members * line.price_unit            line.price_tax = 0            line.price_total = line.price_subtotal

    def _prepare_invoice_line(self, **optional_vals):        res = super(SaleOrderLine, self)._prepare_invoice_line(**optional_vals)        res['num_members'] = self.num_members

        return res





    @api.depends('state', 'product_id', 'untaxed_amount_invoiced', 'qty_delivered', 'num_members', 'price_unit')    def _compute_untaxed_amount_to_invoice(self):        """ Total of remaining amount to invoice on the sale order line (taxes excl.) as                total_sol - amount already invoiced            where Total_sol depends on the invoice policy of the product.

            Note: Draft invoice are ignored on purpose, the 'to invoice' amount should            come only from the SO lines.        """        for line in self:            amount_to_invoice = 0.0            if line.state == 'sale':                # Note: do not use price_subtotal field as it returns zero when the ordered quantity is                # zero. It causes problem for expense line (e.i.: ordered qty = 0, deli qty = 4,                # price_unit = 20 ; subtotal is zero), but when you can invoice the line, you see an                # amount and not zero. Since we compute untaxed amount, we can use directly the price                # reduce (to include discount) without using `compute_all()` method on taxes.                price_subtotal = 0.0                uom_qty_to_consider = line.qty_delivered if line.product_id.invoice_policy == 'delivery' else line.num_members                price_reduce = line.price_unit * (1 - (line.discount or 0.0) / 100.0)                price_subtotal = price_reduce * uom_qty_to_consider                if len(line.tax_id.filtered(lambda tax: tax.price_include)) > 0:                    # As included taxes are not excluded from the computed subtotal, `compute_all()` method                    # has to be called to retrieve the subtotal without them.                    # `price_reduce_taxexcl` cannot be used as it is computed from `price_subtotal` field. (see upper Note)                    price_subtotal = line.tax_id.compute_all(                        price_reduce,                        currency=line.currency_id,                        quantity=uom_qty_to_consider,                        product=line.product_id,                        partner=line.order_id.partner_shipping_id)['total_excluded']                inv_lines = line._get_invoice_lines()                if any(inv_lines.mapped(lambda l: l.discount != line.discount)):                    # In case of re-invoicing with different discount we try to calculate manually the                    # remaining amount to invoice                    amount = 0                    for l in inv_lines:                        if len(l.tax_ids.filtered(lambda tax: tax.price_include)) > 0:                            amount += l.tax_ids.compute_all(l.currency_id._convert(l.price_unit, line.currency_id, line.company_id, l.date or fields.Date.today(), round=False) * l.quantity)['total_excluded']                        else:                            amount += l.currency_id._convert(l.price_unit, line.currency_id, line.company_id, l.date or fields.Date.today(), round=False) * l.quantity

                    amount_to_invoice = max(price_subtotal - amount, 0)                else:                    amount_to_invoice = price_subtotal - line.untaxed_amount_invoiced

            line.untaxed_amount_to_invoice = amount_to_invoice            print('YYYYYYYYYYYYYYYYYYYYYYYYY')            print('_compute_untaxed_amount_to_invoice', line.untaxed_amount_to_invoice)



class SaleOrder(models.Model):    _inherit = 'sale.order'


    amount_untaxed = fields.Monetary(string="Untaxed Amount", store=True, compute='_compute_amounts', tracking=5)    amount_total = fields.Monetary(string="Total", store=True, compute='_compute_amounts', tracking=4)    amount_to_invoice = fields.Monetary(string="Amount to invoice", store=True, compute='_compute_amount_to_invoice')

    @api.onchange('order_line.price_subtotal')    @api.depends('order_line.price_subtotal', 'order_line.price_tax', 'order_line.price_total')    def _compute_amounts(self):   #     super(SaleOrder, self)._compute_amounts()        for order in self:            amount_untaxed = 0            for line in order.order_line:                amount_untaxed += line.price_subtotal            order.amount_tax = 0            order.amount_untaxed = amount_untaxed            order.amount_total = amount_untaxed            print('TTTTTTTTTTTTTTTTTTTTTTTTTTGGGGGGGGGGGG')            print('amount_total', order.amount_total)

        #@api.depends('invoice_ids.state', 'currency_id', 'amount_total')    @api.depends('amount_total')    def _compute_amount_to_invoice(self):        for order in self:            order.amount_to_invoice = 99999            print('FFFFFFFFFFFFFEEEEEEEEEEEEEEEEE')            print("amount_to_invoice", order.amount_to_invoice)            '''            # If the invoice status is 'Fully Invoiced' force the amount to invoice to equal zero and return early.            if order.invoice_status == 'invoiced':                order.amount_to_invoice = 0.0                continue

            invoices = order.invoice_ids.filtered(lambda x: x.state == 'posted')            # Note: A negative amount can happen, since we can invoice more than the sales order amount.            # Care has to be taken when summing amount_to_invoice of multiple orders.            # E.g. consider one invoiced order with -100 and one uninvoiced order of 100: 100 + -100 = 0            order.amount_to_invoice = order.amount_total - invoices._get_sale_order_invoiced_amount(order)  


          '''


class AccountMoveLine(models.Model):    _inherit = 'account.move.line'

        num_members = fields.Integer(string="Number of Members", default=1, store=True, compute='_compute_num_members_from_sale_order')    price_subtotal = fields.Monetary(string='Subtotal', store=True, compute='_compute_price_subtotal')


    @api.depends('move_id', 'move_id.invoice_line_ids')    def _compute_num_members_from_sale_order(self):        for line in self:            sale_order_line = line.sale_line_ids            if sale_order_line:                line.num_members = sale_order_line.num_members             else:                line.num_members = 1              print('MEEEEEEEEEEEEMMMMMMMMMMMMM')


    @api.depends('num_members', 'price_unit', 'discount')    def _compute_price_subtotal(self):        for line in self:            print('PPPPPPPPRRRRRRRRRRRRRRIIIIICCCCCCCCCCEEEEEEEEEEEE')            print('num_members:', line.num_members)            price = line.num_members * line.price_unit             line.price_subtotal = line.move_id.currency_id.round(price)            #line.write({'price_subtotal': line.move_id.currency_id.round(price)})            print('FFFFFFFFFFFFGGGGGGGGGGGGGGGGG')





0
Avatar
Descartar
Niyas Raphy (Walnut Software Solutions)

Could you add your full code here

Avatar
Gracious Joseph
Best Answer

To resolve the issue of total inconsistency in Odoo 17 when modifying the computation of price_subtotal in the sale.order.line, you need to ensure that the computations for related fields like amount_total, amount_untaxed, and others are consistently overridden and stored properly. Here's how to resolve this step by step:

Key Points to Address

  1. Incorrect or Missing Dependencies:
    • Fields like price_subtotal or amount_total need proper dependency tracking to trigger re-computation.
  2. Consistency Between Models:
    • The custom logic must align across sale.order, sale.order.line, and account.move.line to avoid mismatch issues.

Corrected Implementation

1. Sale Order Line Customization

Modify the price_subtotal computation in the sale.order.line.

from odoo import models, fields, api

class SaleOrderLine(models.Model):
    _inherit = 'sale.order.line'

    num_members = fields.Integer(string="Number of Members", default=1)
    price_subtotal = fields.Monetary(
        string="Subtotal", 
        compute='_compute_amount', 
        store=True
    )

    @api.depends('num_members', 'price_unit', 'product_uom_qty', 'discount', 'tax_id')
    def _compute_amount(self):
        for line in self:
            # Compute subtotal based on number of members
            line.price_subtotal = line.num_members * line.price_unit * (1 - (line.discount or 0.0) / 100.0)
            # Compute taxes (if needed)
            taxes = line.tax_id.compute_all(
                line.price_unit,
                line.order_id.currency_id,
                quantity=line.num_members,
                product=line.product_id,
                partner=line.order_id.partner_shipping_id
            ) if line.tax_id else {'total_excluded': 0.0, 'total_included': 0.0}

            line.price_tax = taxes['total_included'] - taxes['total_excluded']
            line.price_total = taxes['total_included']

2. Sale Order Customization

Update the amount_total and amount_untaxed computations in the sale.order model.

class SaleOrder(models.Model):
    _inherit = 'sale.order'

    amount_untaxed = fields.Monetary(
        string="Untaxed Amount", 
        store=True, 
        compute='_compute_amounts'
    )
    amount_total = fields.Monetary(
        string="Total", 
        store=True, 
        compute='_compute_amounts'
    )
    amount_tax = fields.Monetary(
        string="Taxes", 
        store=True, 
        compute='_compute_amounts'
    )

    @api.depends('order_line.price_subtotal', 'order_line.price_tax')
    def _compute_amounts(self):
        for order in self:
            amount_untaxed = sum(line.price_subtotal for line in order.order_line)
            amount_tax = sum(line.price_tax for line in order.order_line)
            order.update({
                'amount_untaxed': amount_untaxed,
                'amount_tax': amount_tax,
                'amount_total': amount_untaxed + amount_tax,
            })

3. Account Move Line Customization

Ensure the computation is consistent in the account.move.line for proper invoicing.

class AccountMoveLine(models.Model):
    _inherit = 'account.move.line'

    num_members = fields.Integer(
        string="Number of Members", 
        default=1, 
        compute='_compute_num_members_from_sale_order', 
        store=True
    )
    price_subtotal = fields.Monetary(
        string='Subtotal', 
        store=True, 
        compute='_compute_price_subtotal'
    )

    @api.depends('sale_line_ids', 'sale_line_ids.num_members')
    def _compute_num_members_from_sale_order(self):
        for line in self:
            sale_order_line = line.sale_line_ids[:1]  # Get the first linked sale order line
            line.num_members = sale_order_line.num_members if sale_order_line else 1

    @api.depends('num_members', 'price_unit', 'discount')
    def _compute_price_subtotal(self):
        for line in self:
            price = line.num_members * line.price_unit * (1 - (line.discount or 0.0) / 100.0)
            line.price_subtotal = line.move_id.currency_id.round(price)

4. Update Invoice Preparation

Ensure that the num_members field is included when preparing the invoice line.

class SaleOrderLine(models.Model):
    _inherit = 'sale.order.line'

    def _prepare_invoice_line(self, **optional_vals):
        invoice_line_vals = super(SaleOrderLine, self)._prepare_invoice_line(**optional_vals)
        invoice_line_vals['num_members'] = self.num_members
        return invoice_line_vals

5. Common Troubleshooting Tips

  1. Check Stored Fields:
    • Ensure all computed fields have store=True to persist values and trigger dependent computations.
  2. Recompute and Update:
    • After updating the models, trigger a recompute for existing records:
      odoo shell
      SaleOrder = env['sale.order']
      SaleOrderLine = env['sale.order.line']
      SaleOrderLine._compute_amount()
      SaleOrder._compute_amounts()
      
  3. Check Dependencies:
    • Verify that all dependent fields (e.g., num_members, price_unit) are included in the @api.depends() decorators.
  4. Validate Tax Calculations:
    • If taxes are included, ensure tax_id.compute_all() is called correctly in both the sale order line and account move line computations.

Key Changes

  • Subtotal Calculation: Updated in sale.order.line based on num_members.
  • Total Calculation: Updated in sale.order to reflect the modified subtotals and taxes.
  • Invoicing Consistency: Synchronized num_members and price_subtotal across sale.order.line and account.move.line.

By implementing these changes, you should resolve the inconsistency issues for totals in Odoo 17. Let me know if you encounter further challenges!

0
Avatar
Descartar
Enjoying the discussion? Don't just read, join in!

Create an account today to enjoy exclusive features and engage with our awesome community!

Registrar-se
Related Posts Respostes Vistes Activitat
I have changed the way of computing price subtotal in sale.order.line but now the total and total untaxed is not correct
subtotal total untaxed odoo17
Avatar
0
de des. 24
2155
How to Add "Subtotal & Total" in Report?
subtotal report total studio
Avatar
Avatar
1
de febr. 22
6559
Error while posting invoice to ZATCA odoo sh Solved
odoo17
Avatar
Avatar
Avatar
Avatar
3
de jul. 25
3142
How to send a real-time notification to POS UI using bus.bus in Odoo 17?
odoo17
Avatar
Avatar
1
de juny 25
5347
Odoo time-sheets rights to add
odoo17
Avatar
Avatar
2
de maig 25
3082
Community
  • Tutorials
  • Documentació
  • Fòrum
Codi obert
  • Descarregar
  • GitHub
  • Runbot
  • Traduccions
Serveis
  • Allotjament a Odoo.sh
  • Suport
  • Actualització
  • Desenvolupaments personalitzats
  • Educació
  • Troba un comptable
  • Troba un partner
  • Converteix-te en partner
Sobre nosaltres
  • La nostra empresa
  • Actius de marca
  • Contacta amb nosaltres
  • Llocs de treball
  • Esdeveniments
  • Pòdcast
  • Blog
  • Clients
  • Informació legal • Privacitat
  • Seguretat
الْعَرَبيّة Català 简体中文 繁體中文 (台灣) Čeština Dansk Nederlands English Suomi Français Deutsch हिंदी Bahasa Indonesia Italiano 日本語 한국어 (KR) Lietuvių kalba Język polski Português (BR) română русский язык Slovenský jazyk slovenščina Español (América Latina) Español ภาษาไทย Türkçe українська Tiếng Việt

Odoo és un conjunt d'aplicacions empresarials de codi obert que cobreix totes les necessitats de la teva empresa: CRM, comerç electrònic, comptabilitat, inventari, punt de venda, gestió de projectes, etc.

La proposta única de valor d'Odoo és ser molt fàcil d'utilitzar i estar totalment integrat, ambdues alhora.

Website made with

Odoo Experience on YouTube

1. Use the live chat to ask your questions.
2. The operator answers within a few minutes.

Live support on Youtube
Watch now