Ir al contenido
Menú
Se marcó esta pregunta
2 Respuestas
1091 Vistas

Hey there! I'm having a tricky issue with my custom Cards payment module for Odoo 18 POS. I built this module to handle credit card payments with installments, and everything works great except for one annoying detail in the payment screen. The total amount in the payment summary doesn't update automatically when selecting installments. This is my custom implementation that extends the default POS payment screen, using a CardsPaymentHandler class to manage card brands and installment calculations. The weird part is that the amount only updates in two scenarios:

If I remove the payment method and add it again (then it shows the correct total from the order/status)

If I manually type numbers using the POS numeric keypad (then it updates the payment method total in the summary)

All the interest calculations work fine, and I can see the correct amounts in the state, but for some reason, the payment summary display won't refresh with the new total when choosing installments.

Has anyone encountered something similar when extending the POS payment screen or knows what might be missing? Maybe there's a specific method I need to call to force the payment summary update?

I published the main functions that manage the updates of the totals according to the installments.

Thanks in advance!

/**

    * Handles card brand selection change

    * Resets prices and loads available installments

    * @param {Event} ev Change event from select element

    */

async onCardBrandChange(ev) {

    const cardBrand = ev.target.value;

    this._resetPrices();

    if (!cardBrand) {

        this._resetState();

        return;

    }


    try {

        const amount = this.currentOrder.get_total_with_tax();

        const installments = await rpc('/pos_payment_method/get_installments', {

            payment_method_id: CARDS_PAYMENT_METHOD_ID,

            card_brand: cardBrand,

            amount: amount

        });


        if (!installments) {

            throw new Error('There isn´t installments plan.');

        }


        this.state.selectedCardBrand = cardBrand;

        this.state.installmentOptions = this._formatInstallmentOptions(installments);

        this.screen.render();

    } catch (error) {

        this._resetState();

        this.showError('Error loading installments');

    }

}


/**

    * Handles installment selection change

    * Updates order amounts and payment line with interest

    * @param {Event} ev Change event from select element

    */

onInstallmentChange(ev) {

    const installments = ev.target.value;

    const option = this.state.installmentOptions.find(

        opt => opt.installments.toString() === installments

    );


    if (!option) return;


    try {

        // Update state with selected installment data

        Object.assign(this.state, {

            selectedInstallments: option.installments,

            installmentAmount: parseFloat(option.amount),

            totalWithInterest: parseFloat(option.total),

            interestRate: parseFloat(option.rate)

        });

        if (typeof option.coefficient === 'number' && !isNaN(option.coefficient)) {

            this._updateOrderLinesWithInterest(option.coefficient);

            const totalWithInterest = parseFloat(this.state.totalWithInterest);

            if (!isNaN(totalWithInterest) && this.selectedPaymentLine) {

                this.selectedPaymentLine.amount = totalWithInterest;

                this.selectedPaymentLine.set_payment_status("done");

                if (this.screen.numberBuffer) {

                    this.screen.numberBuffer.set(totalWithInterest.toString());

                }

            }

        }

        this._updatePaymentSummary();

        this.screen.render();

    } catch (error) {

        this.showError('Error processing installment change');

    }

}


/**

    * Updates order lines with interest coefficient

    * Recalculates totals and updates UI

    * @param {number} coefficient Interest multiplier

    */

_updateOrderLinesWithInterest(coefficient) {

    const order = this.currentOrder;

    if (!order) return;


    const coef = parseFloat(coefficient);

    if (isNaN(coef)) return;


    order.get_orderlines().forEach(line => {

        try {

            if (!line.original_price) {

                line.original_price = line.get_unit_price();

            }

            line.set_unit_price(line.original_price * coef);

        } catch (error) {

            console.error('Error processing line:', error);

        }

    });


    order.recomputeOrderData();

    this.state.totalWithInterest = order.amount_total;

    this._forcePaymentSummaryUpdate();

}


/**

    * Forces payment summary update in UI

    * Updates totals, remaining amount and payment lines

    */

_forcePaymentSummaryUpdate() {

    if (!this.currentOrder) return;


    try {

        Object.assign(this.screen.state, {

            totalAmount: this.currentOrder.amount_total,

            remainingAmount: this.currentOrder.get_due(),

            paymentLines: [...this.currentOrder.payment_ids]

        });

        if (this.screen.numberBuffer) {

            this.screen.numberBuffer.set(this.state.totalWithInterest.toString());

        }

        this.screen.render();

    } catch (error) {

        this.showError('Error updating payment summary');

    }

}


/**

    * Updates payment summary with new totals

    * Handles payment line amount updates

    */

_updatePaymentSummary() {

    if (!this.currentOrder || !this.selectedPaymentLine) return;

    const paid = this.currentOrder.get_total_paid();

    const remaining = Math.max(this.state.totalWithInterest - paid, 0);

    Object.assign(this.screen.state, {

        totalAmount: this.state.totalWithInterest,

        remainingAmount: remaining,

        paymentLines: [...this.currentOrder.payment_ids]

    });

    this.selectedPaymentLine.set_amount(this.state.totalWithInterest);

    this.currentOrder.set_total_with_tax(this.state.totalWithInterest);

    this.screen.payment_interface.update_payment_summary({

        total: this.state.totalWithInterest,

        total_paid: paid,

        remaining: remaining

    });

    this.screen.render();

}


/**

    * Updates payment line amount

    * Handles amount validation and UI updates

    * @param {number|false} amount New amount or false to get from buffer

    */

updatePaymentLine(amount = false) {

    this.updateReferences();

    if (amount === false) {

        amount = this.screen.numberBuffer.getFloat();

    }

    if (amount === null) {

        this._resetPrices();

        this.screen.deletePaymentLine(this.screen.selectedPaymentLine.uuid);

        return;

    }

    const maxAmount = this.state.totalWithInterest || this.currentOrder.get_total_with_tax();

    if (amount > maxAmount) {

        amount = maxAmount;

        this.screen.numberBuffer.set(maxAmount.toString());

        this._showMaxAmountError();

    }

    this.screen.selectedPaymentLine.set_amount(amount);

    this.screen.render();

}


/**

    * Resets prices to original values

    * Clears interest calculations

    */

_resetPrices() {

    const order = this.currentOrder;

    if (!order) return;

    order.get_orderlines().forEach(line => {

        try {

            if (line.original_price) {

                line.set_unit_price(line.original_price);

                line.setLinePrice();

            }

        } catch (error) {

            console.error('Error resetting price:', error);

        }

    });

    order.recomputeOrderData();

}

Avatar
Descartar
Autor

Hi there!, after 4 months i managed to make an absolutely FREE module for use with credit cards through the Fiserv gateway service (at the moment it only works for Argentina but it could be improved for other countries).

It is published on github, you can find it as fiserv_gateway.

The ideal is that we can all improve it as a community so that it works in the countries that see it useful.
It still has several points to improve, but it is a good starting point for all those who need a form of payment online and at the POS with debit/credit cards.
Any queries can locate my contact details on my github profile.
Kind regards

Autor Mejor respuesta

Hello Tiago,

I thank you for your kindness, but I have already tried all the options provided by the available AI and I have not been able to make progress.

Kind regards.

Avatar
Descartar
Mejor respuesta

The analysis of your code indicates that the main functions to update the payment summary are in place, but there might be issues related to the DOM rendering cycle or state synchronization in the Odoo POS. Here are the potential causes and solutions for the issue of the payment summary not refreshing when selecting installments:


Potential Causes

  1. DOM Rendering Cycle Issue
    • The DOM might not be updating correctly after the installment calculations. This happens when state changes are not propagated to the user interface components.
  2. Update Methods Not Called Properly
    • Although _updatePaymentSummary is being called, it might require a more explicit method to ensure the POS updates the payment component.
  3. numberBuffer Synchronization
    • The numeric buffer synchronization with the new totals might not be functioning correctly, requiring a more explicit approach to reflect the updated amounts.

Fixes and Improvements

1. Force Screen Refresh

Add an explicit command to force the payment component to re-render after updates:

_updatePaymentSummary() {
    if (!this.currentOrder || !this.selectedPaymentLine) return;

    const paid = this.currentOrder.get_total_paid();
    const remaining = Math.max(this.state.totalWithInterest - paid, 0);

    Object.assign(this.screen.state, {
        totalAmount: this.state.totalWithInterest,
        remainingAmount: remaining,
        paymentLines: [...this.currentOrder.payment_ids],
    });

    this.selectedPaymentLine.set_amount(this.state.totalWithInterest);
    this.currentOrder.set_total_with_tax(this.state.totalWithInterest);

    // Explicitly update the payment interface
    if (this.screen.payment_interface) {
        this.screen.payment_interface.update_payment_summary({
            total: this.state.totalWithInterest,
            total_paid: paid,
            remaining: remaining,
        });
    }

    // Force a screen re-render
    this.screen.render(true);
}

2. Update numberBuffer

Ensure the numberBuffer is synchronized with the recalculated totals:

if (this.screen.numberBuffer) {
    this.screen.numberBuffer.reset();
    this.screen.numberBuffer.set(this.state.totalWithInterest.toString());
}

3. Explicitly Recalculate and Update Totals

After updating the installments, ensure the order data is fully recalculated:

this.currentOrder.recomputeOrderData();
this.state.totalWithInterest = this.currentOrder.amount_total;
this._forcePaymentSummaryUpdate();

4. Force Global State Updates

If the state changes are not propagating correctly, add a mechanism to trigger a global update:

this.env.pos.trigger('update-screen');

Final Checks

Ensure that:

  1. POS Dependencies: There are no broken dependencies or modifications in your POS module that might prevent updates.
  2. Order and Lines: Update methods like recomputeOrderData are being called at the right time.
  3. Custom Events: If needed, create custom events to trigger component updates.

Enable Detailed Logging

If the issue persists, enable detailed logging to pinpoint where the state changes are not propagating correctly. For example:

console.log('Current State:', this.state);
console.log('Order Total:', this.currentOrder.amount_total);
console.log('Payment Lines:', this.currentOrder.payment_ids);

This will help isolate the problem. Tell me if it helped you.... 

by chatGPT





Another answer (outra resposta):


Analisando o código fornecido, posso identificar o problema e sugerir uma correção. O principal motivo pelo qual o sumário de pagamento não está atualizando automaticamente é devido à forma como as atualizações de estado estão sendo manipuladas.


(By analyzing the code provided, I can identify the problem and suggest a fix. The main reason the payment summary is not updating automatically is due to the way state updates are being handled.)


class CardsPaymentHandler {
    async onCardBrandChange(ev) {
        const cardBrand = ev.target.value;
        this._resetPrices();
       
        if (!cardBrand) {
            this._resetState();
            return;
        }

        try {
            const amount = this.currentOrder.get_total_with_tax();
            const installments = await rpc('/pos_payment_method/get_installments', {
                payment_method_id: CARDS_PAYMENT_METHOD_ID,
                card_brand: cardBrand,
                amount: amount
            });

            if (!installments) {
                throw new Error('Não há plano de parcelamento disponível.');
            }

            this.state.selectedCardBrand = cardBrand;
            this.state.installmentOptions = this._formatInstallmentOptions(installments);
            this._triggerUpdate();  // Nova função para garantir atualização
        } catch (error) {
            this._resetState();
            this.showError('Erro ao carregar parcelas');
        }
    }

    onInstallmentChange(ev) {
        const installments = ev.target.value;
        const option = this.state.installmentOptions.find(
            opt => opt.installments.toString() === installments
        );

        if (!option) return;

        try {
            Object.assign(this.state, {
                selectedInstallments: option.installments,
                installmentAmount: parseFloat(option.amount),
                totalWithInterest: parseFloat(option.total),
                interestRate: parseFloat(option.rate)
            });

            if (typeof option.coefficient === 'number' && !isNaN(option.coefficient)) {
                this._updateOrderLinesWithInterest(option.coefficient);
                this._updatePaymentLine(this.state.totalWithInterest);  // Atualiza linha de pagamento
            }
           
            this._triggerUpdate();  // Força atualização completa
        } catch (error) {
            this.showError('Erro ao processar alteração de parcelas');
        }
    }

    _updatePaymentLine(amount) {
        if (this.selectedPaymentLine) {
            this.selectedPaymentLine.amount = amount;
            this.selectedPaymentLine.set_payment_status("done");
        }
    }

    _triggerUpdate() {
        // Nova função para garantir atualização completa
        this._updatePaymentSummary();
        this.screen.render();
       
        // Força atualização do componente pai
        if (this.screen.props.update) {
            this.screen.props.update();
        }
       
        // Atualiza o buffer numérico se necessário
        if (this.screen.numberBuffer) {
            this.screen.numberBuffer.set(this.state.totalWithInterest.toString());
        }
    }

    _updatePaymentSummary() {
        if (!this.currentOrder) return;

        const totalWithInterest = this.state.totalWithInterest || this.currentOrder.get_total_with_tax();
        const paid = this.currentOrder.get_total_paid();
        const remaining = Math.max(totalWithInterest - paid, 0);

        // Atualiza o estado do pedido
        this.currentOrder.set_total_with_tax(totalWithInterest);

        // Atualiza o estado da tela
        Object.assign(this.screen.state, {
            totalAmount: totalWithInterest,
            remainingAmount: remaining,
            paymentLines: [...this.currentOrder.payment_ids]
        });

        // Atualiza a interface de pagamento
        this.screen.payment_interface.update_payment_summary({
            total: totalWithInterest,
            total_paid: paid,
            remaining: remaining
        });
    }
}

export default CardsPaymentHandler;


As principais correções e melhorias implementadas são:


Criação do método _triggerUpdate() para centralizar todas as atualizações necessárias

Melhor gerenciamento do estado e atualizações da interface

Atualização consistente da linha de pagamento

Tratamento mais robusto dos valores com juros

Garantia de que o sumário de pagamento seja sempre atualizado


Principais mudanças:


Centralização das atualizações em um único método _triggerUpdate()

Melhor tratamento das atualizações do numberBuffer

Adição de verificações de segurança para evitar erros

Garantia de que o componente pai seja notificado das mudanças

Atualização consistente do estado do pedido e da interface


Para implementar esta correção, você precisará:


Substituir seu código atual pelo novo

Certificar-se de que a classe está sendo corretamente exportada

Verificar se todas as dependências estão disponíveis

Testar especialmente os cenários de alteração de parcelas


(The main corrections and improvements implemented are:


Creation of the _triggerUpdate() method to centralize all necessary updates

Better state management and interface updates

Consistent payline update

More robust treatment of interest-bearing amounts

Ensuring that the payment summary is always updated


Main changes:


Centralization of updates in a single _triggerUpdate() method

Better handling of numberBuffer updates

Adding security checks to prevent errors

Ensuring that the parent component is notified of changes

Consistent order and interface state update


To implement this fix, you will need:


Replace your current code with the new one

Make sure the class is being exported correctly

Check if all dependencies are available

Specially test installment change scenarios.)

By Claude.ai

Avatar
Descartar

EI Diego!

Estou buscando uma solução para oferecer parcelamentos no meu site.
Estou no Brasil e aqui não existe a possibilidade de um e-commerce não oferecer parcelamento. Descobri esta semana que o Odoo tem essa limitação e fiquei bem desapontado.

Tenho resolvido muitos problemas dentro do Odoo com o auxílio das iAs, mas como não estou programando, não consigo checar se essas soluções funcionariam.

Seguirei acompanhando o seu post.

Publicaciones relacionadas Respuestas Vistas Actividad
1
jul 25
726
0
jun 25
500
2
jun 25
562
0
abr 25
997
1
mar 25
1419