Skip to Content
Odoo Menu
  • Prijavi
  • Try it free
  • Apps
    Finance
    • Accounting
    • Invoicing
    • Expenses
    • Spreadsheet (BI)
    • Documents
    • Sign
    Sales
    • CRM
    • Sales
    • POS Shop
    • POS Restaurant
    • Subscriptions
    • Rental
    Websites
    • Website Builder
    • eCommerce
    • Blog
    • Forum
    • Live Chat
    • eLearning
    Supply Chain
    • Inventory
    • Manufacturing
    • PLM
    • Purchase
    • Maintenance
    • Quality
    Human Resources
    • Employees
    • Recruitment
    • Time Off
    • Appraisals
    • Referrals
    • Fleet
    Marketing
    • Social Marketing
    • Email Marketing
    • SMS Marketing
    • Events
    • Marketing Automation
    • Surveys
    Services
    • Project
    • Timesheets
    • Field Service
    • Helpdesk
    • Planning
    • Appointments
    Productivity
    • Discuss
    • Approvals
    • IoT
    • VoIP
    • Knowledge
    • WhatsApp
    Third party apps Odoo Studio Odoo Cloud Platform
  • Industries
    Retail
    • Book Store
    • Clothing Store
    • Furniture Store
    • Grocery Store
    • Hardware Store
    • Toy Store
    Food & Hospitality
    • Bar and Pub
    • Restaurant
    • Fast Food
    • Guest House
    • Beverage Distributor
    • Hotel
    Real Estate
    • Real Estate Agency
    • Architecture Firm
    • Construction
    • Estate Management
    • Gardening
    • Property Owner Association
    Consulting
    • Accounting Firm
    • Odoo Partner
    • Marketing Agency
    • Law firm
    • Talent Acquisition
    • Audit & Certification
    Manufacturing
    • Textile
    • Metal
    • Furnitures
    • Food
    • Brewery
    • Corporate Gifts
    Health & Fitness
    • Sports Club
    • Eyewear Store
    • Fitness Center
    • Wellness Practitioners
    • Pharmacy
    • Hair Salon
    Trades
    • Handyman
    • IT Hardware & Support
    • Solar Energy Systems
    • Shoe Maker
    • Cleaning Services
    • HVAC Services
    Others
    • Nonprofit Organization
    • Environmental Agency
    • Billboard Rental
    • Photography
    • Bike Leasing
    • Software Reseller
    Browse all Industries
  • Community
    Learn
    • Tutorials
    • Documentation
    • Certifications
    • Training
    • Blog
    • Podcast
    Empower Education
    • Education Program
    • Scale Up! Business Game
    • Visit Odoo
    Get the Software
    • Download
    • Compare Editions
    • Releases
    Collaborate
    • Github
    • Forum
    • Events
    • Translations
    • Become a Partner
    • Services for Partners
    • Register your Accounting Firm
    Get Services
    • Find a Partner
    • Find an Accountant
    • Meet an advisor
    • Implementation Services
    • Customer References
    • Support
    • Upgrades
    Github Youtube Twitter Linkedin Instagram Facebook Spotify
    +1 (650) 691-3277
    Get a demo
  • Pricing
  • Help

Odoo is the world's easiest all-in-one management software.
It includes hundreds of business apps:

  • CRM
  • e-Commerce
  • Knjigovodstvo
  • Zaloga
  • PoS
  • Projekt
  • MRP
All apps
You need to be registered to interact with the community.
All Posts People Badges
Ključne besede (View all)
odoo accounting v14 pos v15
About this forum
You need to be registered to interact with the community.
All Posts People Badges
Ključne besede (View all)
odoo accounting v14 pos v15
About this forum
Pomoč

Product attributes / dimensions / property structure: Best design?

Naroči se

Get notified when there's activity on this post

This question has been flagged
databaseinheritancev7ormstructure
11133 Prikazi
Avatar
CB

In an MRP context, I have several products that have varying attributes I need to keep track of. For example, we have Doors that need to track edge profiles / wood species / panel types and drawer pulls that we need to track, say, material and shape.

One approach would be to append all of the data to product.product:

class product_product(osv.osv):
    _name = _inherit = 'product.product'
    _columns = {
        'product_type': fields.selection(('', ''), ('door', 'Door'), ('pull', 'Pull')),
        'door_edge_profile': fields.char(size=40),
        'door_wood_species': fields.char(size=40),
        'pull_material': fields.char(size=40),
        'pull_shape': fields.char(size=40),
    }

This approach works, but is rather denormalized - all products have these extra fields, and they may or may not be used. The data is stored as columns appended to product.product.

Another approach is a separate class per product type:

class product_door(osv.osv):
    _name = 'product.product.door',
    _inherit = 'product.product',
    _columns = {
        'door_edge_profile': fields.char(size=40),
        'door_wood_species': fields.char(size=40),
    }

class product_pull(osv.osv):
    _name = 'product.product.pull',
    _inherit = 'product.product',
    _columns = {
        'pull_material': fields.char(size=40),
        'pull_shape': fields.char(size=40),
    }

This approach also works, but the data is now split between two tables, with a product_id column hanging off the child tables. This is nice because the code is easy to separate / deal with, but makes the UI component harder - The end user will need to visit a different section when editing door or pull details, and none of the existing views will incorporate any data about the door or product.

A third approach i've discovered is a little hacky, but works:

class product_door(osv.osv):
    _name = 'product.product.door',
    _columns = {
        'door_edge_profile': fields.char(size=40),
        'door_wood_species': fields.char(size=40),
    }

class product_pull(osv.osv):
    _name = 'product.product.pull',
    _columns = {
        'pull_material': fields.char(size=40),
        'pull_shape': fields.char(size=40),
    }


class product_product(osv.osv):
    _name = _inherit = 'product.product'
    _inherits = {
        'product.product.door': 'door_id',
        'product.product.pull': 'pull_id',
    }

This approach keeps the data in it's own tables, and composes the fields into the product instance. The effect on the UI is the same as option 2 (in that it's somewhat negative), and the data is nicely separated. However, this implies again that every product has door or pull attributes in terms of the db design.

I really like SQLAlchemy's inheritance mapping, so i'll use those names when i'm talking about them further.

The first example I showed, which seems like the "default way" people seem to add to OpenERP models, is single table inheritance.

The second example is Joined Table Inheritance, where the child tables point to their parent.

The third example is 'backwards' joined table inheritance, or composition.

====

Separate from these concerns is using, say, product_variant_multi and encode the product attributes as Dimensions. Or, one could not use Dimensions, and instead apply 'mrp.property' properties to the product. This is more of an EAV data store, but I'm not certain that this complexity is worth it.


So, how do most OpenERP users generally model their databases?

Thanks for the advice.

7
Avatar
Opusti
Gabriel

Thanks CB for the summary. That's a very pertinent question when we are dealing with large range of product and attributes!

However, I could not get your third example working on v7. Are you sure we can have both Class inheritance (same name (product.product)) and multiple inheritance from other tables at the same time, without changing the final table name? But that would be great as existing views would still be working.

I would add to the possible designs, the product_custom_attributes module.

Looking forward to reading other OpenERP users suggestions.

CB
Avtor

I believe the third method works, as OpenERP considers the composed columns as part of this object's columns via orm.BaseModel._get_column_infos. I think this would allow views and code to treat the columns in much the same way that normal columns in the first method would work. However, _inherits does not allow one to propagate method calls. The reason is the commented method orm.BaseModel.__getattr__ which has a note about breaking super(). Also, specifically in orm.BaseModel._read_flat, you can see that it iterates over the _inherits tables and adds the data to read()'s result.

Enjoying the discussion? Don't just read, join in!

Create an account today to enjoy exclusive features and engage with our awesome community!

Prijavi
Related Posts Odgovori Prikazi Aktivnost
What is the ORM used in version 7 of OpenERP? Solved
database v7 orm
Avatar
Avatar
Avatar
9
feb. 17
12185
How to select a different database on login screen Solved
database v7
Avatar
4
jul. 24
33918
Creating database results in "database already exists"
database v7
Avatar
Avatar
1
mar. 15
8423
write/create id database
database orm
Avatar
Avatar
1
mar. 15
6083
How to select one database by default ? Solved
configuration database v7
Avatar
Avatar
Avatar
Avatar
Avatar
6
jul. 24
84790
Community
  • Tutorials
  • Documentation
  • Forum
Open Source
  • Download
  • Github
  • Runbot
  • Translations
Services
  • Odoo.sh Hosting
  • Support
  • Upgrade
  • Custom Developments
  • Education
  • Find an Accountant
  • Find a Partner
  • Become a Partner
About us
  • Our company
  • Brand Assets
  • Contact us
  • Jobs
  • Events
  • Podcast
  • Blog
  • Customers
  • Legal • Privacy
  • Security
الْعَرَبيّة Català 简体中文 繁體中文 (台灣) Čeština Dansk Nederlands English Suomi Français Deutsch हिंदी Bahasa Indonesia Italiano 日本語 한국어 (KR) Lietuvių kalba Język polski Português (BR) română русский язык Slovenský jazyk slovenščina Español (América Latina) Español ภาษาไทย Türkçe українська Tiếng Việt

Odoo is a suite of open source business apps that cover all your company needs: CRM, eCommerce, accounting, inventory, point of sale, project management, etc.

Odoo's unique value proposition is to be at the same time very easy to use and fully integrated.

Website made with

Odoo Experience on YouTube

1. Use the live chat to ask your questions.
2. The operator answers within a few minutes.

Live support on Youtube
Watch now