Skip to Content
You need to be registered to interact with the community.
All Posts People Badges
Ključne besede (View all)
odoo accounting v14 pos v15
About this forum
This question has been flagged
salesale.order.lineodoo10.0
4 Odgovori
27709 Prikazi
Avatar
tyrion

I have a sale.order.line field commission_line that computes the commission amount of the product line.

class SaleOrderlineInherited(models.Model):
    _inherit = 'sale.order.line'
    commission_line_percentage = fields.Float(related='product_id.product_tmpl_id.commission_percentage')
    commission_line = fields.Float(string='Commission', compute='get_commission')
    @api.depends('commission_line_percentage')    
    def get_commission(self):
        for record in self:
            record['commission_line'] = (record.price_subtotal * record.commission_line_percentage) / 100
        return None

The above code runs fine. Next I want to calculate all the sum of commission_line fields to get the total commission from the sale.order. I tried this code.

class CustommSaleOrder(models.Model):
    _inherit = 'sale.order'
    commission = fields.Char(string='Total Commission', compute='calculate_total_commission')
    def calculate_total_commission(self):
        print 'came in'
        summ = None
        for record in self.env['sale.order.line']:
            print 'commission'
            summ += record.commission_line_percentage
        self.env['sale.order'].commission = summ
        return None

This doesn't work. How to correct the code so as to get the sum of all commission_line as the total commission?

Thanks in advance.


Avatar
Opusti
Avatar
Niyas Raphy (Walnut Software Solutions)
Best Answer

Hi,

Try like this,

@api.depends('order_line.commission_line')
def _commission_amount(self):  
    for order in self:      
        comm_total = 0.0       
        for line in order.order_line:      
             comm_total += line.commission_line    
        order.update({'commission': comm_total })


Thanks

Avatar
Opusti
Avatar
lukondechitula@gmail.com
Best Answer

Try

@api.depends('order_line')
def _commission_amount(self):
for order in self:
comm_total = 0.0
for line in order.order_line:
comm_total += line.commission_line

Avatar
Opusti
Avatar
Ahmed Vahed
Best Answer

Neither of the above worked for me. I created a float variable x_studio_nett_untaxed_total_1 with Related field order_line.x_studio_nett_total - another field I created. It is only using the first line of the order as the total. I have tried both ways above.

Related Field : order_line.x_studio_nett_total

De[endencies : order_line.x_studio_nett_total, x_studio_nett_untaxed_total_1

Computed : 

@api.depends('order_line.x_studio_nett_total')

def _line_total(self) :

for order in self:

  line_total = 0.0

  for line in order.order_line:  

    line_total += line.x_studio_nett_total

  order.update({'x_studio_nett_untaxed_total_1':line_total})

Avatar
Opusti
Avatar
Michael Yeung
Best Answer

Sorry for off topic! @Niyas, you are the best! I applied the formula on the total discount for SO with computed field. Sharing for reference...

float field on sale.order.line, x_price_discount_amount;

float field on sale.order, x_price_discount_amount_total, depends=order_line.x_price_discount_amount

for record in self:
  discount_total = 0.0
  for line in record.order_line:  
    discount_total += line.x_price_discount_amount
  record['x_price_discount_amount_total'] = discount_total

It works! Thanks so much.

Avatar
Opusti
Related Posts Odgovori Prikazi Aktivnost
How to generate line numbers on quotes Solved
sale sale.order.line
Avatar
Avatar
1
jan. 25
4376
How to add freight charges to product cost in sale quoatation
sale sale.order.line
Avatar
Avatar
2
avg. 24
6420
What's the use of Allotment Partner in sale order line? Solved
sale sale.order.line
Avatar
Avatar
Avatar
Avatar
Avatar
6
dec. 22
9775
how to find out where the "record" is stored, in which file and part of the pyton?
sale sale.order.line record sale.order odoo10.0
Avatar
0
jul. 19
669
[odoo 10] How to set a product category field to the sale order line?
sale sale.order.line sale.order sales.order odoo10.0
Avatar
Avatar
Avatar
Avatar
6
feb. 19
10989