Skip to Content
This question has been flagged
sale.order.linesale.ordersalespriceproduct.templateOdoo17
4 Replies
1993 Views
Avatar
Victor Clausen

I am using Odoo 17.

I have added a button in the product.template model:


When clicked it triggers the "action_update_prices" method on all subscriptions with the product i have updated the price for so instead of going through all the subscriptions one at a time and updating the price i can just update it from the product itself. 


Everything is working as intended.

BUT. I discovered that if i create an invoice and then updates the price again it sets the price to 0 for ALL products in the sale.order.line. This is the default functionality standard to Odoo.


I don't want this functionality. Instead i want it to ignore if it has invoices and just keep the original functionality, so if i update the sales price on the product it should update the price on the sale.order.line on every subscription having that product

I hope it makes sense and there is a solution to add this feature.

Avatar
Discard
Avatar
Bay Forward Inc.
Best Answer

To overwrite the action_update_prices method, inherit the model in your custom module and redefine the method with your logic. Use super() to call the original method if needed.

Avatar
Discard
Avatar
TableConnect
Best Answer

Hello Victor, I was surprised to discover that price updates are not reflected in existing subscriptions, and while looking into this I came across your post here.
Could you please explain how you created the button that updates prices across all existing subscriptions?
Also, were you able to resolve this issue since your last post?
Thank you very much.


Avatar
Discard
Avatar
Manish Bohra
Best Answer

Hello Victor,


I think in that case you need to review the method which one is triggering  and you can inherit the method based on your conditions.


FYI: If you changes into odoo stranded method kindly review all the impact.


thanks.

Avatar
Discard
Victor Clausen
Author

That's basically the problem here. I don't know which method is being triggered, so I also don't know which method I should inherit. I was hoping for an answer that could tell me which method is causing the scenario I mentioned.

Victor Clausen
Author

Hello?

Avatar
Cybrosys Techno Solutions Pvt.Ltd
Best Answer

Hi,

In Odoo 17, subscriptions (sale.order with is_subscription = True) have protection logic once at least one invoice is posted.
If you trigger a price recomputation on subscription order lines after invoicing, Odoo may set price_unit to 0.0.
This is standard behavior intended to avoid inconsistencies between invoiced and uninvoiced periods.

In your case, you added a button on product.template to update prices on all subscriptions containing that product.
This works correctly until an invoice already exists.

Solution

Do not recompute the price.
Write price_unit directly on subscription lines.

This bypasses the invoice protection logic while keeping existing invoices unchanged.

Button method on product.template:

def action_update_prices(self):
    self.ensure_one()

    lines = self.env['sale.order.line'].search([
        ('product_id', '=', self.product_variant_id.id),
        ('order_id.is_subscription', '=', True),
        ('order_id.state', 'in', ['sale', 'done']),
    ])

    lines._force_update_subscription_price(self.list_price)

Helper method on sale.order.line:

from odoo import models

class SaleOrderLine(models.Model):
    _inherit = 'sale.order.line'

    def _force_update_subscription_price(self, new_price):
        for line in self:
            line.write({
                'price_unit': new_price,
            })



Hope it helps

Avatar
Discard
Related Posts Replies Views Activity
Triggering "action_update_prices" method sets prices in pricelist to 0 if sale.order has invoices
sale.order.line sale.order priceslist product.template odoo17
Avatar
1
सित॰ 24
2322
Merge Same Item in Sale Order Line Solved
sale.order.line sale.order
Avatar
Avatar
Avatar
2
जन॰ 24
6597
Combine inline editing with more detailed form view
sale.order.line sale.order
Avatar
0
जून 23
3014
ValueError: <class 'ValueError'>: "Expected singleton: sale.order.line(<NewId ref='virtual_117'>, <NewId ref='virtual_131'>)"
sale.order.line sale.order
Avatar
Avatar
1
दिस॰ 22
4470
How to update a custom field as "Margin" default from sale.order does, when some product of sale.order.line is updated/deleted.
sale.order.line sale.order
Avatar
0
अप्रैल 22
3463