Community mailing list archives

community@mail.odoo.com

Re: OCA and Merge proposal

by
YannickB
- 11/21/2014 10:54:10
Perfect! Thank you.

I think this link would be very useful in http://odoo-community.org/page/website.how-to, this way more members of the community will go check the MP.

I suggest the following modification :

Meaning "If there are enough reviewers, all problems are easy to solve". Eric S. Raymond has written influentially about peer review in software development: http://en.wikipedia.org/wiki/Software_peer_review.

You can see the whole list of Merge Proposals awaiting reviews in this page : https://github.com/pulls?user=OCA

Please respect a few basic rules:


What do you think?

Le 21/11/2014 15:57, Leonardo Pistone a écrit :
<blockquote cite="mid:CAATsmLFe+GKB58W=wM_tyDGjt87Ss7WhERahEccEfEPEHp7A+g@mail.gmail.com" type="cite">
Hi Yannick.

You can see all pull requests for OCA at https://github.com/pulls?user=OCA .

Anyone can review. It is up to the committers to take the decision to
merge at the end. It could in theory happen that a committer for some
reason does not trust a review, but I've never been in such a
situation so far.

On Fri, Nov 21, 2014 at 2:52 PM, Yannick Buron <yannick.buron@gmail.com> wrote:
> Hello everyone,
>
> Some question regarding the OCA process :
>
> Do we have any place where we can see all merge proposals waiting review in
> the OCA? Or do we have to go to each repo to see if a merge proposal is
> pending?
>
> Also, who can be reviewer? I don't think being an OCA member is asked so
> what is the skill required so someone can be considered skilled enough to
> review a merge proposal? This is especially important for me since people
> around me for Community verticalisation are still beginner in Odoo, and the
> lack of reviewer may slow the project.

_______________________________________________
Mailing-List: https://www.odoo.com/groups/community-59
Post to: mailto:community@mail.odoo.com
Unsubscribe: https://www.odoo.com/groups?unsubscribe