Community mailing list archives

community@mail.odoo.com

Re: Proposal to review the OCA contribution guidelines

by
Apertoso, Jos De Graeve
- 08/13/2014 09:05:05
Hello all,

I certainly agree that not a single customer is interested in a PEP8
compliant solution.  However, when an issue in the module surfaces, a
customer expects you to fix it, even if it's not your module.  Having
a clean code base will certainly help you to get the issue fixed and
help your customer.

If a clean code base requires PEP8 compliance we should stick to that.

Anything we lose in the short term by refusing contributions should be
gained in the long term by easing maintainability.  In any large
software project, maintainability is the hard part so we must keep
that in mind.

However, the point that Luc raises is valid indeed. If a lot of code
is being published outside of oca there will be no gain in
maintainability at all.  We always should consider restrictions very
carefully.

Regards,
Jos

-- 
Jos De Graeve - Apertoso business ICT

http://www.apertoso.be/

Guido Gezellelaan 16 - B-9800 Deinze - Belgium

Direct: +32 9 381 64 51
General:+32 9 381 64 50
Mobile: +32 475 54 68 80
mail/im/skype: Jos.DeGraeve@apertoso.be - apertoso