Community mailing list archives

community@mail.odoo.com

Re: Unexpected diffrences between Odoo Enterprise and Odoo Community interfaces

by
Jerome Sonnet
- 04/23/2016 15:39:23
Hello,

Thanks for your answer. 

I really don't want to enter the discussion whether or not Odoo should do something about it, I hope they will take this kind of feedback seriously and do their best to keep the Community version as clean as possible.

Can you be more specific as why my design is wrong ? Google provides a JS API that works quite well and I don't see why I should go through the server in order to do this ? I am actually using the ir_attachement ORM, but when I do have to URL and the name to use, see [1].

Using the CSS class as an anchor is a pattern used in the official code, see [2], so I agree with you this is an ugly way to anchor behavior but it is the one available for now... 

Then OK, I should provide a PR to add a proper anchor, but my question is more general on how to make this the best way... and I will be very interested on more details on your point of view about my design.

Taking the module to OCA is on my TODO list... would be more than happy to contribute.

Best regards,

Jerome






On 23 April 2016 at 20:14, Nhomar Hernandez <nhomar@vauxoo.com> wrote:

On Tue, Apr 19, 2016 at 5:33 AM, Jerome Sonnet <jerome.sonnet@be-cloud.be> wrote:
I suppose you understand there is not copyright or commercial issue here, it is a pure technical discussion as how to make this work or if we must expect to make two versions of most of our work.

Technically:

You need to select properly your placeholder, if you use a placeholder which is used for css look and feel this will be for sure broken.

If this is not the case then may be it can be considered a wrong approach technically from odoo.

In yous specific case:

Did you know that ir.attachment module has an api to make the CRUD on documents on server side?.[1]

I see you module is working on JS side (and that's incorrect AFAICU), you have an api that allow the document itself be reviewed by the ORM without jump the ORM is not good functional, technically speaking.

I mean even if it is true that some point will not be compatible between versions (And odoo should explain itself in that matter BTW) on this case specifically your design is the wrong one not the fact that Odoo called differently a css placeholder to for look and feel.

To avoid this bad approaches I strongly recommend to you put the module under OCA repositories maybe this should give you ebst comments at PR time and not At publishing time we are a lot of people taking this decisions day by day there helping each others.[2] An you have lot of examples there.

I hope it helps you.

Regards.


--
Nhomar Hernandez
CEO Vauxoo.
Twitter: @nhomar
Odoo Gold Partner
Skype: nhomar00 (Envia mail previo no lo superviso siempre).
Móvil Venezuela:
+58 4144110269
Móvil México:
+52 1 4773933942

_______________________________________________
Mailing-List: https://www.odoo.com/groups/community-59
Post to: mailto:community@mail.odoo.com
Unsubscribe: https://www.odoo.com/groups?unsubscribe