Community mailing list archives

community@mail.odoo.com

Re: v9 is there!

by
Antony Lesuisse (al)
- 09/24/2015 14:28:28
- Remove unnecessary simplejson dependency (#6940)
- Remove unnecessary unittest2 dependency (#6941)

Ok @mat you can merge them.

Not sure about the yml one because i would like to deprecate yml test because 
there are very hard to debug. Once we will merge onchange and compute mecanism 
(planned for v10) there will be no advantage to use yml instead of python/xml.

On 09/24/2015 07:19 PM, Leonardo Rochael Almeida wrote:
> Hi Fabien,
>
> On 23 September 2015 at 18:23, Fabien Pinckaers <fp@odoo.com
> <mailto:fp@odoo.com>> wrote:
>
>         [...] But the good news is that nearly all bugs that are reported to
>         our support is fixed in around one day. So, even if you discover a
>         bug, we fix in one open day. So, this should not be a problem.
>
>
> That's good to know!
>
> During the last Odoo Days, I submitted 3 Pull Requests fixing bugs in Odoo v8,
> which are still present in v9. They received close to no attention:
>
>   * YAML: fix import of reference field and `!menuitem` tag (#6985
>     )
>   * Remove unnecessary simplejson dependency (#6940
>     )
>   * Remove unnecessary unittest2 dependency (#6941
>     )
>
> The only input I got was on the last one, and it was unfairly closed, IMO, as
> being too little benefit for the risk.
>
> But the only possible risk comes from removing unittest2 from
> `requirements.txt`, if a third party module imports unittest2 assuming it is
> installed.
>
> In this case, only the testing of the module will fail with a very clear
> ImportError, easily fixed by renaming the import. This failure would only ever
> happen at exactly the right time it should happen: during the test run.
>
> For the last two pull requests, some might argue that removing dependencies
> that were replaced by stdlib packages is not exactly bug fixing. I disagree:
>
> Every unnecessary line of code is a liability, since it is a place that can
> contain bugs.
>
> Every unneeded module increases (even if just a little) the memory and storage
> footprint of Odoo itself.
>
> But most importantly, every automated test run of every Odoo installation is
> slowed down a little bit installing and loading the unnecessary libraries, and
> this is a loss that accumulates over time.
>
> Best Regards,
>
> Leo
>
> _______________________________________________
> Mailing-List: https://www.odoo.com/groups/community-59
> Post to: mailto:community@mail.odoo.com
> Unsubscribe: https://www.odoo.com/groups?unsubscribe
>