Community mailing list archives

community@mail.odoo.com

Re: Usability/design in relation to res.partner

by
Graeme Gellatly
- 08/17/2015 21:02:04
Also for this part you are misunderstanding how address types work.

Also, in onchange_partner_id in sale module, it does a select for [contact, delivery, invoice], but it does not work correctly. It always selects the partner id as invoice and delivery if the only address type available is contact. Contact addresses are not populated unless you select them.

That behaviour is entirely correct.  A contact is not a delivery address, it is not an invoice address and it is not a default address.  If none of those exist it will go to the default address which is the main partner in this case.  Otherwise you would set your contact as default, but in b2c aside from multiple delivery addresses I can't see the case for having any contacts at all.  In B2B I don't see the case for invoices going to multiple addresses or for a purchasing contact to receive a tonne of coal at his desk.

But anyway, those methods haven't changed a great deal in the last 5 years, despite the model change, and they are pretty easily accessible and extensively customised.  I've never known two people in the same organisation to want the same partner view, let alone two organisations.  Better to be easily extensible than rigid with a model that doesn't fit a lot of people.  When they released the model I must admit I wasn't happy, so I got out Martin Fowler's book from the library to see how to do it better.  For the most part I couldn't, though that's not to say the views and methods couldn't be improved.

On Tue, Aug 18, 2015 at 12:33 PM, OpenERP Master <openerpmaster@gmail.com> wrote:
Hello,

I wanted to share my dissatisfaction in respect to res.partner.

Why is there not a firstname, lastname field. This is very standard in a lot of software, It is important to have them separate, especially when working with external software that require these fields independently. You end up having to do something stupid like separate on spaces which doesnt work well.

The way addresses are retrieved seems horrendous. Can someone justify this method as is?
https://github.com/odoo/odoo/blob/8.0/openerp/addons/base/res/res_partner.py#L735

Why not implement ability to assign a default. This way would produce random defaults.
Also, in onchange_partner_id in sale module, it does a select for [contact, delivery, invoice], but it does not work correctly. It always selects the partner id as invoice and delivery if the only address type available is contact. Contact addresses are not populated unless you select them.

In sale module when selecting invoice/delivery address there is no filtering based on the selected partner. It shows all partners. You would allow business users to select accidentally an address that does not even belong to the person you are billing/shipping goods. There may be a case to allow this, but probably most b2c users would not want to allow this.

In base partner view the contact view is embedded inside the partner default form view. If you want to customize this very important view, you make it more difficult than it has to be.

There are a few more pain points here, but seriously I have trouble understanding this functionality. IMO its broken.

_______________________________________________
Mailing-List: https://www.odoo.com/groups/community-59
Post to: mailto:community@mail.odoo.com
Unsubscribe: https://www.odoo.com/groups?unsubscribe