Community mailing list archives

community@mail.odoo.com

Re: odoo-dev team merge pull request is too slow.

by
Martin Trigaux (mat)
- 05/05/2015 11:10:06
Hello Jeffery,

Sorry it takes time to process, there is many requests and few people to
do so but we are aware of the issue and are working on it.
However there is some things you can do to have a good PR and improve
your chances we check it.
All of these are in contributing guidelines
(https://github.com/odoo/odoo/wiki/Contributing ) but some important points:

1. detail *why* you are making a change, not *what*. Explain why do you
think the current code is wrong and why it should be changed (e.g.
business reasons)
2. explain how to reproduce your bug (step by step). Searching 20m
before being able to reproduce it makes the test harder.
3. do not create an issue if you create a PR. These are mostly the same
on github and you can make a detailed bug description in the PR.
4. try to keep the diff minimal, do not include PEP8 changes as it make
the diff harder to read

Martin

On 05/05/15 16:18, Jeffery wrote:
> have commit some bug fix and feature improvements so many days ago, but
> still have not been reviewed.
> 
> where have the code merge process, then i should follow that to speed up
> the code merge. 
> 
> thanks.
> 
> -- 
> Jeffery        -odoo expert form kunshan, suzhou, china
> 
> _______________________________________________
> Mailing-List: https://www.odoo.com/groups/community-59
> Post to: mailto:community@mail.odoo.com
> Unsubscribe: https://www.odoo.com/groups?unsubscribe
> 

-- 
Martin Trigaux
Odoo (Formerly OpenERP)

Chaussée de Namur, 40
1367 Grand-Rosière
Tel: +32 81 81 37 00
http://odoo.com