Community mailing list archives
Re: broken Travis builds in OCA repositoriesby
Camptocamp SA, Nicolas Bessi
I think we have here a nice topic to be discussed during OCA meetup in Odoo days :).
I guess we should try to address this issue is directly in the core of Odoo in a correct manner.
We should also include Odoo dev team in this topic because it's a problem they are going to encounter with
the new app store.
Fabien and Anthony if you hear me... your welcome to join ;)
2015-03-25 10:17 GMT+01:00 Stefan <email@example.com>:
On 25-03-15 08:32, Alexandre Fayolle wrote: > Hello everyone, > > Following the introduction of > https://github.com/OCA/maintainer-quality-tools/issues/105 in maintainer > quality tools, some branch and PR builds have been failing. > > This is caused by external dependencies being imported by some addons > without a try...except block in a file which is imported at instance > startup, which is a bug in that module. Likely a couple of offending > addons are causing a large number of unrelated failures. > > I will make the required PRs and fixes today if noone beats me to it. > Apologies for the inconvenience. Hi Alexandre, thank you for picking this up. When we encountered this in the past, our solution was to import the external dependency locally in the methods themselves. This preserves the clear runtime error mentioning the missing dependency. Would you consider this solution instead of catching ImportError at the top of the modules? Cheers, Stefan -- Therp - Maatwerk in open ontwikkeling Stefan Rijnhart - Ontwerp en implementatie mail: firstname.lastname@example.org tel: +31 (0) 614478606 web: http://therp.nl