Community mailing list archives

community@mail.odoo.com

Re: broken Travis builds in OCA repositories

by
Stefan Rijnhart
- 03/25/2015 05:13:00
On 25-03-15 08:32, Alexandre Fayolle wrote:
> Hello everyone,
>
> Following the introduction of
> https://github.com/OCA/maintainer-quality-tools/issues/105 in maintainer
> quality tools, some branch and PR builds have been failing.
>
> This is caused by external dependencies being imported by some addons
> without a try...except block in a file which is imported at instance
> startup, which is a bug in that module. Likely a couple of offending
> addons are causing a large number of unrelated failures.
>
> I will make the required PRs and fixes today if noone beats me to it.
> Apologies for the inconvenience.

Hi Alexandre,

thank you for picking this up. When we encountered this in the past, our
solution was to import the external dependency locally in the methods
themselves. This preserves the clear runtime error mentioning the
missing dependency. Would you consider this solution instead of catching
ImportError at the top of the modules?

Cheers,
Stefan


-- 
Therp - Maatwerk in open ontwikkeling

Stefan Rijnhart - Ontwerp en implementatie

mail: stefan@therp.nl
tel: +31 (0) 614478606
web: http://therp.nl