Community mailing list archives

community@mail.odoo.com

Re: Module for Odoo v8

by
Kevin.McMenamin
- 03/04/2015 14:43:49
We have actually ported the printscreen module to V8 as zesty seems to have lost interest. Can we propose it gets merged back in - happy to share.

Kevin McMenamin
ERP Capability Manager

Mobile  +64 22 651 3753
Phone  +64 9 977 5805
Email   kevin.mcmenamin@solnet.co.nz

Solnet Solutions Limited
Level 19, Crombie Lockwood
191 Queen Street, Auckland 1010
PO Box 6619, Auckland 1141

www.solnet.co.nz  




From:        Leonardo Pistone <lpistone@gmail.com>
To:        "Community" <community@mail.odoo.com>,
Date:        04/03/2015 11:18 p.m.
Subject:        Re: Module for Odoo v8





On Fri, Jan 9, 2015 at 5:32 PM, Kristian Koci <kristian.koci@gmail.com> wrote:
> Will this do exactly the same?

last time I checked, in 2013, I had found that the zesty printscreen
module was actually a copy of what is now
https://github.com/OCA/web/tree/8.0/web_export_view, at the time
ported from openerp 6.1 to 7.0, with all attribution and copyrights
removed (i.e. stolen). At the time I posted to zesty's blog advising
to fix the situation, with no response. My comment is still online at
http://zbeanztech.com/blog/printscreen-openerp-7?page=2 . I'll copy it
here anyway.

----
Submitted by Leonardo Pistone (not verified) on Thu, 05/30/2013 - 13:48

Thanks for your post. This module is actually an improvement over
web_export_view, a module that is already in the new openerp community
branches.

That module was for OpenERP 6.1 only, so it is great you ported it to OpenERP 7.

However, compare the main JS file in web_export_view

http://bazaar.launchpad.net/~webaddons-core-editors/web-addons/6.1/view/head:/web_export_view/static/js/web_advanced_export.js

to the corresponding web_printscreen/static/js/web_printscreen.js

It is basically the same code with copyright notices removed (same
code, variables, indentation etc.)

I would suggest posting a merge proposal of your work to the 7.0
branch of the community web-addons:

https://code.launchpad.net/~webaddons-core-editors/web-addons/7.0

Of course you can acknowledge your work in the AUTHORS file.

Thanks!

_______________________________________________
Mailing-List: https://www.odoo.com/groups/community-59
Post to: mailto:community@mail.odoo.com
Unsubscribe: https://www.odoo.com/groups?unsubscribe

Attention: This email may contain information intended for the sole use of the original recipient. Please respect this when sharing or disclosing this email's contents with any third party. If you believe you have received this email in error, please delete it and notify the sender or postmaster@solnetsolutions.co.nz as soon as possible. The content of this email does not necessarily reflect the views of Solnet Solutions Ltd.