Community mailing list archives

Re: git mailmap, CLA and blame, license

by afayolle <> - 02/10/2015 11:40:38
Hello Lionel

From what I understand of all these things, but to be on the safe side:

import ianal  # for a real advice, ask lawyer

The Odoo CLA allows Odoo s.a. to relicense from AGPL to LGPL without getting explicit approval from all people who once contributed to the core, provided all these contributors do sign the CLA (otherwise they will have to remove the contributions first). Thats the point 2 of the CLA.

In the same way, since there is no precision / restriction in the CLA, Odoo s.a. will be able to relicense should it choose to do so under any other license, including a closed source license, in the future. For all we know, there may never be an LGPL version of Odoo, and we have to trust them to no go evil.

Side note: the CLA of the OCA is more precise, and restricts the licenses under which our contributors allow the association to relicense their contributions to the OSI (Open Source Initiative) approved licenses.


On 10/02/2015 16:55, Lionel Sausin wrote:
<blockquote cite="" type="cite">
What does the CLA grant that the LGPL doesn't already grant?
Is it in the "sublicensing", like it would allow Odoo SA to integrate the contribitions in non-LGPL work?
Not that I have an opinion for or against that, I just like to understand what I sign.

Le 10/02/2015 09:17, Joël Grand-Guillaume a écrit :
<blockquote cite="" type="cite">
Thanks Anthony to take the time to clarify all this, it is very much appreciated that you make it properly (and I know it's a boring taks).

On Sun, Feb 8, 2015 at 3:16 PM, Antony Lesuisse <> wrote:
In the past Openerp SA was strongly criticized for neglecting legal aspect of 
copyright and code ownership. I'm sorry for that. This time we want to make 
things perfectly clean and thorough.

About CLA:

Friday with Olivier Dony did setup a CLA process. Everything is explained here.

I created a runbot module to check the cla.

About mailmap:

This week-end i attacked myself to the daunting task of code attribution the 
goal is to identify every line of master HEAD (and maybe 8.0 HEAD).

The benefits is that we will get a perfectly clean "git blame" and "git 
shortlog -nse".

You can check my work here:

Script to generate it:

Git mailmap file

If you have any suggestion or correction about the mailmap file, contact me or 
make a pull request on my branch. Once the mailmap file is complete we will 
merge it into master.

Why are they so few external code contributors 3% ?

- Odoo: framework + ALL addons + web client and website is only 150k lines of 
code. The same size as django (which only a framework).

- Because Odoo is a good framework, it very modular so that developpers 
prefers creating their own module and extend it instead of patching the addons 
code. Only when it's not possible people makes patch to change the core.

- We get bugfixes and typos but it's only a few lines. And usually bugfixes 
are rewritten to cover all the use cases.

- We often rewrite bug chunk of code:

   - new qweb report (all rewritten),
   - new wms (all rewritten)
   - new api (many lines rewrite, all is expected to be converted).
   - new accounting (all rewritten, in progress)

- There might be error or misattribution i'm waiting for your feedback.

Why are they so few external xml contributors 20% ?

I excpect it's more than that. We need the carefully check all l10n_* commits. 
However in master we will rewrite every l10n module as part of our new 
accouting system.

Why are they so MANY po contributors ?

Translation takes the most diskspace of the repository and it's almost 99% 
community contributed. Dont forget that.

About License:

The offcial statement of Odoo has been published on the website. My personnal 
belief (as antony not Odoo) is a that a switch to LGPL is very much welcome as 
wee moved from an ERP to and ERP and Web framework.

- Odoo may now become a web framework, along django, rails etc... Companies 
and developers will only consider investing on a platform that protects their 
intellectual property.

- Partners and community members MAY become ISV instead of beeing service 
providers only. Some of them already do and it's a grey area. It's now easily 
possible and encouraged. Nobody is forced to change anything we keep the best 
of both world.

- We hope to attract theme and graphic designer to the platform like other 
open source cms/e-commerce (wordpress, drupal, joomla, magento, prestashop ...).

It's very exciting time for Odoo.

Post to:



Joël Grand-Guillaume
Division Manager
Business Solutions

+41 21 619 10 28

Post to: