Community mailing list archives

community@mail.odoo.com

Re: discussion on make to order changes in v8

by
OpenERP Master
- 01/05/2015 15:54:36
Perhaps I jumped a little too soon. I can see that a move make to order vs a product being set to make to order are two different things. My mistake.

However, on the point of make to order record, IMO it should still be something static, users could create another mto order something, but the built in functionality not be changeable.

On Mon, Jan 5, 2015 at 2:48 PM, OpenERP Master <openerpmaster@gmail.com> wrote:
Hello,

My2cents is that the way make to order routes is handled in v8 is a little silly, well stupid. Make to Order is a core functionality in this software, however it is initialized in the database as a record that can be easily deleted by a user. Certain functions in modules DEPEND on that record having an exact value. By allowing the records deleting, any administrator could corrupt the systems core functionality.

There is an obvious point to be made by someone simply to not delete it, but I don't agree that this should even be possible. I like the concept of being able to create routes, but IMO if you hard code a value in any module, therefore, it should NOT be able to be removed.

Example:
https://github.com/odoo/odoo/blob/8.0/addons/stock/stock.py#L2116

Also, the system tries to "figure out" if something is make to order in different ways.

Example again:
https://github.com/odoo/odoo/blob/8.0/addons/stock/stock.py#L2116

And in sale stock:
https://github.com/odoo/odoo/blob/8.0/addons/sale_stock/sale_stock.py#L285

This not to mention that product_obj variable is declared twice. I think this is really sloppy work, my opinion only.