Community mailing list archives

community@mail.odoo.com

Re: Who have write access to l10n-switzerland

by
Camptocamp SA, Guewen Baconnier - Software Developer, Camptocamp
- 12/16/2014 07:57:31
On 12/16/2014 01:36 PM, SébastienGendre wrote:
> Hello.
> 
> Who have write access to l10n-switzerland repository on Github?
> 
> Our pull request (#66) seems to be OK, it wait to be merged to this
> repository.
> 
> 
> Regards
> 
> Sébastien Gendre
> Développeur OpenERP
> 
> Open Net Sàrl
> www.open-net.ch 
> 59, Rue de l'industrie
> 1030 *Bussigny*
> T: +41 (21) 701 42 45


Hi,

The rules for committers of the OCA are that a PR must have at least be
approved by 2 people (and have been submitted 5 days ago, with a
possible fast-track if there is 3+ approvals).

I didn't reviewed this PR myself, but I see at least one unanswered
question:
https://github.com/OCA/l10n-switzerland/pull/66#issuecomment-66451768

I observed that reviewers with a technical profile are often reluctant
to review Pull Requests when the thread has unanswered functional
questions, quite rightly, because they don't want to merge something
correct technically but wrong functionally. Being myself a developer, I
can attest this is what holds me to review this PR.

I suggest you to answer to the open questions. Once the functional
points are cleared, I undertake to review and merge it as soon as it
gets 2 approvals.

-- 
Guewen Baconnier
Business Solutions Software Developer

Camptocamp SA
PSE A, CH-1015 Lausanne
Phone: +41 21 619 10 39
Office: +41 21 619 10 10
http://www.camptocamp.com/