Skip to Content
This question has been flagged
passwordauthentication
2 Replies
11129 Views
Avatar
HIGHCO - Nicolas Clavier

On the topic of clear text authentication, I notice that the browser's local storage (not cookies ahun) has records with : - key: Database_name``|last_password - value:PasswordInClearText`

If concerned by security, this could be a potential issue regarding access to openerp from public computers. I doubt an average user would know how to clear local storage after using a public computer for quick access to his platform.

How can we disable this functionality to get back to normal authentication / session expiry scheme ? (or am I missing something ??)

Avatar
Discard
HIGHCO - Nicolas Clavier
Author

Bump ! This is a potential major issue imho..

HIGHCO - Nicolas Clavier
Author

After reading last initOS comment, I realised this could be a vulnerability and decided to report a security bug in lauchpad (private for now). I will post feedback here. Thank you.

Avatar
Nicolas Vanhoren (niv)
Best Answer

That was a feature that was useful for development (which is why it only worked in debug mode, not the normal user mode). But as I can see it is broken in recent versions. Since no one seems to complain about this, I decided it was cleaner to simply remove it in recent versions.

But please understand it is never safe to use a web site with a log in feature, including OpenERP, from a public computer. You have no guarantee that you session will expire so anyone can re-use it and do what he wants with your account. That's why you should train your users to always use the anonymous mode in such cases.

Avatar
Discard
HIGHCO - Nicolas Clavier
Author

You mean you are part of the core team and you removed the password storage from newer revisions on ?

HIGHCO - Nicolas Clavier
Author

As to the public use, an internal user might do as much damage. We have developers amongst the users here... Anyway,could you point me to the revision that removes this hack ?

Avatar
Torsten Francke
Best Answer

if you search in the code, you find: 

if (self.session.debug) {
     self.$("[name=password]").val(localStorage.getItem(self.selected_db + '|last_password') || '');
}

in addons/web/static/src/js/chrome.js

This if you have web modul debug mode enable, just disable:

http://maheshwarimayur.blogspot.de/2013/01/debug-mode-in-openerp-70-web-client.html

and then everythink is fine.

Avatar
Discard
HIGHCO - Nicolas Clavier
Author

Thanks for pointing out the source of this issue. I still consider the issue quite critical since there is no rule to give users access or not to "debug mode“. Therefore the "demo" user (or anyone else) can use debug mode, and simply leave his credentials on a computer. Even though it sounds far fetched, security as for long relied on the eventuality that no one would dig further ...

Torsten Francke

I see the problem you can send someone a prepared link with "&debug=" inside the url to activate the debug mode and later with some injection capture the password. The best way to fix problems open a ticket to support(at)openerp.com that it should be possible to deactivate debug mode in production environment

Related Posts Replies Views Activity
How to login odoo passwordlessly with single url?
password authentication
Avatar
Avatar
1
Jul 25
2081
Password Reset Link redirect to account.odoo.com
password
Avatar
0
May 25
2586
How to recover master password if I forgot it? Solved
password
Avatar
Avatar
Avatar
Avatar
Avatar
13
Sep 24
196627
Database specific Master password - does it exist? Solved
password
Avatar
Avatar
2
Jul 24
13997
AssertionError: The ID refers to an uninstalled module Solved
authentication
Avatar
Avatar
1
Sep 23
7227