Skip to Content
Odoo Menu
  • Sign in
  • Try it free
  • Apps
    Finance
    • Accounting
    • Invoicing
    • Expenses
    • Spreadsheet (BI)
    • Documents
    • Sign
    Sales
    • CRM
    • Sales
    • POS Shop
    • POS Restaurant
    • Subscriptions
    • Rental
    Websites
    • Website Builder
    • eCommerce
    • Blog
    • Forum
    • Live Chat
    • eLearning
    Supply Chain
    • Inventory
    • Manufacturing
    • PLM
    • Purchase
    • Maintenance
    • Quality
    Human Resources
    • Employees
    • Recruitment
    • Time Off
    • Appraisals
    • Referrals
    • Fleet
    Marketing
    • Social Marketing
    • Email Marketing
    • SMS Marketing
    • Events
    • Marketing Automation
    • Surveys
    Services
    • Project
    • Timesheets
    • Field Service
    • Helpdesk
    • Planning
    • Appointments
    Productivity
    • Discuss
    • Approvals
    • IoT
    • VoIP
    • Knowledge
    • WhatsApp
    Third party apps Odoo Studio Odoo Cloud Platform
  • Industries
    Retail
    • Book Store
    • Clothing Store
    • Furniture Store
    • Grocery Store
    • Hardware Store
    • Toy Store
    Food & Hospitality
    • Bar and Pub
    • Restaurant
    • Fast Food
    • Guest House
    • Beverage Distributor
    • Hotel
    Real Estate
    • Real Estate Agency
    • Architecture Firm
    • Construction
    • Estate Management
    • Gardening
    • Property Owner Association
    Consulting
    • Accounting Firm
    • Odoo Partner
    • Marketing Agency
    • Law firm
    • Talent Acquisition
    • Audit & Certification
    Manufacturing
    • Textile
    • Metal
    • Furnitures
    • Food
    • Brewery
    • Corporate Gifts
    Health & Fitness
    • Sports Club
    • Eyewear Store
    • Fitness Center
    • Wellness Practitioners
    • Pharmacy
    • Hair Salon
    Trades
    • Handyman
    • IT Hardware & Support
    • Solar Energy Systems
    • Shoe Maker
    • Cleaning Services
    • HVAC Services
    Others
    • Nonprofit Organization
    • Environmental Agency
    • Billboard Rental
    • Photography
    • Bike Leasing
    • Software Reseller
    Browse all Industries
  • Community
    Learn
    • Tutorials
    • Documentation
    • Certifications
    • Training
    • Blog
    • Podcast
    Empower Education
    • Education Program
    • Scale Up! Business Game
    • Visit Odoo
    Get the Software
    • Download
    • Compare Editions
    • Releases
    Collaborate
    • Github
    • Forum
    • Events
    • Translations
    • Become a Partner
    • Services for Partners
    • Register your Accounting Firm
    Get Services
    • Find a Partner
    • Find an Accountant
    • Meet an advisor
    • Implementation Services
    • Customer References
    • Support
    • Upgrades
    Github Youtube Twitter Linkedin Instagram Facebook Spotify
    +1 (650) 691-3277
    Get a demo
  • Pricing
  • Help

Odoo is the world's easiest all-in-one management software.
It includes hundreds of business apps:

  • CRM
  • e-Commerce
  • Accounting
  • Inventory
  • PoS
  • Project
  • MRP
All apps
You need to be registered to interact with the community.
All Posts People Badges
Tags (View all)
odoo accounting v14 pos v15
About this forum
You need to be registered to interact with the community.
All Posts People Badges
Tags (View all)
odoo accounting v14 pos v15
About this forum
Help

float_compare validation fails for standard_price in custom module due to decimal precision

Subscribe

Get notified when there's activity on this post

This question has been flagged
Decimal-precisionodoo15
3 Replies
892 Views
Avatar
Uday

I added a constraint on standard_price in my custom module to prevent zero or negative values:

@api.constrains('standard_price') def _check_standard_price(self): price_unit_prec = self.env['decimal.precision'].precision_get('Product Price') for rec in self: if float_compare(rec.standard_price, 0.0, precision_rounding=price_unit_prec) < 1: print("_check_standard_price", rec.standard_price) raise ValidationError(_('Invalid Cost Price.'))

Problem:

Entering 1 triggers a ValidationError, even though it’s positive. My debug prints show:

float_compare rounding_factor 3 value1 0.0 value2 0.0 delta 0.0 float_is_zero epsilon 3 _check_standard_price 1.0

Analysis:

  • price_unit_prec comes from Decimal Accuracy → Product Price (3 in my case).
  • Odoo rounds using float_round(value, rounding_factor), so 1 gets rounded to 0.0 and fails the check.
  • Changing Decimal Accuracy to 2 makes it work correctly (1 → 1.00).
0
Avatar
Discard
Avatar
Cybrosys Techno Solutions Pvt.Ltd
Best Answer

Hi,

You need to convert precision (digits) into a rounding factor.

Code:

from odoo.tools import float_compare


@api.constrains('standard_price')

def _check_standard_price(self):

    price_unit_prec = self.env['decimal.precision'].precision_get('Product Price')

    rounding = 10 ** (-price_unit_prec)   # convert digits → factor

    for rec in self:

        if float_compare(rec.standard_price, 0.0, precision_rounding=rounding) <= 0:

            raise ValidationError(_('Invalid Cost Price.'))


Hope it helps


1
Avatar
Discard
Avatar
Arva M. Dhilla
Best Answer

 Hi,

You’re passing the wrong value into float_compare. precision_get('Product Price') returns digits (e.g. 3), but float_compare expects a rounding factor (e.g. 0.001). Convert it with rounding = 10 ** -digits and use that in precision_rounding. That way 1.0 won’t get rounded to 0 and your validation will work correctly.

1
Avatar
Discard
Avatar
Codesphere Tech
Best Answer

Hello Uday, 
I hope this is helpful for you.
Source: Odoo 19

@api.onchange('standard_price')

def _onchange_standard_price(self):

    if self.standard_price < 0:

        raise ValidationError(_("The cost of a product can't be negative."))

1
Avatar
Discard
Enjoying the discussion? Don't just read, join in!

Create an account today to enjoy exclusive features and engage with our awesome community!

Sign up
Related Posts Replies Views Activity
Error install web_responsive in odoo 15
odoo15
Avatar
0
Sep 24
1742
Create a button next to the chat one or activities
odoo15
Avatar
Avatar
1
Jun 24
2127
I can't import reordering rules other company
odoo15
Avatar
Avatar
1
May 24
2282
one2many search widget
odoo15
Avatar
Avatar
Avatar
Avatar
3
May 24
2441
decimal problem
Decimal-precision
Avatar
0
Jul 22
2938
Community
  • Tutorials
  • Documentation
  • Forum
Open Source
  • Download
  • Github
  • Runbot
  • Translations
Services
  • Odoo.sh Hosting
  • Support
  • Upgrade
  • Custom Developments
  • Education
  • Find an Accountant
  • Find a Partner
  • Become a Partner
About us
  • Our company
  • Brand Assets
  • Contact us
  • Jobs
  • Events
  • Podcast
  • Blog
  • Customers
  • Legal • Privacy
  • Security
الْعَرَبيّة Català 简体中文 繁體中文 (台灣) Čeština Dansk Nederlands English Suomi Français Deutsch हिंदी Bahasa Indonesia Italiano 日本語 한국어 (KR) Lietuvių kalba Język polski Português (BR) română русский язык Slovenský jazyk slovenščina Español (América Latina) Español ภาษาไทย Türkçe українська Tiếng Việt

Odoo is a suite of open source business apps that cover all your company needs: CRM, eCommerce, accounting, inventory, point of sale, project management, etc.

Odoo's unique value proposition is to be at the same time very easy to use and fully integrated.

Website made with

Odoo Experience on YouTube

1. Use the live chat to ask your questions.
2. The operator answers within a few minutes.

Live support on Youtube
Watch now