Skip to Content
Odoo Menu
  • Log ind
  • Prøv gratis
  • Apps
    Økonomi
    • Bogføring
    • Fakturering
    • Udgifter
    • Regneark (BI)
    • Dokumenter
    • e-Signatur
    Salg
    • CRM
    • Salg
    • POS Butik
    • POS Restaurant
    • Abonnementer
    • Udlejning
    Hjemmeside
    • Hjemmesidebygger
    • e-Handel
    • Blog
    • Forum
    • LiveChat
    • e-Læring
    Forsyningskæde
    • Lagerbeholdning
    • Produktion
    • PLM
    • Indkøb
    • Vedligeholdelse
    • Kvalitet
    HR
    • Medarbejdere
    • Rekruttering
    • Fravær
    • Medarbejdersamtaler
    • Anbefalinger
    • Flåde
    Marketing
    • Markedsføring på sociale medier
    • E-mailmarketing
    • SMS-marketing
    • Arrangementer
    • Automatiseret marketing
    • Spørgeundersøgelser
    Tjenester
    • Projekt
    • Timesedler
    • Udkørende Service
    • Kundeservice
    • Planlægning
    • Aftaler
    Produktivitet
    • Dialog
    • Godkendelser
    • IoT
    • VoIP
    • Vidensdeling
    • WhatsApp
    Tredjepartsapps Odoo Studio Odoo Cloud-platform
  • Brancher
    Detailhandel
    • Boghandel
    • Tøjforretning
    • Møbelforretning
    • Dagligvarebutik
    • Byggemarked
    • Legetøjsforretning
    Mad og værtsskab
    • Bar og pub
    • Restaurant
    • Fastfood
    • Gæstehus
    • Drikkevareforhandler
    • Hotel
    Ejendom
    • Ejendomsmægler
    • Arkitektfirma
    • Byggeri
    • Ejendomsadministration
    • Havearbejde
    • Boligejerforening
    Rådgivning
    • Regnskabsfirma
    • Odoo-partner
    • Marketingbureau
    • Advokatfirma
    • Rekruttering
    • Audit & certificering
    Produktion
    • Tekstil
    • Metal
    • Møbler
    • Fødevareproduktion
    • Bryggeri
    • Firmagave
    Heldbred & Fitness
    • Sportsklub
    • Optiker
    • Fitnesscenter
    • Kosmetolog
    • Apotek
    • Frisør
    Håndværk
    • Handyman
    • IT-hardware og support
    • Solenergisystemer
    • Skomager
    • Rengøringsservicer
    • VVS- og ventilationsservice
    Andet
    • Nonprofitorganisation
    • Miljøagentur
    • Udlejning af billboards
    • Fotografi
    • Cykeludlejning
    • Softwareforhandler
    Gennemse alle brancher
  • Community
    Få mere at vide
    • Tutorials
    • Dokumentation
    • Certificeringer
    • Oplæring
    • Blog
    • Podcast
    Bliv klogere
    • Udannelselsesprogram
    • Scale Up!-virksomhedsspillet
    • Besøg Odoo
    Få softwaren
    • Download
    • Sammenlign versioner
    • Udgaver
    Samarbejde
    • Github
    • Forum
    • Arrangementer
    • Oversættelser
    • Bliv partner
    • Tjenester til partnere
    • Registrér dit regnskabsfirma
    Modtag tjenester
    • Find en partner
    • Find en bogholder
    • Kontakt en rådgiver
    • Implementeringstjenester
    • Kundereferencer
    • Support
    • Opgraderinger
    Github Youtube Twitter LinkedIn Instagram Facebook Spotify
    +1 (650) 691-3277
    Få en demo
  • Prissætning
  • Hjælp

Odoo is the world's easiest all-in-one management software.
It includes hundreds of business apps:

  • CRM
  • e-Commerce
  • Bogføring
  • Lager
  • PoS
  • Projekt
  • MRP
All apps
Du skal være registreret for at interagere med fællesskabet.
All Posts People Emblemer
Tags (View all)
odoo accounting v14 pos v15
Om dette forum
Du skal være registreret for at interagere med fællesskabet.
All Posts People Emblemer
Tags (View all)
odoo accounting v14 pos v15
Om dette forum
Hjælp

Why am I getting a mandatory field is not correctly error on this extended contracts code?

Tilmeld

Få besked, når der er aktivitet på dette indlæg

Dette spørgsmål er blevet anmeldt
inheritanceintegrityerrorcontractsodoo8.0
20 Besvarelser
19110 Visninger
Avatar
Yenthe Van Ginneken (Mainframe Monkey)

Hi guys,

I've been extending the contracts from the sales module so that you can create contracts for cars (linking to fleet.vehicle). I've added the following fields to the model account.analytic.invoice.line:

class account_analytic_invoice_line(osv.osv): _inherit = 'account.analytic.invoice.line' _columns = { 'car_id': fields.many2one('fleet.vehicle', 'Car'), 'analytic_car_account_id': fields.many2one('account.analytic.account', 'Analytic Account 2'), 'car_license_plate': fields.text('Nummerplaat'), 'car_mavirent_nummer': fields.text('MaviRent nummer'), 'car_chassis': fields.text('Chassis'), 'car_rent_price': fields.float('Prijs'), 'car_number_of_units': fields.integer('Aantal'), 'car_line_tax_id': fields.many2many('account.tax', 'account_car_line_tax', 'car_line_id', 'tax_id', string='BTW', required=True), 'car_account_id': fields.many2one('account.account', 'Grootboekrekening', required=True), }


Then in the contract view I've added a new one2many (the field recurring_invoice_car_line_ids) like this:

<openerp> <data> <record id="view_contract_form_inherit_be_trans" model="ir.ui.view"> <field name="name">account.analytic.account.inherit</field> <field name="model">account.analytic.account</field> <field name="inherit_id" ref="account_analytic_analysis.account_analytic_account_form_form"/> <field name="arch" type="xml"> <xpath expr="//field[@name='recurring_invoice_line_ids']" position="after"> <label for="recurring_invoice_car_line_ids" attrs="{'invisible': [('recurring_invoices','=',False)]}"/> <div attrs="{'invisible': [('recurring_invoices','=',False)]}"> <field name="recurring_invoice_car_line_ids"> <tree string="Account Analytic Lines" editable="bottom"> <field name="car_id" on_change="car_id_change(car_id, car_license_plate, car_mavirent_nummer, car_chassis, car_rent_price)" attrs="{'required':[('car_id', '!=', '')]}"/> <!--These fields are only required when there is a value in the many2one field product_id' --> <field name="car_mavirent_nummer" attrs="{'required':[('car_id', '!=', '')]}"/> <field name="car_license_plate" attrs="{'required':[('car_id', '!=', '')]}"/> <field name="car_chassis" attrs="{'required':[('car_id', '!=', '')]}"/>

<field name="car_rent_price" attrs="{'required':[('car_id', '!=', '')]}"/> <field name="car_number_of_units" attrs="{'required':[('car_id', '!=', '')]}"/> <field name="car_line_tax_id" widget="many2many_tags"/> <field name="car_account_id"/> </tree> </field> </div> </xpath> </field> </record> </data> </openerp>

Now when a record is added on this one2many a Python function (on change event) named 'car_id_change' will go off which has the following code:

def car_id_change(self, cr, uid, ids, car, car_id=None,car_name='', car_license_plate='', car_mavirent_nummer='', car_chassis='', car_rent_price=0.0,car_number_of_units=1.0, context=None): context = context or {} local_context = dict(context, car_id=car_id) result = {} if not car: return {'value': {'car_name': '', 'car_license_plate': '', car_mavirent_nummer: '', car_chassis: '','car_rent_price': 0.0, 'car_number_of_units': 1.0}} else: res = self.pool.get('fleet.vehicle').browse(cr, uid, car, context=local_context) if res['license_plate']: car_license_plate = res['license_plate'] if res['name']: car_name = res['name'] if res['MaviVoertuigNummer']: car_mavirent_nummer = res['MaviVoertuigNummer'] if res['Chassis']: car_chassis = res['Chassis'] #Get a tax to automatically add to the contract. btw_categ_pool = self.pool.get('account.tax') goede_btw_id = btw_categ_pool.search(cr, uid, [('description','=','VAT-OUT-21-S')]) result.update({'car_name': car_name,'car_license_plate': car_license_plate, 'car_mavirent_nummer': car_mavirent_nummer, 'car_chassis': car_chassis, 'car_rent_price': car_rent_price, 'car_number_of_units': car_number_of_units, 'car_line_tax_id': [(6, 0, goede_btw_id)]}) res_final = {'value':result} return res_final

Which works fine. I can choose cars and all the data is filled in automatically (atleast, which I can).
When I now click on save I get an error though:

Integrity Error

The operation cannot be completed, probably due to the following: - deletion: you may be trying to delete a record while other records still reference it - creation/update: a mandatory field is not correctly set [object with reference: name - name]

When I look in the terminal I will see the following:

openerp.sql_db: bad query: INSERT INTO "account_analytic_invoice_line" ("id", "car_mavirent_nummer", "car_license_plate", "car_account_id", "car_number_of_units", "car_chassis", "analytic_car_account_id", "car_rent_price", "car_id", "quantity", "create_uid", "write_uid", "create_date", "write_date") VALUES(nextval('account_analytic_invoice_line_id_seq'), 'MAV09', 'FFF-111', 819, 1, 'OPO06', 13, 0.0, 2, 1.0, 1, 1, (now() at time zone 'UTC'), (now() at time zone 'UTC')) RETURNING id

Traceback (most recent call last): File "/odoo/odoo-server/openerp/sql_db.py", line 234, in execute res = self._obj.execute(query, params) IntegrityError: null value in column "name" violates not-null constraint DETAIL: Failing row contains (27, null, 1, 2016-01-13 08:48:12.818483, null, null, 1, null, 2016-01-13 08:48:12.818483, 1, null, MAV09, 13, FFF-111, 1, OPO06, 819, 0, 2).


I do see there is a null value in the SQL statement and I know that is not allowed but what I don't know is where it is coming from or what I am missing that it is giving null. I'm passing along all the values if I'm not mistaking? So, how do I fix this?

Update: The error was coming from the fact that I didn't inherit the module 'account', I did inherit 'account_analytic_analysis' but not 'account'. I now have a new issue:

Integrity Error The operation cannot be completed, probably due to the following: - deletion: you may be trying to delete a record while other records still reference it - creation/update: a mandatory field is not correctly set [object with reference: price_unit - price.unit]


You can view and test the whole module, which is available on Github: https://github.com/Yenthe666/Dev/tree/master/aa_maatwerk_be_trans

Thanks,
Yenthe

2
Avatar
Kassér
Temur

what are steps to reproduce for an updated issue?

Yenthe Van Ginneken (Mainframe Monkey)
Forfatter

@Temur go to sales > contracts, create a new contract and add one car and no products. Then click on save, you will get a notification saying that a field is missing. When you click on save again you will get the error.

Axel Mendoza

not solved yet?

Yenthe Van Ginneken (Mainframe Monkey)
Forfatter

@Axel sadly no! I can't find the problem in the code.

Temur

Ok. I reproduced it

Temur

@Yenthe, I traced down the error and applied quick fix to be able to save contract according of steps to reproduce above. Please refer to updated answer and adapt solution further to meet your requirements.

Yenthe Van Ginneken (Mainframe Monkey)
Forfatter

@Temur perfect! That was exactly what I was looking for. I'll need some minor changes to have everything perfect but my problem is fixed now. Thanks a lot! Accepted & upvoted! :)

Avatar
Temur
Bedste svar

Try it please:

....
    goede_btw_id = btw_categ_pool.search(cr, uid, [('description','=','VAT-OUT-21-S')])
    if type(goede_btw_id) in (long, int,):
        browse_ids = [goede_btw_id]
    else:
        browse_ids = goede_btw_id
    for godie_btw_obj in btw_categ_pool.browse(cr, uid, browse_ids, context=context):
        if not goede_btw_obj.name:
            goede_btw_obj.name = goede_btw_obj.description
    result.update({'car_name': car_name,'car_license_plate': car_license_plate, 'car_mavirent_nummer': car_mavirent_nummer, 'car_chassis': car_chassis, 'car_rent_price': car_rent_price, 'car_number_of_units': car_number_of_units, 'car_line_tax_id': [(6, 0, goede_btw_id)]})
....


UPDATE:

'account' is in dependency list, but I've got "IntegrityError: null value in column "name" violates not-null constraint" anyway. this error were originated from missing mandatory field "name" in "account_analytic_invoice_line" object, I fixed it in place by replacing required=True to required=False... I.e. if it meant not to be required, it should be fixed as follows:


class account_analytic_invoice_line(models.Model):
    _inherit = "account.analytic.invoice.line"

name = fields.Text(required=False) 

this way "IntegrityError: null value in column "name" violates not-null constraint" error is gone away, as we made it not mandatory field by required=False incremental update.


But I've got next error, same as in question post: "IntegrityError: null value in column "price_unit" violates not-null constraint". This error were originated from "price_unit" field set as mandatory but not displayed in a form view. here we can apply two solutions, either add back to the view all mandatory fields, or make them not mandatory same as for the "name" field above. Then I've got more errors of same kind: "IntegrityError: null value in column "uom_id" violates not-null constraint", followed by: "IntegrityError: null value in column "product_id" violates not-null constraint"...  Just as a quick fix I've added this fields back to the Form View and finally I was able to save the contract without errors. Here is an xml with mandatory fields in place:


<record id="view_contract_form_inherit_be_trans" model="ir.ui.view">
<field name="name">account.analytic.account.inherit</field>
<field name="model">account.analytic.account</field>
<field name="inherit_id" ref="account_analytic_analysis.account_analytic_account_form_form"/>
<field name="arch" type="xml">
<!-- Make the date fields required -->
<xpath expr="//field[@name='date_start']" position="replace">
<field name="date_start" required="True"/>
</xpath>
<xpath expr="//field[@name='date']" position="replace">
<field name="date" required="True"/>
</xpath>
<xpath expr="//field[@name='recurring_invoice_line_ids']" position="after">
<label for="recurring_invoice_car_line_ids" attrs="{'invisible': [('recurring_invoices','=',False)]}"/>
<div attrs="{'invisible': [('recurring_invoices','=',False)]}">
<field name="recurring_invoice_car_line_ids">
<tree string="Account Analytic Lines" editable="bottom">
<field name="car_id" on_change="car_id_change(car_id, car_license_plate, car_mavirent_nummer, car_chassis, car_rent_price)" attrs="{'required':[('car_id', '!=', '')]}"/>
<!--These fields are only required when there is a value in the many2one field product_id' -->
<field name="car_mavirent_nummer" attrs="{'required':[('car_id', '!=', '')]}"/>
<field name="car_license_plate" attrs="{'required':[('car_id', '!=', '')]}"/>
<field name="car_chassis" attrs="{'required':[('car_id', '!=', '')]}"/>
<field name="car_rent_price" attrs="{'required':[('car_id', '!=', '')]}"/>
<field name="car_number_of_units" attrs="{'required':[('car_id', '!=', '')]}"/>
<field name="car_line_tax_id" widget="many2many_tags"/>
<field name="uom_id" />
<field name="product_id" />
<field name="price_unit" />

<field name="car_account_id"/>
</tree>
</field>
</div>
</xpath>
</field>
</record>


Now it's possible to go to sales > contracts, create a new contract and add one car and no products, then click on save and no errors, you can save it successfully. However the above changes are a quick fix, I've not investigated application logic deeper, please adapt solution to your case. For each mandatory field, either add them in the view or make them optional (NOT required) fields as I made optional the "name" field above, and/or review dependency list of your module again if it may change a behavior of your module, as other modules may change fields by incremental updates as well.






1
Avatar
Kassér
Yenthe Van Ginneken (Mainframe Monkey)
Forfatter

Thanks Temur but I was just missing the 'account' import, I only had 'account_analytic_analysis' and not 'account' and this was giving the strange error. I've updated my question since I now have another strange one.

Yenthe Van Ginneken (Mainframe Monkey)
Forfatter

@Temur: I've decided to put it on Github so you can see all the code and test it if you'd like / need to. See https://github.com/Yenthe666/Dev/tree/master/aa_maatwerk_be_trans

Yenthe Van Ginneken (Mainframe Monkey)
Forfatter

@Temur perfect! That was exactly what I was looking for. I'll need some minor changes to have everything perfect but my problem is fixed now. Thanks a lot! Accepted & upvoted! :)

Temur

You're welcome

Avatar
Axel Mendoza
Bedste svar

@Yenthe, i'm with Pawan on his answer, I don't think that converting the required field into non-required is a good idea, maybe doing that you end up getting broken another scenario.

For me better you follow what it's done on the model account.analytic.account on the method on_change_template building the values for the field recurring_invoice_line_ids, specifically this:

...

invoice_line_ids = []

for x in template.recurring_invoice_line_ids:

invoice_line_ids.append((0, 0, {

'product_id': x.product_id.id,

'uom_id': x.uom_id.id,

'name': x.name,

'quantity': x.quantity,

'price_unit': x.price_unit,

'analytic_account_id': x.analytic_account_id and x.analytic_account_id.id or False,

}))

res['value']['recurring_invoices'] = template.recurring_invoices

res['value']['recurring_interval'] = template.recurring_interval

res['value']['recurring_rule_type'] = template.recurring_rule_type

res['value']['recurring_invoice_line_ids'] = invoice_line_ids

...

Using this solution in your own onchange you need to add the needed fields that @Temur found that need to have a value in your editable tree, at least with invisible="1" so the onchange values could fill those fields and they will be sent to the model create/write and you will don't end up with errors for not-null fields
 

1
Avatar
Kassér
Avatar
Pawan
Bedste svar

Yenthe,

There is  a predefined fields called 'name' in account_analytic_invoice_line object which is mandatory by default, which you are not defining while returning it from on change of car field.

So adding {'name': "SOME DATA"} to the returning dictionary from the function.

Regards,

 




0
Avatar
Kassér
Yenthe Van Ginneken (Mainframe Monkey)
Forfatter

Thanks for the reply Pawan! I was thinking that to initially so at some point I added a name field in the dict but even then I get this error. An example: result.update({'car_name': car_name,'car_license_plate': car_license_plate, 'car_mavirent_nummer': car_mavirent_nummer, 'car_chassis': car_chassis, 'car_rent_price': car_rent_price, 'car_number_of_units': car_number_of_units, 'car_line_tax_id': [(6, 0, goede_btw_id)], 'name': 'Demo name'})

Temur

What about 'name' field in 'account.tax' object (in the goede_btw_id one) ? it's defined as mandatory as well

Yenthe Van Ginneken (Mainframe Monkey)
Forfatter

@Pawan and @Temur problem seem to came from the fact that I didn't inherit 'account', I had inherited 'account_analytic_analysis' but missed 'account'. I've updated my question since I now have a new issue about [object with reference: price_unit - price.unit]

Pawan

Yenthe,
price_unit also exist in "account_analytic_invoice_line", try adding {'price_unit':0.0} too in your code, and you are returning dictionary at 2 places, please confirm with both the scenarios because i can't find any other scenario for this error

Yenthe Van Ginneken (Mainframe Monkey)
Forfatter

Pawan, That was exactly my idea too but that doesn't work either. I'll keep getting the error regarding price_unit..

Yenthe Van Ginneken (Mainframe Monkey)
Forfatter

@Pawan and @Temur: I've decided to put it on Github so you can see all the code and test it if you'd like / need to. See https://github.com/Yenthe666/Dev/tree/master/aa_maatwerk_be_trans

Enjoying the discussion? Don't just read, join in!

Create an account today to enjoy exclusive features and engage with our awesome community!

Tilmeld dig
Related Posts Besvarelser Visninger Aktivitet
How to inherit / modify point of sale pages & create restrictions? Løst
inheritance point_of_sale odoo8.0
Avatar
Avatar
1
nov. 21
7993
How to inherit calendar popup? Løst
inheritance popup odoo8.0
Avatar
6
feb. 21
16273
how to inherit the timesheet view in my new modul.
modules inheritance odoo8.0
Avatar
1
jun. 16
4151
In odoo 8 Contracts Form Check Date constraints method gets triggered even after providing valid input dates. How to fix this?
constraint contracts odooV8 odoo8.0
Avatar
0
apr. 19
4990
How to add field to One2Many with xpath expressions? Løst
inheritance one2many xpath odoo8.0
Avatar
Avatar
1
apr. 15
14414
Community
  • Tutorials
  • Dokumentation
  • Forum
Open Source
  • Download
  • Github
  • Runbot
  • Oversættelser
Tjenester
  • Odoo.sh-hosting
  • Support
  • Opgradere
  • Individuelt tilpasset udvikling
  • Uddannelse
  • Find en bogholder
  • Find en partner
  • Bliv partner
Om os
  • Vores virksomhed
  • Brandaktiver
  • Kontakt os
  • Stillinger
  • Arrangementer
  • Podcast
  • Blog
  • Kunder
  • Juridiske dokumenter • Privatlivspolitik
  • Sikkerhedspolitik
الْعَرَبيّة Català 简体中文 繁體中文 (台灣) Čeština Dansk Nederlands English Suomi Français Deutsch हिंदी Bahasa Indonesia Italiano 日本語 한국어 (KR) Lietuvių kalba Język polski Português (BR) română русский язык Slovenský jazyk slovenščina Español (América Latina) Español ภาษาไทย Türkçe українська Tiếng Việt

Odoo er en samling open source-forretningsapps, der dækker alle dine virksomhedsbehov – lige fra CRM, e-handel og bogføring til lagerstyring, POS, projektledelse og meget mere.

Det unikke ved Odoo er, at systemet både er brugervenligt og fuldt integreret.

Website made with

Odoo Experience on YouTube

1. Use the live chat to ask your questions.
2. The operator answers within a few minutes.

Live support on Youtube
Watch now